All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 12/14] openipmi: no need to check for clock_gettime
Date: Sun, 18 Jun 2017 11:42:50 +0200	[thread overview]
Message-ID: <20170618094250.GN2918@scaer> (raw)
In-Reply-To: <90a050c99718b5448c574ffc491aac7c76130c87.1497583686.git.baruch@tkos.co.il>

Baruch, All,

On 2017-06-16 06:32 +0300, Baruch Siach spake thusly:
> Buildroot no longer supports toolchains with glibc older than 2.17, so there
> is no need to check whether librt is required for clock_* system calls.

To be noted: upstream has fixed that recently:
    https://sourceforge.net/p/openipmi/code/ci/488c5dbfe54cb0da26a61c0b892a4106ac87a878/

Sad that they waited two years to fix it, and that they did not use your
patch... :-(

> Signed-off-by: Baruch Siach <baruch@tkos.co.il>

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
>  ...c-detect-lrt-requirement-for-clock_gettim.patch | 57 ----------------------
>  1 file changed, 57 deletions(-)
>  delete mode 100644 package/openipmi/0002-configure.ac-detect-lrt-requirement-for-clock_gettim.patch
> 
> diff --git a/package/openipmi/0002-configure.ac-detect-lrt-requirement-for-clock_gettim.patch b/package/openipmi/0002-configure.ac-detect-lrt-requirement-for-clock_gettim.patch
> deleted file mode 100644
> index d58ffd7caf26..000000000000
> --- a/package/openipmi/0002-configure.ac-detect-lrt-requirement-for-clock_gettim.patch
> +++ /dev/null
> @@ -1,57 +0,0 @@
> -From d3be03464be7fa3844dfe0837a7e2c920c107836 Mon Sep 17 00:00:00 2001
> -From: Baruch Siach <baruch@tkos.co.il>
> -Date: Thu, 23 Jul 2015 13:35:35 +0300
> -Subject: [PATCH] configure.ac: detect -lrt requirement for clock_gettime
> -
> -glibc versions before 2.17 require link with -lrt.
> -
> -Upstream status: sent, stuck in moderator's queue
> -
> -Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ----
> - configure.ac     | 8 ++++++++
> - unix/Makefile.am | 4 ++--
> - 2 files changed, 10 insertions(+), 2 deletions(-)
> -
> -diff --git a/configure.ac b/configure.ac
> -index 18401f161d45..6b350a41a916 100644
> ---- a/configure.ac
> -+++ b/configure.ac
> -@@ -854,6 +854,14 @@ OPENIPMI_SWIG_SO="${PYTHON_POSIX_SO}:\$(top_builddir)/lib/.libs/libOpenIPMI.so:\
> - AC_SUBST(OPENIPMI_SWIG_LIBS)
> - AC_SUBST(OPENIPMI_SWIG_SO)
> - 
> -+LIB_CLOCK_GETTIME=
> -+clk_saved_libs=$LIBS
> -+AC_SEARCH_LIBS([clock_gettime], [rt],
> -+	       [test "$ac_cv_search_clock_gettime" = "none required" ||
> -+		LIB_CLOCK_GETTIME=$ac_cv_search_clock_gettime])
> -+AC_SUBST([LIB_CLOCK_GETTIME])
> -+LIBS=$clk_saved_libs
> -+
> - # Everything from here to AC_OUTPUT is for libedit
> - 
> - # AC_PROG_LIBTOOL runs AC_CANONICAL_HOST
> -diff --git a/unix/Makefile.am b/unix/Makefile.am
> -index a108bc679c9a..fb60242d5d3b 100644
> ---- a/unix/Makefile.am
> -+++ b/unix/Makefile.am
> -@@ -9,13 +9,13 @@ lib_LTLIBRARIES = libOpenIPMIposix.la libOpenIPMIpthread.la
> - 
> - libOpenIPMIpthread_la_SOURCES = posix_thread_os_hnd.c selector.c
> - libOpenIPMIpthread_la_LIBADD = -lpthread $(GDBM_LIB) \
> --	$(top_builddir)/utils/libOpenIPMIutils.la
> -+	$(top_builddir)/utils/libOpenIPMIutils.la $(LIB_CLOCK_GETTIME)
> - libOpenIPMIpthread_la_LDFLAGS = -rdynamic -version-info $(LD_VERSION) \
> - 	-Wl,-Map -Wl,libOpenIPMIpthread.map
> - 
> - libOpenIPMIposix_la_SOURCES = posix_os_hnd.c selector.c
> - libOpenIPMIposix_la_LIBADD = $(top_builddir)/utils/libOpenIPMIutils.la \
> --	$(GDBM_LIB)
> -+	$(GDBM_LIB) $(LIB_CLOCK_GETTIME)
> - libOpenIPMIposix_la_LDFLAGS = -rdynamic -version-info $(LD_VERSION) \
> - 	-Wl,-Map -Wl,libOpenIPMIposix.map
> - 
> --- 
> -2.1.4
> -
> -- 
> 2.11.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2017-06-18  9:42 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-16  3:32 [Buildroot] [PATCH 00/14] toolchain-external: remove support for glibc before 2.17 Baruch Siach
2017-06-16  3:32 ` [Buildroot] [PATCH 01/14] docs/manual: update external toolchain advantages list Baruch Siach
2017-06-18  9:02   ` Yann E. MORIN
2017-06-16  3:32 ` [Buildroot] [PATCH 02/14] toolchain: remove CodeSourcery x86 toolchain Baruch Siach
2017-06-18  9:08   ` Yann E. MORIN
2017-06-18  9:14     ` Baruch Siach
2017-06-18  9:19       ` Yann E. MORIN
2017-06-16  3:32 ` [Buildroot] [PATCH 03/14] toolchain: remove CodeSourcery sh toolchain Baruch Siach
2017-06-18  9:09   ` Yann E. MORIN
2017-06-16  3:32 ` [Buildroot] [PATCH 04/14] package: remove CodeSourcery sh dependencies Baruch Siach
2017-06-18  9:12   ` Yann E. MORIN
2017-06-16  3:32 ` [Buildroot] [PATCH 05/14] toolchain-external: update list of toolchains Baruch Siach
2017-06-18  9:21   ` Yann E. MORIN
2017-06-16  3:32 ` [Buildroot] [PATCH 06/14] docs/manual: drop mention of removed external toolchains Baruch Siach
2017-06-18  9:23   ` Yann E. MORIN
2017-06-16  3:32 ` [Buildroot] [PATCH 07/14] swupdate: don't link with librt Baruch Siach
2017-06-18  9:26   ` Yann E. MORIN
2017-06-16  3:32 ` [Buildroot] [PATCH 08/14] aiccu: " Baruch Siach
2017-06-18  9:27   ` Yann E. MORIN
2017-06-16  3:32 ` [Buildroot] [PATCH 09/14] libv4l: " Baruch Siach
2017-06-18  9:31   ` Yann E. MORIN
2017-06-18  9:34     ` Baruch Siach
2017-06-18  9:36       ` Yann E. MORIN
2017-06-16  3:32 ` [Buildroot] [PATCH 10/14] e2fsprogs: " Baruch Siach
2017-06-18  9:33   ` Yann E. MORIN
2017-06-18 10:13     ` Baruch Siach
2017-06-18 11:55       ` Yann E. MORIN
2017-06-19 19:14         ` Baruch Siach
2017-06-16  3:32 ` [Buildroot] [PATCH 11/14] liboping: no need to check for clock_gettime Baruch Siach
2017-06-18  9:37   ` Yann E. MORIN
2017-06-16  3:32 ` [Buildroot] [PATCH 12/14] openipmi: " Baruch Siach
2017-06-18  9:42   ` Yann E. MORIN [this message]
2017-06-16  3:32 ` [Buildroot] [PATCH 13/14] lirc-tools: " Baruch Siach
2017-06-18  9:45   ` Yann E. MORIN
2017-06-16  3:32 ` [Buildroot] [PATCH 14/14] softether: " Baruch Siach
2017-06-18  9:47   ` Yann E. MORIN
2017-06-20 20:23 ` [Buildroot] [PATCH 00/14] toolchain-external: remove support for glibc before 2.17 Thomas Petazzoni
2017-06-22  7:57 ` Arnout Vandecappelle
2017-06-22 17:01   ` Baruch Siach
2017-06-23 21:33     ` Waldemar Brodkorb
2017-06-25  4:57       ` Baruch Siach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170618094250.GN2918@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.