All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 10/14] e2fsprogs: don't link with librt
Date: Sun, 18 Jun 2017 13:55:29 +0200	[thread overview]
Message-ID: <20170618115529.GQ2918@scaer> (raw)
In-Reply-To: <20170618101301.hxhzvmcd4vntmdmf@tarshish>

Baruch, All,

On 2017-06-18 13:13 +0300, Baruch Siach spake thusly:
> On Sun, Jun 18, 2017 at 11:33:09AM +0200, Yann E. MORIN wrote:
> > On 2017-06-16 06:32 +0300, Baruch Siach spake thusly:
> > > Buildroot no longer supports toolchains with glibc older than 2.17, so there
> > > is no need to link with librt for clock_* system calls.
> > > 
> > > Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> > 
> > Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> 
> Thanks.
> 
> On a second thought, e2fsprogs is also a host package. We don't want to 
> abandon pre glibc 2.17 hosts just yet, do we?

Indeed no.

But the patch was made to fix a build failure for fuse2fs, which we
explicitly disable for the host variant.

So, we really can drop this patch.

Regards,
Yann E. MORIN.

> baruch
> 
> > > ---
> > >  .../0002-MCONFIG.in-handle-CLOCK_GETTIME_LIB.patch | 35 ----------------------
> > >  1 file changed, 35 deletions(-)
> > >  delete mode 100644 package/e2fsprogs/0002-MCONFIG.in-handle-CLOCK_GETTIME_LIB.patch
> > > 
> > > diff --git a/package/e2fsprogs/0002-MCONFIG.in-handle-CLOCK_GETTIME_LIB.patch b/package/e2fsprogs/0002-MCONFIG.in-handle-CLOCK_GETTIME_LIB.patch
> > > deleted file mode 100644
> > > index bd86c4e21a3d..000000000000
> > > --- a/package/e2fsprogs/0002-MCONFIG.in-handle-CLOCK_GETTIME_LIB.patch
> > > +++ /dev/null
> > > @@ -1,35 +0,0 @@
> > > -From b5baf15b36107925186d89af9097b4b8e2d7cad6 Mon Sep 17 00:00:00 2001
> > > -From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> > > -Date: Wed, 21 Sep 2016 08:38:21 +0200
> > > -Subject: [PATCH] MCONFIG.in: handle CLOCK_GETTIME_LIB
> > > -
> > > -Commit 62bc243f1bfe623312a350e4cd0d2e17a69aac45 ("fuse2fs: might need
> > > -librt") added a check for the clock_gettime() to verify whether linking
> > > -with the librt library is needed or not to use this function.
> > > -
> > > -However, this commit forgot the change in MCONFIG.in that allows to
> > > -define the make variable CLOCK_GETTIME_LIB from the CLOCK_GETTIME_LIB
> > > -variable substituted by the configure script. Due to this, from a make
> > > -perspective $(CLOCK_GETTIME_LIB) is always empty, and we get link
> > > -failure on platforms where clock_gettime() is available in librt.
> > > -
> > > -Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> > > ----
> > > - MCONFIG.in | 1 +
> > > - 1 file changed, 1 insertion(+)
> > > -
> > > -diff --git a/MCONFIG.in b/MCONFIG.in
> > > -index e82963d..9ba9ce2 100644
> > > ---- a/MCONFIG.in
> > > -+++ b/MCONFIG.in
> > > -@@ -125,6 +125,7 @@ LIBSUPPORT = $(LIBINTL) $(LIB)/libsupport at STATIC_LIB_EXT@
> > > - LIBBLKID = @LIBBLKID@ @PRIVATE_LIBS_CMT@ $(LIBUUID)
> > > - LIBINTL = @LIBINTL@
> > > - SYSLIBS = @LIBS@
> > > -+CLOCK_GETTIME_LIB = @CLOCK_GETTIME_LIB@
> > > - DEPLIBSS = $(LIB)/libss at LIB_EXT@
> > > - DEPLIBCOM_ERR = $(LIB)/libcom_err at LIB_EXT@
> > > - DEPLIBUUID = @DEPLIBUUID@
> 
> -- 
>      http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
> =}------------------------------------------------ooO--U--Ooo------------{=
>    - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2017-06-18 11:55 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-16  3:32 [Buildroot] [PATCH 00/14] toolchain-external: remove support for glibc before 2.17 Baruch Siach
2017-06-16  3:32 ` [Buildroot] [PATCH 01/14] docs/manual: update external toolchain advantages list Baruch Siach
2017-06-18  9:02   ` Yann E. MORIN
2017-06-16  3:32 ` [Buildroot] [PATCH 02/14] toolchain: remove CodeSourcery x86 toolchain Baruch Siach
2017-06-18  9:08   ` Yann E. MORIN
2017-06-18  9:14     ` Baruch Siach
2017-06-18  9:19       ` Yann E. MORIN
2017-06-16  3:32 ` [Buildroot] [PATCH 03/14] toolchain: remove CodeSourcery sh toolchain Baruch Siach
2017-06-18  9:09   ` Yann E. MORIN
2017-06-16  3:32 ` [Buildroot] [PATCH 04/14] package: remove CodeSourcery sh dependencies Baruch Siach
2017-06-18  9:12   ` Yann E. MORIN
2017-06-16  3:32 ` [Buildroot] [PATCH 05/14] toolchain-external: update list of toolchains Baruch Siach
2017-06-18  9:21   ` Yann E. MORIN
2017-06-16  3:32 ` [Buildroot] [PATCH 06/14] docs/manual: drop mention of removed external toolchains Baruch Siach
2017-06-18  9:23   ` Yann E. MORIN
2017-06-16  3:32 ` [Buildroot] [PATCH 07/14] swupdate: don't link with librt Baruch Siach
2017-06-18  9:26   ` Yann E. MORIN
2017-06-16  3:32 ` [Buildroot] [PATCH 08/14] aiccu: " Baruch Siach
2017-06-18  9:27   ` Yann E. MORIN
2017-06-16  3:32 ` [Buildroot] [PATCH 09/14] libv4l: " Baruch Siach
2017-06-18  9:31   ` Yann E. MORIN
2017-06-18  9:34     ` Baruch Siach
2017-06-18  9:36       ` Yann E. MORIN
2017-06-16  3:32 ` [Buildroot] [PATCH 10/14] e2fsprogs: " Baruch Siach
2017-06-18  9:33   ` Yann E. MORIN
2017-06-18 10:13     ` Baruch Siach
2017-06-18 11:55       ` Yann E. MORIN [this message]
2017-06-19 19:14         ` Baruch Siach
2017-06-16  3:32 ` [Buildroot] [PATCH 11/14] liboping: no need to check for clock_gettime Baruch Siach
2017-06-18  9:37   ` Yann E. MORIN
2017-06-16  3:32 ` [Buildroot] [PATCH 12/14] openipmi: " Baruch Siach
2017-06-18  9:42   ` Yann E. MORIN
2017-06-16  3:32 ` [Buildroot] [PATCH 13/14] lirc-tools: " Baruch Siach
2017-06-18  9:45   ` Yann E. MORIN
2017-06-16  3:32 ` [Buildroot] [PATCH 14/14] softether: " Baruch Siach
2017-06-18  9:47   ` Yann E. MORIN
2017-06-20 20:23 ` [Buildroot] [PATCH 00/14] toolchain-external: remove support for glibc before 2.17 Thomas Petazzoni
2017-06-22  7:57 ` Arnout Vandecappelle
2017-06-22 17:01   ` Baruch Siach
2017-06-23 21:33     ` Waldemar Brodkorb
2017-06-25  4:57       ` Baruch Siach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170618115529.GQ2918@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.