* [GIT PULL] Second Round of Renesas ARM Based SoC Fixes for v4.12
@ 2017-06-12 9:27 ` Simon Horman
0 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2017-06-12 9:27 UTC (permalink / raw)
To: arm
Cc: linux-renesas-soc, Olof Johansson, Kevin Hilman, Arnd Bergmann,
linux-arm-kernel, Magnus Damm, Simon Horman
Hi Olof, Hi Kevin, Hi Arnd,
Please consider these second round of Renesas ARM based SoC fixes for v4.12.
It splits LCD mux and gpio into separate nodes as different values
for the output-high property are required.
This pull request is based on the previous round of
such requests, tagged as renesas-fixes-for-v4.12,
which I have already sent a pull-request for.
The following changes since commit 7b4ccb3c466f62bbf2f4dd5d6a143d945a6f3051:
soc: renesas: Provide dummy rcar_rst_read_mode_pins() for compile-testing (2017-04-28 10:07:36 +0200)
are available in the git repository at:
https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git tags/renesas-fixes2-for-v4.12
for you to fetch changes up to 13132b3f44d3600983aceb7e9920b8ebb55a7cf8:
ARM: dts: armadillo800eva: Split LCD mux and gpio (2017-06-08 15:44:55 +0200)
----------------------------------------------------------------
Second Round of Renesas ARM Based SoC Fixes for v4.12
* Split LCD mux and gpio on armadillo800eva board
----------------------------------------------------------------
Geert Uytterhoeven (1):
ARM: dts: armadillo800eva: Split LCD mux and gpio
arch/arm/boot/dts/r8a7740-armadillo800eva.dts | 2 ++
1 file changed, 2 insertions(+)
^ permalink raw reply [flat|nested] 6+ messages in thread* [GIT PULL] Second Round of Renesas ARM Based SoC Fixes for v4.12
@ 2017-06-12 9:27 ` Simon Horman
0 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2017-06-12 9:27 UTC (permalink / raw)
To: linux-arm-kernel
Hi Olof, Hi Kevin, Hi Arnd,
Please consider these second round of Renesas ARM based SoC fixes for v4.12.
It splits LCD mux and gpio into separate nodes as different values
for the output-high property are required.
This pull request is based on the previous round of
such requests, tagged as renesas-fixes-for-v4.12,
which I have already sent a pull-request for.
The following changes since commit 7b4ccb3c466f62bbf2f4dd5d6a143d945a6f3051:
soc: renesas: Provide dummy rcar_rst_read_mode_pins() for compile-testing (2017-04-28 10:07:36 +0200)
are available in the git repository at:
https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git tags/renesas-fixes2-for-v4.12
for you to fetch changes up to 13132b3f44d3600983aceb7e9920b8ebb55a7cf8:
ARM: dts: armadillo800eva: Split LCD mux and gpio (2017-06-08 15:44:55 +0200)
----------------------------------------------------------------
Second Round of Renesas ARM Based SoC Fixes for v4.12
* Split LCD mux and gpio on armadillo800eva board
----------------------------------------------------------------
Geert Uytterhoeven (1):
ARM: dts: armadillo800eva: Split LCD mux and gpio
arch/arm/boot/dts/r8a7740-armadillo800eva.dts | 2 ++
1 file changed, 2 insertions(+)
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] ARM: dts: armadillo800eva: Split LCD mux and gpio
2017-06-12 9:27 ` Simon Horman
@ 2017-06-12 9:27 ` Simon Horman
-1 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2017-06-12 9:27 UTC (permalink / raw)
To: linux-renesas-soc
Cc: linux-arm-kernel, Magnus Damm, Geert Uytterhoeven, Simon Horman
From: Geert Uytterhoeven <geert+renesas@glider.be>
Configuration of the lcd0 pinmux group and GPIO hog for the external
GPIO mux are done using a single device node, causing the "output-high"
property to be applied to both. This will fail for the pinmux group,
but doesn't cause any harm, as the failure is ignored silently.
However, after "pinctrl: sh-pfc: propagate errors on group config", the
failure will become fatal, leading to a broken display:
sh-pfc e6050000.pin-controller: pin_config_group_set op failed for group 102
sh-pfc e6050000.pin-controller: Error applying setting, reverse things back
sh-pfc e6050000.pin-controller: failed to select default state
Move the GPIO hog to its own node to fix this.
Fixes: ffd2f9a5afb730b9 ("ARM: shmobile: armadillo800eva dts: Add pinctrl and gpio-hog for lcdc0")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
arch/arm/boot/dts/r8a7740-armadillo800eva.dts | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/r8a7740-armadillo800eva.dts b/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
index 7885075428bb..1788e186a512 100644
--- a/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
+++ b/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
@@ -266,7 +266,9 @@
lcd0_pins: lcd0 {
groups = "lcd0_data24_0", "lcd0_lclk_1", "lcd0_sync";
function = "lcd0";
+ };
+ lcd0_mux {
/* DBGMD/LCDC0/FSIA MUX */
gpio-hog;
gpios = <176 0>;
--
2.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] ARM: dts: armadillo800eva: Split LCD mux and gpio
@ 2017-06-12 9:27 ` Simon Horman
0 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2017-06-12 9:27 UTC (permalink / raw)
To: linux-arm-kernel
From: Geert Uytterhoeven <geert+renesas@glider.be>
Configuration of the lcd0 pinmux group and GPIO hog for the external
GPIO mux are done using a single device node, causing the "output-high"
property to be applied to both. This will fail for the pinmux group,
but doesn't cause any harm, as the failure is ignored silently.
However, after "pinctrl: sh-pfc: propagate errors on group config", the
failure will become fatal, leading to a broken display:
sh-pfc e6050000.pin-controller: pin_config_group_set op failed for group 102
sh-pfc e6050000.pin-controller: Error applying setting, reverse things back
sh-pfc e6050000.pin-controller: failed to select default state
Move the GPIO hog to its own node to fix this.
Fixes: ffd2f9a5afb730b9 ("ARM: shmobile: armadillo800eva dts: Add pinctrl and gpio-hog for lcdc0")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
arch/arm/boot/dts/r8a7740-armadillo800eva.dts | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/r8a7740-armadillo800eva.dts b/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
index 7885075428bb..1788e186a512 100644
--- a/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
+++ b/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
@@ -266,7 +266,9 @@
lcd0_pins: lcd0 {
groups = "lcd0_data24_0", "lcd0_lclk_1", "lcd0_sync";
function = "lcd0";
+ };
+ lcd0_mux {
/* DBGMD/LCDC0/FSIA MUX */
gpio-hog;
gpios = <176 0>;
--
2.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [GIT PULL] Second Round of Renesas ARM Based SoC Fixes for v4.12
2017-06-12 9:27 ` Simon Horman
@ 2017-06-19 2:21 ` Olof Johansson
-1 siblings, 0 replies; 6+ messages in thread
From: Olof Johansson @ 2017-06-19 2:21 UTC (permalink / raw)
To: Simon Horman
Cc: arm, linux-renesas-soc, Kevin Hilman, Arnd Bergmann,
linux-arm-kernel, Magnus Damm
Hi,
On Mon, Jun 12, 2017 at 11:27:22AM +0200, Simon Horman wrote:
> Hi Olof, Hi Kevin, Hi Arnd,
>
> Please consider these second round of Renesas ARM based SoC fixes for v4.12.
>
> It splits LCD mux and gpio into separate nodes as different values
> for the output-high property are required.
>
> This pull request is based on the previous round of
> such requests, tagged as renesas-fixes-for-v4.12,
> which I have already sent a pull-request for.
>
>
> The following changes since commit 7b4ccb3c466f62bbf2f4dd5d6a143d945a6f3051:
>
> soc: renesas: Provide dummy rcar_rst_read_mode_pins() for compile-testing (2017-04-28 10:07:36 +0200)
>
> are available in the git repository at:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git tags/renesas-fixes2-for-v4.12
>
> for you to fetch changes up to 13132b3f44d3600983aceb7e9920b8ebb55a7cf8:
>
> ARM: dts: armadillo800eva: Split LCD mux and gpio (2017-06-08 15:44:55 +0200)
>
> ----------------------------------------------------------------
> Second Round of Renesas ARM Based SoC Fixes for v4.12
>
> * Split LCD mux and gpio on armadillo800eva board
So, Geert wrote a great patch description as to why this patch is
important as a fix, but none of that made it into the pull request.
When you have the write-up already available, and especially this late in the
release cycle, it'd really be preferred to have it make it into the tag
description. As always, documentation of the _why_ is a lot more important than
the _what_.
Merged into fixes-non-critical for the v4.13 merge window, since the
fixed commit is two years old and thus doesn't seem like an urgent fix.
Note that this means that any new fixes that are indeed urgent can't be based
on this branch, they need to be sent independently.
Thanks,
-Olof
^ permalink raw reply [flat|nested] 6+ messages in thread
* [GIT PULL] Second Round of Renesas ARM Based SoC Fixes for v4.12
@ 2017-06-19 2:21 ` Olof Johansson
0 siblings, 0 replies; 6+ messages in thread
From: Olof Johansson @ 2017-06-19 2:21 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On Mon, Jun 12, 2017 at 11:27:22AM +0200, Simon Horman wrote:
> Hi Olof, Hi Kevin, Hi Arnd,
>
> Please consider these second round of Renesas ARM based SoC fixes for v4.12.
>
> It splits LCD mux and gpio into separate nodes as different values
> for the output-high property are required.
>
> This pull request is based on the previous round of
> such requests, tagged as renesas-fixes-for-v4.12,
> which I have already sent a pull-request for.
>
>
> The following changes since commit 7b4ccb3c466f62bbf2f4dd5d6a143d945a6f3051:
>
> soc: renesas: Provide dummy rcar_rst_read_mode_pins() for compile-testing (2017-04-28 10:07:36 +0200)
>
> are available in the git repository at:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git tags/renesas-fixes2-for-v4.12
>
> for you to fetch changes up to 13132b3f44d3600983aceb7e9920b8ebb55a7cf8:
>
> ARM: dts: armadillo800eva: Split LCD mux and gpio (2017-06-08 15:44:55 +0200)
>
> ----------------------------------------------------------------
> Second Round of Renesas ARM Based SoC Fixes for v4.12
>
> * Split LCD mux and gpio on armadillo800eva board
So, Geert wrote a great patch description as to why this patch is
important as a fix, but none of that made it into the pull request.
When you have the write-up already available, and especially this late in the
release cycle, it'd really be preferred to have it make it into the tag
description. As always, documentation of the _why_ is a lot more important than
the _what_.
Merged into fixes-non-critical for the v4.13 merge window, since the
fixed commit is two years old and thus doesn't seem like an urgent fix.
Note that this means that any new fixes that are indeed urgent can't be based
on this branch, they need to be sent independently.
Thanks,
-Olof
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-06-19 3:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-12 9:27 [GIT PULL] Second Round of Renesas ARM Based SoC Fixes for v4.12 Simon Horman
2017-06-12 9:27 ` Simon Horman
2017-06-12 9:27 ` [PATCH] ARM: dts: armadillo800eva: Split LCD mux and gpio Simon Horman
2017-06-12 9:27 ` Simon Horman
2017-06-19 2:21 ` [GIT PULL] Second Round of Renesas ARM Based SoC Fixes for v4.12 Olof Johansson
2017-06-19 2:21 ` Olof Johansson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.