All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] clk: renesas: cpg-mssr: Use of_device_get_match_data() helper
@ 2017-06-09 12:49 Geert Uytterhoeven
  2017-06-20  1:06 ` Stephen Boyd
  0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2017-06-09 12:49 UTC (permalink / raw)
  To: Michael Turquette, Stephen Boyd
  Cc: linux-renesas-soc, linux-clk, Geert Uytterhoeven

If CONFIG_OF=n:

    drivers/clk/renesas/renesas-cpg-mssr.c: In function ‘cpg_mssr_probe’:
    drivers/clk/renesas/renesas-cpg-mssr.c:702: warning: dereferencing ‘void *’ pointer
    drivers/clk/renesas/renesas-cpg-mssr.c:702: error: request for member ‘data’ in something not a structure or union

To fix this, use the of_device_get_match_data() helper, for which a
dummy version is provided if CONFIG_OF=n.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Feel free to apply directly, as I currently don't have more material
for clk-renesas-for-v4.13.

 drivers/clk/renesas/renesas-cpg-mssr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/renesas/renesas-cpg-mssr.c b/drivers/clk/renesas/renesas-cpg-mssr.c
index f44a8125615bd75a..1f607c806f9b9ec3 100644
--- a/drivers/clk/renesas/renesas-cpg-mssr.c
+++ b/drivers/clk/renesas/renesas-cpg-mssr.c
@@ -699,7 +699,7 @@ static int __init cpg_mssr_probe(struct platform_device *pdev)
 	struct clk **clks;
 	int error;
 
-	info = of_match_node(cpg_mssr_match, np)->data;
+	info = of_device_get_match_data(dev);
 	if (info->init) {
 		error = info->init(dev);
 		if (error)
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] clk: renesas: cpg-mssr: Use of_device_get_match_data() helper
  2017-06-09 12:49 [PATCH] clk: renesas: cpg-mssr: Use of_device_get_match_data() helper Geert Uytterhoeven
@ 2017-06-20  1:06 ` Stephen Boyd
  0 siblings, 0 replies; 2+ messages in thread
From: Stephen Boyd @ 2017-06-20  1:06 UTC (permalink / raw)
  To: Geert Uytterhoeven; +Cc: Michael Turquette, linux-renesas-soc, linux-clk

On 06/09, Geert Uytterhoeven wrote:
> If CONFIG_OF=n:
> 
>     drivers/clk/renesas/renesas-cpg-mssr.c: In function ‘cpg_mssr_probe’:
>     drivers/clk/renesas/renesas-cpg-mssr.c:702: warning: dereferencing ‘void *’ pointer
>     drivers/clk/renesas/renesas-cpg-mssr.c:702: error: request for member ‘data’ in something not a structure or union
> 
> To fix this, use the of_device_get_match_data() helper, for which a
> dummy version is provided if CONFIG_OF=n.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---

Applied to clk-next

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-06-20  1:06 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-09 12:49 [PATCH] clk: renesas: cpg-mssr: Use of_device_get_match_data() helper Geert Uytterhoeven
2017-06-20  1:06 ` Stephen Boyd

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.