From: Shawn Guo <shawnguo@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, Shawn Guo <shawn.guo@linaro.org>,
Baoyou Xie <xie.baoyou@sanechips.com.cn>,
Xin Zhou <zhou.xin8@sanechips.com.cn>,
Jun Nie <jun.nie@linaro.org>, Baoyou Xie <baoyou.xie@linaro.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] ASoC: add bindings for ZTE zx-aud96p22 audio codec
Date: Tue, 20 Jun 2017 11:11:32 +0800 [thread overview]
Message-ID: <20170620031131.GB4818@x250> (raw)
In-Reply-To: <20170619161606.g6nabi2w5mmmjbcw@sirena.org.uk>
On Mon, Jun 19, 2017 at 05:16:06PM +0100, Mark Brown wrote:
> On Sat, Jun 17, 2017 at 10:09:33PM +0800, Shawn Guo wrote:
>
> > +Optional properties:
> > + - zte,pa-gpios: The GPIO to enable external power amplifier
>
> If there's an external power amplifier this is a separate chip to this
> CODEC and should therefore be separately controlled and integrated as
> part of the machine integration.
Yes, that should be the best. But we do not have a particular machine
driver for our platform, and we are using simple-audio-card driver
instead. I'm not sure if it's generic enough to patch simple-audio-card
driver support this pa-gpios, so chose to fold this quick change in the
codec driver.
Should I patch simple-audio-card driver to support pa-gpios property
and create a DAPM widget with event for it? I'm currently using
SND_SOC_DAPM_OUT_DRV_E. Is it the correct one?
Shawn
WARNING: multiple messages have this Message-ID (diff)
From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ASoC: add bindings for ZTE zx-aud96p22 audio codec
Date: Tue, 20 Jun 2017 11:11:32 +0800 [thread overview]
Message-ID: <20170620031131.GB4818@x250> (raw)
In-Reply-To: <20170619161606.g6nabi2w5mmmjbcw@sirena.org.uk>
On Mon, Jun 19, 2017 at 05:16:06PM +0100, Mark Brown wrote:
> On Sat, Jun 17, 2017 at 10:09:33PM +0800, Shawn Guo wrote:
>
> > +Optional properties:
> > + - zte,pa-gpios: The GPIO to enable external power amplifier
>
> If there's an external power amplifier this is a separate chip to this
> CODEC and should therefore be separately controlled and integrated as
> part of the machine integration.
Yes, that should be the best. But we do not have a particular machine
driver for our platform, and we are using simple-audio-card driver
instead. I'm not sure if it's generic enough to patch simple-audio-card
driver support this pa-gpios, so chose to fold this quick change in the
codec driver.
Should I patch simple-audio-card driver to support pa-gpios property
and create a DAPM widget with event for it? I'm currently using
SND_SOC_DAPM_OUT_DRV_E. Is it the correct one?
Shawn
next prev parent reply other threads:[~2017-06-20 3:11 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-17 14:09 [PATCH 0/2] Add ZTE ZTE zx-aud96p22 audio codec driver Shawn Guo
2017-06-17 14:09 ` Shawn Guo
2017-06-17 14:09 ` [PATCH 1/2] ASoC: add bindings for ZTE zx-aud96p22 audio codec Shawn Guo
2017-06-17 14:09 ` Shawn Guo
2017-06-19 16:16 ` Mark Brown
2017-06-19 16:16 ` Mark Brown
2017-06-20 3:11 ` Shawn Guo [this message]
2017-06-20 3:11 ` Shawn Guo
2017-06-20 14:33 ` Mark Brown
2017-06-20 14:33 ` Mark Brown
2017-06-21 13:22 ` Shawn Guo
2017-06-21 13:22 ` Shawn Guo
2017-06-17 14:09 ` [PATCH 2/2] ASoC: zx_aud96p22: add ZTE ZX AUD96P22 codec driver Shawn Guo
2017-06-17 14:09 ` Shawn Guo
2017-06-19 16:19 ` Mark Brown
2017-06-19 16:19 ` Mark Brown
2017-06-20 3:19 ` Shawn Guo
2017-06-20 3:19 ` Shawn Guo
2017-06-20 12:40 ` Mark Brown
2017-06-20 12:40 ` Mark Brown
2017-06-21 16:03 ` Shawn Guo
2017-06-21 16:03 ` Shawn Guo
2017-06-21 16:13 ` Mark Brown
2017-06-21 16:13 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170620031131.GB4818@x250 \
--to=shawnguo@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=baoyou.xie@linaro.org \
--cc=broonie@kernel.org \
--cc=jun.nie@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=shawn.guo@linaro.org \
--cc=xie.baoyou@sanechips.com.cn \
--cc=zhou.xin8@sanechips.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.