From: Christoph Hellwig <hch@infradead.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 7/7] xfs: Switch to iomap for seeking in quota files
Date: Mon, 19 Jun 2017 23:31:35 -0700 [thread overview]
Message-ID: <20170620063135.GA12636@infradead.org> (raw)
In-Reply-To: <20170616153029.GB5421@birch.djwong.org>
On Fri, Jun 16, 2017 at 08:30:29AM -0700, Darrick J. Wong wrote:
> On Fri, Jun 16, 2017 at 04:51:20PM +0200, Andreas Gruenbacher wrote:
> > (This patch is largely untested.)
>
> In principle the XFS bits look ok, but I think you'd be better off with
> a review from hch and, uh, while you wait, a run through the xfstests
> 'quota' group and probably 'auto' too?
I think for the quota code we should simply not even use seek
hole / data. Quota files don't have delayed allocations, unwritten
extents or COW forks, so it's just a trivial lookup in the extent
list. I'll fix that part up to make Andreas' life easier.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Andreas Gruenbacher <agruenba@redhat.com>,
linux-fsdevel@vger.kernel.org, cluster-devel@redhat.com,
linux-xfs@vger.kernel.org
Subject: Re: [Cluster-devel] [PATCH 7/7] xfs: Switch to iomap for seeking in quota files
Date: Mon, 19 Jun 2017 23:31:35 -0700 [thread overview]
Message-ID: <20170620063135.GA12636@infradead.org> (raw)
In-Reply-To: <20170616153029.GB5421@birch.djwong.org>
On Fri, Jun 16, 2017 at 08:30:29AM -0700, Darrick J. Wong wrote:
> On Fri, Jun 16, 2017 at 04:51:20PM +0200, Andreas Gruenbacher wrote:
> > (This patch is largely untested.)
>
> In principle the XFS bits look ok, but I think you'd be better off with
> a review from hch and, uh, while you wait, a run through the xfstests
> 'quota' group and probably 'auto' too?
I think for the quota code we should simply not even use seek
hole / data. Quota files don't have delayed allocations, unwritten
extents or COW forks, so it's just a trivial lookup in the extent
list. I'll fix that part up to make Andreas' life easier.
next prev parent reply other threads:[~2017-06-20 6:31 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-16 14:51 [Cluster-devel] [PATCH 0/7] lseek SEEK_HOLE / SEEK_DATA via iomap Andreas Gruenbacher
2017-06-16 14:51 ` Andreas Gruenbacher
2017-06-16 14:51 ` [Cluster-devel] [PATCH 1/7] GFS2: Make height info part of metapath Andreas Gruenbacher
2017-06-16 14:51 ` Andreas Gruenbacher
2017-06-16 14:51 ` [Cluster-devel] [PATCH 2/7] GFS2: Implement iomap for block_map Andreas Gruenbacher
2017-06-16 14:51 ` Andreas Gruenbacher
2017-06-16 14:51 ` [Cluster-devel] [PATCH 3/7] GFS2: Switch fiemap implementation to use iomap Andreas Gruenbacher
2017-06-16 14:51 ` Andreas Gruenbacher
2017-06-16 14:51 ` [Cluster-devel] [PATCH 4/7] vfs: Add iomap_seek_hole_data helper Andreas Gruenbacher
2017-06-16 14:51 ` Andreas Gruenbacher
2017-06-19 17:32 ` [Cluster-devel] " Darrick J. Wong
2017-06-19 17:32 ` Darrick J. Wong
2017-06-16 14:51 ` [Cluster-devel] [PATCH 5/7] gfs2: Implement lseek SEEK_HOLE / SEEK_DATA via iomap Andreas Gruenbacher
2017-06-16 14:51 ` Andreas Gruenbacher
2017-06-16 14:51 ` [Cluster-devel] [PATCH 6/7] xfs: Switch to iomap for lseek SEEK_HOLE / SEEK_DATA Andreas Gruenbacher
2017-06-16 14:51 ` Andreas Gruenbacher
2017-06-17 23:57 ` [Cluster-devel] " Dave Chinner
2017-06-17 23:57 ` Dave Chinner
2017-06-19 22:16 ` [Cluster-devel] " Andreas Gruenbacher
2017-06-19 22:16 ` Andreas Gruenbacher
2017-06-16 14:51 ` [Cluster-devel] [PATCH 7/7] xfs: Switch to iomap for seeking in quota files Andreas Gruenbacher
2017-06-16 14:51 ` Andreas Gruenbacher
2017-06-16 15:30 ` [Cluster-devel] " Darrick J. Wong
2017-06-16 15:30 ` Darrick J. Wong
2017-06-20 6:31 ` Christoph Hellwig [this message]
2017-06-20 6:31 ` [Cluster-devel] " Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170620063135.GA12636@infradead.org \
--to=hch@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.