From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 6/6] arm64: dts: marvell: enable GICP and ICU on Armada 7K/8K
Date: Tue, 20 Jun 2017 17:36:51 +0200 [thread overview]
Message-ID: <20170620173651.6370ea58@windsurf.lan> (raw)
In-Reply-To: <87tw3a3dy4.fsf@free-electrons.com>
Hello,
On Tue, 20 Jun 2017 16:56:35 +0200, Gregory CLEMENT wrote:
> > +#include <dt-bindings/interrupt-controller/mvebu-icu.h>
>
> With this line you created a dependency with the patch "irqchip:
> irq-mvebu-icu: new driver for Marvell ICU". And without it the dtb is
> not buidable.
>
> So either I wait for the next kernel release to apply it or I will need
> a stable branch with the commit adding the mvebu-icu.h file.
Alternatively, I could change the patch to use hardcoded values for now
(i.e replace ICU_GRP_NSR everywhere by 0x0), and then change it during
the next kernel cycle to use the #define value. I would really prefer
such a solution to a solution where merging the entire ICU DT change
would be delayed by one cycle.
Let me know what you prefer. Maybe Marc can say if the irqchip
maintainers can provide a stable branch containing the mvebu-icu.h file.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Petazzoni <thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Gregory CLEMENT
<gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Cc: "Thomas Gleixner" <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>,
"Jason Cooper" <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>,
"Marc Zyngier" <marc.zyngier-5wv7dgnIgG8@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"Rob Herring" <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"Ian Campbell"
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
"Pawel Moll" <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
"Mark Rutland" <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
"Kumar Gala" <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
"Andrew Lunn" <andrew-g2DYL2Zd6BY@public.gmane.org>,
"Sebastian Hesselbarth"
<sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
"Nadav Haklai" <nadavh-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
"Hanna Hawa" <hannah-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
"Yehuda Yitschak"
<yehuday-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
"Antoine Tenart"
<antoine.tenart-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
"Miquèl Raynal"
<miquel.raynal-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Subject: Re: [PATCH v4 6/6] arm64: dts: marvell: enable GICP and ICU on Armada 7K/8K
Date: Tue, 20 Jun 2017 17:36:51 +0200 [thread overview]
Message-ID: <20170620173651.6370ea58@windsurf.lan> (raw)
In-Reply-To: <87tw3a3dy4.fsf-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Hello,
On Tue, 20 Jun 2017 16:56:35 +0200, Gregory CLEMENT wrote:
> > +#include <dt-bindings/interrupt-controller/mvebu-icu.h>
>
> With this line you created a dependency with the patch "irqchip:
> irq-mvebu-icu: new driver for Marvell ICU". And without it the dtb is
> not buidable.
>
> So either I wait for the next kernel release to apply it or I will need
> a stable branch with the commit adding the mvebu-icu.h file.
Alternatively, I could change the patch to use hardcoded values for now
(i.e replace ICU_GRP_NSR everywhere by 0x0), and then change it during
the next kernel cycle to use the #define value. I would really prefer
such a solution to a solution where merging the entire ICU DT change
would be delayed by one cycle.
Let me know what you prefer. Maybe Marc can say if the irqchip
maintainers can provide a stable branch containing the mvebu-icu.h file.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Gregory CLEMENT <gregory.clement@free-electrons.com>
Cc: "Thomas Gleixner" <tglx@linutronix.de>,
"Jason Cooper" <jason@lakedaemon.net>,
"Marc Zyngier" <marc.zyngier@arm.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
"Rob Herring" <robh+dt@kernel.org>,
"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
"Pawel Moll" <pawel.moll@arm.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Kumar Gala" <galak@codeaurora.org>,
"Andrew Lunn" <andrew@lunn.ch>,
"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>,
linux-arm-kernel@lists.infradead.org,
"Nadav Haklai" <nadavh@marvell.com>,
"Hanna Hawa" <hannah@marvell.com>,
"Yehuda Yitschak" <yehuday@marvell.com>,
"Antoine Tenart" <antoine.tenart@free-electrons.com>,
"Miquèl Raynal" <miquel.raynal@free-electrons.com>
Subject: Re: [PATCH v4 6/6] arm64: dts: marvell: enable GICP and ICU on Armada 7K/8K
Date: Tue, 20 Jun 2017 17:36:51 +0200 [thread overview]
Message-ID: <20170620173651.6370ea58@windsurf.lan> (raw)
In-Reply-To: <87tw3a3dy4.fsf@free-electrons.com>
Hello,
On Tue, 20 Jun 2017 16:56:35 +0200, Gregory CLEMENT wrote:
> > +#include <dt-bindings/interrupt-controller/mvebu-icu.h>
>
> With this line you created a dependency with the patch "irqchip:
> irq-mvebu-icu: new driver for Marvell ICU". And without it the dtb is
> not buidable.
>
> So either I wait for the next kernel release to apply it or I will need
> a stable branch with the commit adding the mvebu-icu.h file.
Alternatively, I could change the patch to use hardcoded values for now
(i.e replace ICU_GRP_NSR everywhere by 0x0), and then change it during
the next kernel cycle to use the #define value. I would really prefer
such a solution to a solution where merging the entire ICU DT change
would be delayed by one cycle.
Let me know what you prefer. Maybe Marc can say if the irqchip
maintainers can provide a stable branch containing the mvebu-icu.h file.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-06-20 15:36 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-20 14:07 [PATCH v4 0/6] Add support for the ICU unit in Marvell Armada 7K/8K Thomas Petazzoni
2017-06-20 14:07 ` Thomas Petazzoni
2017-06-20 14:07 ` Thomas Petazzoni
2017-06-20 14:07 ` [PATCH v4 1/6] dt-bindings: interrupt-controller: add DT binding for the Marvell GICP Thomas Petazzoni
2017-06-20 14:07 ` Thomas Petazzoni
2017-06-20 14:07 ` [PATCH v4 2/6] dt-bindings: interrupt-controller: add DT binding for the Marvell ICU Thomas Petazzoni
2017-06-20 14:07 ` Thomas Petazzoni
2017-06-20 14:07 ` [PATCH v4 3/6] irqchip: irq-mvebu-gicp: new driver for Marvell GICP Thomas Petazzoni
2017-06-20 14:07 ` Thomas Petazzoni
2017-06-20 14:07 ` Thomas Petazzoni
2017-06-20 14:07 ` [PATCH v4 4/6] irqchip: irq-mvebu-icu: new driver for Marvell ICU Thomas Petazzoni
2017-06-20 14:07 ` Thomas Petazzoni
2017-06-21 7:56 ` Marc Zyngier
2017-06-21 7:56 ` Marc Zyngier
2017-06-21 7:56 ` Marc Zyngier
2017-06-21 13:30 ` Thomas Petazzoni
2017-06-21 13:30 ` Thomas Petazzoni
2017-06-20 14:07 ` [PATCH v4 5/6] arm64: marvell: enable ICU and GICP drivers Thomas Petazzoni
2017-06-20 14:07 ` Thomas Petazzoni
2017-06-20 14:07 ` Thomas Petazzoni
2017-06-21 7:57 ` Marc Zyngier
2017-06-21 7:57 ` Marc Zyngier
2017-06-21 7:57 ` Marc Zyngier
2017-06-20 14:07 ` [PATCH v4 6/6] arm64: dts: marvell: enable GICP and ICU on Armada 7K/8K Thomas Petazzoni
2017-06-20 14:07 ` Thomas Petazzoni
2017-06-20 14:07 ` Thomas Petazzoni
2017-06-20 14:56 ` Gregory CLEMENT
2017-06-20 14:56 ` Gregory CLEMENT
2017-06-20 14:56 ` Gregory CLEMENT
2017-06-20 15:36 ` Thomas Petazzoni [this message]
2017-06-20 15:36 ` Thomas Petazzoni
2017-06-20 15:36 ` Thomas Petazzoni
2017-06-20 15:42 ` Gregory CLEMENT
2017-06-20 15:42 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170620173651.6370ea58@windsurf.lan \
--to=thomas.petazzoni@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.