From: Gustavo A. R. Silva <garsilva@embeddedor.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH] net: intel: e1000e: add check on e1e_wphy() return value
Date: Tue, 20 Jun 2017 16:22:34 -0500 [thread overview]
Message-ID: <20170620212234.GA10957@embeddedgus> (raw)
In-Reply-To: <20170518172223.Horde.5kLLwxMJWThQKv0bAxTsk4D@gator4166.hostgator.com>
Check return value from call to e1e_wphy(). This value is being
checked during previous calls to function e1e_wphy() and it seems
a check was missing here.
Addresses-Coverity-ID: 1226905
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
drivers/net/ethernet/intel/e1000e/ich8lan.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/intel/e1000e/ich8lan.c b/drivers/net/ethernet/intel/e1000e/ich8lan.c
index 68ea8b4..d6d4ed7 100644
--- a/drivers/net/ethernet/intel/e1000e/ich8lan.c
+++ b/drivers/net/ethernet/intel/e1000e/ich8lan.c
@@ -2437,6 +2437,8 @@ static s32 e1000_hv_phy_workarounds_ich8lan(struct e1000_hw *hw)
if (hw->phy.revision < 2) {
e1000e_phy_sw_reset(hw);
ret_val = e1e_wphy(hw, MII_BMCR, 0x3140);
+ if (ret_val)
+ return ret_val;
}
}
--
2.5.0
WARNING: multiple messages have this Message-ID (diff)
From: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Gustavo A. R. Silva" <garsilva@embeddedor.com>
Subject: [PATCH] net: intel: e1000e: add check on e1e_wphy() return value
Date: Tue, 20 Jun 2017 16:22:34 -0500 [thread overview]
Message-ID: <20170620212234.GA10957@embeddedgus> (raw)
In-Reply-To: <20170518172223.Horde.5kLLwxMJWThQKv0bAxTsk4D@gator4166.hostgator.com>
Check return value from call to e1e_wphy(). This value is being
checked during previous calls to function e1e_wphy() and it seems
a check was missing here.
Addresses-Coverity-ID: 1226905
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
drivers/net/ethernet/intel/e1000e/ich8lan.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/intel/e1000e/ich8lan.c b/drivers/net/ethernet/intel/e1000e/ich8lan.c
index 68ea8b4..d6d4ed7 100644
--- a/drivers/net/ethernet/intel/e1000e/ich8lan.c
+++ b/drivers/net/ethernet/intel/e1000e/ich8lan.c
@@ -2437,6 +2437,8 @@ static s32 e1000_hv_phy_workarounds_ich8lan(struct e1000_hw *hw)
if (hw->phy.revision < 2) {
e1000e_phy_sw_reset(hw);
ret_val = e1e_wphy(hw, MII_BMCR, 0x3140);
+ if (ret_val)
+ return ret_val;
}
}
--
2.5.0
next prev parent reply other threads:[~2017-06-20 21:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-18 22:22 [Intel-wired-lan] [net-intel-e1000e] question about value overwrite Gustavo A. R. Silva
2017-05-18 22:22 ` Gustavo A. R. Silva
2017-06-20 21:22 ` Gustavo A. R. Silva [this message]
2017-06-20 21:22 ` [PATCH] net: intel: e1000e: add check on e1e_wphy() return value Gustavo A. R. Silva
2017-06-21 2:44 ` [Intel-wired-lan] " Ethan Zhao
2017-06-21 2:44 ` Ethan Zhao
2017-06-21 19:52 ` [Intel-wired-lan] " Gustavo A. R. Silva
2017-06-21 19:52 ` Gustavo A. R. Silva
2017-06-21 19:52 ` Gustavo A. R. Silva
2017-06-22 6:54 ` [Intel-wired-lan] " Neftin, Sasha
2017-06-22 6:54 ` Neftin, Sasha
2017-06-27 1:21 ` Brown, Aaron F
2017-06-27 1:21 ` Brown, Aaron F
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170620212234.GA10957@embeddedgus \
--to=garsilva@embeddedor.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.