* [PATCH] mini-os: use gzip -n @ 2017-06-22 13:40 Bernhard M. Wiedemann 2017-06-22 14:09 ` Wei Liu 0 siblings, 1 reply; 6+ messages in thread From: Bernhard M. Wiedemann @ 2017-06-22 13:40 UTC (permalink / raw) To: xen-devel; +Cc: Bernhard M. Wiedemann, keir.fraser, kaf24 to not add current timestamp to ioemu-stubdom.gz pv-grub-x86_32.gz pv-grub-x86_64.gz xenstore-stubdom.gz to allow for reproducible builds Signed-off-by: Bernhard M. Wiedemann <bwiedemann@suse.de> --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index ef8559b..5bdcdac 100644 --- a/Makefile +++ b/Makefile @@ -165,7 +165,7 @@ $(OBJ_DIR)/$(TARGET): $(OBJS) $(APP_O) arch_lib $(OBJ_DIR)/$(TARGET_ARCH_DIR)/mi $(LD) -r $(LDFLAGS) $(HEAD_OBJ) $(APP_O) $(OBJS) $(LDARCHLIB) $(LDLIBS) -o $@.o $(OBJCOPY) -w -G $(GLOBAL_PREFIX)* -G _start $@.o $@.o $(LD) $(LDFLAGS) $(LDFLAGS_FINAL) $@.o $(EXTRA_OBJS) -o $@ - gzip -f -9 -c $@ >$@.gz + gzip -n -f -9 -c $@ >$@.gz .PHONY: config CONFIG_FILE ?= $(CURDIR)/minios-config.mk -- 2.12.3 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] mini-os: use gzip -n 2017-06-22 13:40 [PATCH] mini-os: use gzip -n Bernhard M. Wiedemann @ 2017-06-22 14:09 ` Wei Liu 2017-06-22 14:55 ` Andrew Cooper 0 siblings, 1 reply; 6+ messages in thread From: Wei Liu @ 2017-06-22 14:09 UTC (permalink / raw) To: Bernhard M. Wiedemann Cc: Wei Liu, Minios-devel, kaf24, Samuel Thibault, xen-devel, keir.fraser Cc minios-devel and Samuel On Thu, Jun 22, 2017 at 03:40:26PM +0200, Bernhard M. Wiedemann wrote: > to not add current timestamp to > ioemu-stubdom.gz > pv-grub-x86_32.gz > pv-grub-x86_64.gz > xenstore-stubdom.gz > > to allow for reproducible builds > > Signed-off-by: Bernhard M. Wiedemann <bwiedemann@suse.de> Acked-by: Wei Liu <wei.liu2@citrix.com> > --- > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index ef8559b..5bdcdac 100644 > --- a/Makefile > +++ b/Makefile > @@ -165,7 +165,7 @@ $(OBJ_DIR)/$(TARGET): $(OBJS) $(APP_O) arch_lib $(OBJ_DIR)/$(TARGET_ARCH_DIR)/mi > $(LD) -r $(LDFLAGS) $(HEAD_OBJ) $(APP_O) $(OBJS) $(LDARCHLIB) $(LDLIBS) -o $@.o > $(OBJCOPY) -w -G $(GLOBAL_PREFIX)* -G _start $@.o $@.o > $(LD) $(LDFLAGS) $(LDFLAGS_FINAL) $@.o $(EXTRA_OBJS) -o $@ > - gzip -f -9 -c $@ >$@.gz > + gzip -n -f -9 -c $@ >$@.gz > > .PHONY: config > CONFIG_FILE ?= $(CURDIR)/minios-config.mk > -- > 2.12.3 > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > https://lists.xen.org/xen-devel _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mini-os: use gzip -n 2017-06-22 14:09 ` Wei Liu @ 2017-06-22 14:55 ` Andrew Cooper 2017-06-22 15:45 ` Wei Liu 2017-06-23 9:09 ` Bernhard M. Wiedemann 0 siblings, 2 replies; 6+ messages in thread From: Andrew Cooper @ 2017-06-22 14:55 UTC (permalink / raw) To: Wei Liu, Bernhard M. Wiedemann Cc: Minios-devel, Samuel Thibault, keir.fraser, kaf24, xen-devel On 22/06/17 15:09, Wei Liu wrote: > Cc minios-devel and Samuel > > On Thu, Jun 22, 2017 at 03:40:26PM +0200, Bernhard M. Wiedemann wrote: >> to not add current timestamp to >> ioemu-stubdom.gz >> pv-grub-x86_32.gz >> pv-grub-x86_64.gz >> xenstore-stubdom.gz >> >> to allow for reproducible builds >> >> Signed-off-by: Bernhard M. Wiedemann <bwiedemann@suse.de> > Acked-by: Wei Liu <wei.liu2@citrix.com> Would it make sense to have a $(GZIP) in the same as we abstract out other programs, and export GZIP = gzip -n ? ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mini-os: use gzip -n 2017-06-22 14:55 ` Andrew Cooper @ 2017-06-22 15:45 ` Wei Liu 2017-06-23 9:09 ` Bernhard M. Wiedemann 1 sibling, 0 replies; 6+ messages in thread From: Wei Liu @ 2017-06-22 15:45 UTC (permalink / raw) To: Andrew Cooper Cc: Bernhard M. Wiedemann, Wei Liu, Minios-devel, kaf24, Samuel Thibault, xen-devel, keir.fraser On Thu, Jun 22, 2017 at 03:55:21PM +0100, Andrew Cooper wrote: > On 22/06/17 15:09, Wei Liu wrote: > > Cc minios-devel and Samuel > > > > On Thu, Jun 22, 2017 at 03:40:26PM +0200, Bernhard M. Wiedemann wrote: > >> to not add current timestamp to > >> ioemu-stubdom.gz > >> pv-grub-x86_32.gz > >> pv-grub-x86_64.gz > >> xenstore-stubdom.gz > >> > >> to allow for reproducible builds > >> > >> Signed-off-by: Bernhard M. Wiedemann <bwiedemann@suse.de> > > Acked-by: Wei Liu <wei.liu2@citrix.com> > > Would it make sense to have a $(GZIP) in the same as we abstract out > other programs, and export GZIP = gzip -n ? Sure, that would be a nice thing to have. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mini-os: use gzip -n 2017-06-22 14:55 ` Andrew Cooper 2017-06-22 15:45 ` Wei Liu @ 2017-06-23 9:09 ` Bernhard M. Wiedemann 2017-06-23 9:23 ` Wei Liu 1 sibling, 1 reply; 6+ messages in thread From: Bernhard M. Wiedemann @ 2017-06-23 9:09 UTC (permalink / raw) To: Andrew Cooper Cc: Bernhard M. Wiedemann, Wei Liu, Minios-devel, Samuel Thibault, xen-devel, keir.fraser On Thu, Jun 22, 2017 at 03:55:21PM +0100, Andrew Cooper wrote: > On 22/06/17 15:09, Wei Liu wrote: > > On Thu, Jun 22, 2017 at 03:40:26PM +0200, Bernhard M. Wiedemann wrote: > >> to not add current timestamp to > >> ioemu-stubdom.gz > >> pv-grub-x86_32.gz > >> pv-grub-x86_64.gz > >> xenstore-stubdom.gz > >> > >> to allow for reproducible builds > >> > >> Signed-off-by: Bernhard M. Wiedemann <bwiedemann@suse.de> > > Acked-by: Wei Liu <wei.liu2@citrix.com> > > Would it make sense to have a $(GZIP) in the same as we abstract out > other programs, and export GZIP = gzip -n ? IMHO that would only make sense, if anyone wanted to have it called without -n which I dont see why. Or if there would be multiple invocations, to have a Single Point of Truth but there is only this 1 gzip here (if we dont count the ones in main xen code). -- Bernhard M. Wiedemann Cloud Software Developer and Sysadmin SUSE LINUX GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg) Maxfeldstraße 5 90409 Nürnberg Germany _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mini-os: use gzip -n 2017-06-23 9:09 ` Bernhard M. Wiedemann @ 2017-06-23 9:23 ` Wei Liu 0 siblings, 0 replies; 6+ messages in thread From: Wei Liu @ 2017-06-23 9:23 UTC (permalink / raw) To: Bernhard M. Wiedemann Cc: Bernhard M. Wiedemann, Wei Liu, Andrew Cooper, Minios-devel, Samuel Thibault, xen-devel, keir.fraser On Fri, Jun 23, 2017 at 11:09:21AM +0200, Bernhard M. Wiedemann wrote: > On Thu, Jun 22, 2017 at 03:55:21PM +0100, Andrew Cooper wrote: > > On 22/06/17 15:09, Wei Liu wrote: > > > On Thu, Jun 22, 2017 at 03:40:26PM +0200, Bernhard M. Wiedemann wrote: > > >> to not add current timestamp to > > >> ioemu-stubdom.gz > > >> pv-grub-x86_32.gz > > >> pv-grub-x86_64.gz > > >> xenstore-stubdom.gz > > >> > > >> to allow for reproducible builds > > >> > > >> Signed-off-by: Bernhard M. Wiedemann <bwiedemann@suse.de> > > > Acked-by: Wei Liu <wei.liu2@citrix.com> > > > > Would it make sense to have a $(GZIP) in the same as we abstract out > > other programs, and export GZIP = gzip -n ? > > IMHO that would only make sense, if anyone wanted to have it called without -n > which I dont see why. > Or if there would be multiple invocations, to have a Single Point of Truth > but there is only this 1 gzip here > (if we dont count the ones in main xen code). > FADO I'm going to apply your patch at some point. The GZIP thing can be dealt with later if anyone wishes to. > -- > Bernhard M. Wiedemann > Cloud Software Developer and Sysadmin > SUSE LINUX GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg) > Maxfeldstraße 5 > 90409 Nürnberg > Germany > _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-06-23 9:23 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-06-22 13:40 [PATCH] mini-os: use gzip -n Bernhard M. Wiedemann 2017-06-22 14:09 ` Wei Liu 2017-06-22 14:55 ` Andrew Cooper 2017-06-22 15:45 ` Wei Liu 2017-06-23 9:09 ` Bernhard M. Wiedemann 2017-06-23 9:23 ` Wei Liu
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.