All of lore.kernel.org
 help / color / mirror / Atom feed
From: Will Deacon <will.deacon at arm.com>
To: devel@acpica.org
Subject: Re: [Devel] [PATCH v9 0/3] Cavium ThunderX2 SMMUv3 errata workarounds
Date: Thu, 22 Jun 2017 19:58:22 +0100	[thread overview]
Message-ID: <20170622185822.GK15336@arm.com> (raw)
In-Reply-To: 20170622182257.GI15336@arm.com

[-- Attachment #1: Type: text/plain, Size: 1158 bytes --]

On Thu, Jun 22, 2017 at 07:22:57PM +0100, Will Deacon wrote:
> On Thu, Jun 22, 2017 at 05:35:35PM +0530, Geetha sowjanya wrote:
> > Cavium ThunderX2 SMMUv3 implementation has two Silicon Erratas.
> > 1. Errata ID #74
> >    SMMU register alias Page 1 is not implemented
> > 2. Errata ID #126
> >    SMMU doesnt support unique IRQ lines and also MSI for gerror,
> >    eventq and cmdq-sync
> > 
> > The following patchset does software workaround for these two erratas.
> 
> I've picked up the first two patches, and left comments on the final patch.

... except that it doesn't build:


drivers/acpi/arm64/iort.c: In function ‘arm_smmu_v3_resource_size’:
drivers/acpi/arm64/iort.c:837:21: error: ‘ACPI_IORT_SMMU_V3_CAVIUM_CN99XX’ undeclared (first use in this function)
  if (smmu->model == ACPI_IORT_SMMU_V3_CAVIUM_CN99XX)
                     ^
drivers/acpi/arm64/iort.c:837:21: note: each undeclared identifier is reported only once for each function it appears in
make[4]: *** [drivers/acpi/arm64/iort.o] Error 1


I don't see ACPI_IORT_SMMU_V3_CAVIUM_CN99XX defined, even in linux-next.

What's the plan here?

Will

WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Geetha sowjanya <gakula@caviumnetworks.com>
Cc: robin.murphy@arm.com, lorenzo.pieralisi@arm.com,
	hanjun.guo@linaro.org, sudeep.holla@arm.com,
	iommu@lists.linux-foundation.org, robert.moore@intel.com,
	lv.zheng@intel.com, rjw@rjwysocki.net, jcm@redhat.com,
	linux-kernel@vger.kernel.org, robert.richter@cavium.com,
	catalin.marinas@arm.com, sgoutham@cavium.com,
	linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org,
	geethasowjanya.akula@gmail.com, devel@acpica.org,
	linu.cherian@cavium.com, Charles.Garcia-Tobin@arm.com,
	robh@kernel.org
Subject: Re: [PATCH v9 0/3] Cavium ThunderX2 SMMUv3 errata workarounds
Date: Thu, 22 Jun 2017 19:58:22 +0100	[thread overview]
Message-ID: <20170622185822.GK15336@arm.com> (raw)
In-Reply-To: <20170622182257.GI15336@arm.com>

On Thu, Jun 22, 2017 at 07:22:57PM +0100, Will Deacon wrote:
> On Thu, Jun 22, 2017 at 05:35:35PM +0530, Geetha sowjanya wrote:
> > Cavium ThunderX2 SMMUv3 implementation has two Silicon Erratas.
> > 1. Errata ID #74
> >    SMMU register alias Page 1 is not implemented
> > 2. Errata ID #126
> >    SMMU doesnt support unique IRQ lines and also MSI for gerror,
> >    eventq and cmdq-sync
> > 
> > The following patchset does software workaround for these two erratas.
> 
> I've picked up the first two patches, and left comments on the final patch.

... except that it doesn't build:


drivers/acpi/arm64/iort.c: In function ‘arm_smmu_v3_resource_size’:
drivers/acpi/arm64/iort.c:837:21: error: ‘ACPI_IORT_SMMU_V3_CAVIUM_CN99XX’ undeclared (first use in this function)
  if (smmu->model == ACPI_IORT_SMMU_V3_CAVIUM_CN99XX)
                     ^
drivers/acpi/arm64/iort.c:837:21: note: each undeclared identifier is reported only once for each function it appears in
make[4]: *** [drivers/acpi/arm64/iort.o] Error 1


I don't see ACPI_IORT_SMMU_V3_CAVIUM_CN99XX defined, even in linux-next.

What's the plan here?

Will

WARNING: multiple messages have this Message-ID (diff)
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v9 0/3] Cavium ThunderX2 SMMUv3 errata workarounds
Date: Thu, 22 Jun 2017 19:58:22 +0100	[thread overview]
Message-ID: <20170622185822.GK15336@arm.com> (raw)
In-Reply-To: <20170622182257.GI15336@arm.com>

On Thu, Jun 22, 2017 at 07:22:57PM +0100, Will Deacon wrote:
> On Thu, Jun 22, 2017 at 05:35:35PM +0530, Geetha sowjanya wrote:
> > Cavium ThunderX2 SMMUv3 implementation has two Silicon Erratas.
> > 1. Errata ID #74
> >    SMMU register alias Page 1 is not implemented
> > 2. Errata ID #126
> >    SMMU doesnt support unique IRQ lines and also MSI for gerror,
> >    eventq and cmdq-sync
> > 
> > The following patchset does software workaround for these two erratas.
> 
> I've picked up the first two patches, and left comments on the final patch.

... except that it doesn't build:


drivers/acpi/arm64/iort.c: In function ?arm_smmu_v3_resource_size?:
drivers/acpi/arm64/iort.c:837:21: error: ?ACPI_IORT_SMMU_V3_CAVIUM_CN99XX? undeclared (first use in this function)
  if (smmu->model == ACPI_IORT_SMMU_V3_CAVIUM_CN99XX)
                     ^
drivers/acpi/arm64/iort.c:837:21: note: each undeclared identifier is reported only once for each function it appears in
make[4]: *** [drivers/acpi/arm64/iort.o] Error 1


I don't see ACPI_IORT_SMMU_V3_CAVIUM_CN99XX defined, even in linux-next.

What's the plan here?

Will

             reply	other threads:[~2017-06-22 18:58 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-22 18:58 Will Deacon [this message]
2017-06-22 18:58 ` [PATCH v9 0/3] Cavium ThunderX2 SMMUv3 errata workarounds Will Deacon
2017-06-22 18:58 ` Will Deacon
  -- strict thread matches above, loose matches on Subject: below --
2017-06-23 10:11 [Devel] [PATCH] iommu/arm-smmu-v3, acpi: Add temporary Cavium SMMU-V3 IORT model number definitions Lorenzo Pieralisi
2017-06-23 10:11 ` Lorenzo Pieralisi
2017-06-23 10:11 ` Lorenzo Pieralisi
2017-06-23  8:43 [Devel] [PATCH v9 0/3] Cavium ThunderX2 SMMUv3 errata workarounds Lorenzo Pieralisi
2017-06-23  8:43 ` Lorenzo Pieralisi
2017-06-23  8:43 ` Lorenzo Pieralisi
2017-06-23  6:21 [Devel] [PATCH v9 3/3] iommu/arm-smmu-v3: Add workaround for Cavium ThunderX2 erratum #126 Geetha Akula
2017-06-23  6:21 ` Geetha Akula
2017-06-23  6:21 ` Geetha Akula
2017-06-23  6:21 ` Geetha Akula
2017-06-23  4:59 [Devel] [PATCH] iommu/arm-smmu-v3, acpi: Add temporary Cavium SMMU-V3 IORT model number definitions Robert Richter
2017-06-23  4:59 ` Robert Richter
2017-06-23  4:59 ` Robert Richter
2017-06-23  4:55 [Devel] [PATCH v9 0/3] Cavium ThunderX2 SMMUv3 errata workarounds Robert Richter
2017-06-23  4:55 ` Robert Richter
2017-06-23  4:55 ` Robert Richter
2017-06-23  4:55 ` Robert Richter
2017-06-22 21:04 Lorenzo Pieralisi
2017-06-22 21:04 ` Lorenzo Pieralisi
2017-06-22 21:04 ` Lorenzo Pieralisi
2017-06-22 19:35 Robert Richter
2017-06-22 19:35 ` Robert Richter
2017-06-22 19:35 ` Robert Richter
2017-06-22 18:22 Will Deacon
2017-06-22 18:22 ` Will Deacon
2017-06-22 18:22 ` Will Deacon
2017-06-22 18:22 ` Will Deacon
2017-06-22 18:22 [Devel] [PATCH v9 3/3] iommu/arm-smmu-v3: Add workaround for Cavium ThunderX2 erratum #126 Will Deacon
2017-06-22 18:22 ` Will Deacon
2017-06-22 18:22 ` Will Deacon
2017-06-22 12:05 [Devel] " Geetha sowjanya
2017-06-22 12:05 ` Geetha sowjanya
2017-06-22 12:05 ` Geetha sowjanya
2017-06-22 12:05 ` Geetha sowjanya
2017-06-22 12:05 [Devel] [PATCH v9 2/3] iommu/arm-smmu-v3: Add workaround for Cavium ThunderX2 erratum #74 Geetha sowjanya
2017-06-22 12:05 ` Geetha sowjanya
2017-06-22 12:05 ` Geetha sowjanya
2017-06-22 12:05 [Devel] [PATCH v9 1/3] ACPI/IORT: Fixup SMMUv3 resource size for Cavium ThunderX2 SMMUv3 model Geetha sowjanya
2017-06-22 12:05 ` Geetha sowjanya
2017-06-22 12:05 ` Geetha sowjanya
2017-06-22 12:05 ` Geetha sowjanya
2017-06-22 12:05 [Devel] [PATCH v9 0/3] Cavium ThunderX2 SMMUv3 errata workarounds Geetha sowjanya
2017-06-22 12:05 ` Geetha sowjanya
2017-06-22 12:05 ` Geetha sowjanya
2017-06-22 12:05 ` Geetha sowjanya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170622185822.GK15336@arm.com \
    --to=devel@acpica.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.