From: Stephen Boyd <sboyd@codeaurora.org>
To: Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Kukjin Kim <kgene@kernel.org>,
Tomasz Figa <tomasz.figa@gmail.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-clk@vger.kernel.org,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH 1/2] clk: samsung: audss: Fix silent hang on Exynos4412 due to disabled EPLL
Date: Thu, 22 Jun 2017 14:55:49 -0700 [thread overview]
Message-ID: <20170622215549.GM4493@codeaurora.org> (raw)
In-Reply-To: <99de23b6-4049-7542-008b-abf65df356f0@samsung.com>
On 06/22, Sylwester Nawrocki wrote:
> On 06/21/2017 09:08 PM, Krzysztof Kozlowski wrote:
> >Similarly to commit f1e9203e2366 ("clk: samsung: Fix Exynos 5420 pinctrl
> >setup and clock disable failure due to domain being gated") for
> >Exynos5420, the Exynos4412 also requires that EPLL is not disabled.
> >Otherwise any access to MAUDIO block will silently halt.
> >
> >This was not visible before because EPLL on Exynos4 could not be
> >disabled before commit 6edfa11cb396 ("clk: samsung:
> >Add enable/disable operation for PLL36XX clocks"). After this commit,
> >on Odroid U3 board one can see silent hang, usually with last (but
> >unrelated) messages:
> >
> > [ 2.382741] input: gpio_keys as /devices/platform/gpio_keys/input/input0
> > [ 2.405686] usb 1-3: new high-speed USB device number 3 using exynos-ehci
> > [ 2.419843] max77686-rtc max77686-rtc: setting system clock to 2017-06-21 17:04:13 UTC (1498064653)
> >
> >Mark Exynos4 variant as also needed EPLL to be enabled all the time.
> >
> >Signed-off-by: Krzysztof Kozlowski<krzk@kernel.org>
> Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
>
> Stephen, Mike,
>
> Can you please apply this patch directly?
>
Applied to clk-next.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] clk: samsung: audss: Fix silent hang on Exynos4412 due to disabled EPLL
Date: Thu, 22 Jun 2017 14:55:49 -0700 [thread overview]
Message-ID: <20170622215549.GM4493@codeaurora.org> (raw)
In-Reply-To: <99de23b6-4049-7542-008b-abf65df356f0@samsung.com>
On 06/22, Sylwester Nawrocki wrote:
> On 06/21/2017 09:08 PM, Krzysztof Kozlowski wrote:
> >Similarly to commit f1e9203e2366 ("clk: samsung: Fix Exynos 5420 pinctrl
> >setup and clock disable failure due to domain being gated") for
> >Exynos5420, the Exynos4412 also requires that EPLL is not disabled.
> >Otherwise any access to MAUDIO block will silently halt.
> >
> >This was not visible before because EPLL on Exynos4 could not be
> >disabled before commit 6edfa11cb396 ("clk: samsung:
> >Add enable/disable operation for PLL36XX clocks"). After this commit,
> >on Odroid U3 board one can see silent hang, usually with last (but
> >unrelated) messages:
> >
> > [ 2.382741] input: gpio_keys as /devices/platform/gpio_keys/input/input0
> > [ 2.405686] usb 1-3: new high-speed USB device number 3 using exynos-ehci
> > [ 2.419843] max77686-rtc max77686-rtc: setting system clock to 2017-06-21 17:04:13 UTC (1498064653)
> >
> >Mark Exynos4 variant as also needed EPLL to be enabled all the time.
> >
> >Signed-off-by: Krzysztof Kozlowski<krzk@kernel.org>
> Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
>
> Stephen, Mike,
>
> Can you please apply this patch directly?
>
Applied to clk-next.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2017-06-22 21:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-21 19:08 [PATCH 0/2] clk: ARM: dts: exynos: Fix hang on Odroid U3 Krzysztof Kozlowski
2017-06-21 19:08 ` Krzysztof Kozlowski
2017-06-21 19:08 ` [PATCH 1/2] clk: samsung: audss: Fix silent hang on Exynos4412 due to disabled EPLL Krzysztof Kozlowski
2017-06-21 19:08 ` Krzysztof Kozlowski
2017-06-22 10:27 ` Sylwester Nawrocki
2017-06-22 10:27 ` Sylwester Nawrocki
2017-06-22 21:55 ` Stephen Boyd [this message]
2017-06-22 21:55 ` Stephen Boyd
2017-06-21 19:08 ` [PATCH 2/2] ARM: dts: exynos: Add clocks to audss block to fix silent hang on Exynos4412 Krzysztof Kozlowski
2017-06-21 19:08 ` Krzysztof Kozlowski
2017-06-21 19:08 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170622215549.GM4493@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=cw00.choi@samsung.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mturquette@baylibre.com \
--cc=s.nawrocki@samsung.com \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.