All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Dmitry Vyukov <dvyukov@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>, Will Deacon <will.deacon@arm.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Andrey Ryabinin <aryabinin@virtuozzo.com>,
	kasan-dev <kasan-dev@googlegroups.com>,
	"x86@kernel.org" <x86@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [PATCH v5 1/4] x86: switch atomic.h to use atomic-instrumented.h
Date: Fri, 23 Jun 2017 10:54:02 +0200	[thread overview]
Message-ID: <20170623085402.kfzu6sri6bwi2ppo@gmail.com> (raw)
In-Reply-To: <CACT4Y+YQchHWK+8jEo03dK21xM77pn0YePkjUTVny0-Cx8yYeg@mail.gmail.com>


* Dmitry Vyukov <dvyukov@google.com> wrote:

> On Thu, Jun 22, 2017 at 11:14 PM, Andrew Morton
> <akpm@linux-foundation.org> wrote:
> > On Thu, 22 Jun 2017 16:14:16 +0200 Dmitry Vyukov <dvyukov@google.com> wrote:
> >
> >> Add arch_ prefix to all atomic operations and include
> >> <asm-generic/atomic-instrumented.h>. This will allow
> >> to add KASAN instrumentation to all atomic ops.
> >
> > This gets a large number of (simple) rejects when applied to
> > linux-next.  Can you please redo against -next?
> 
> 
> This is based on tip/locking tree. Ingo already took a part of these
> series. The plan is that he takes the rest, and this applies on
> tip/locking without conflicts.

Yeah, so I've taken the rest as well, it all looks very clean now. Should show up 
in the next -next, if it passes my (arguably limited) testing.

Andrew, is this workflow fine with you? You usually take KASAN patches, but I was 
unhappy with the atomics instrumention of the earlier patches, and ended up 
reviewing the followup variants, and felt that if I hinder a patchset I might as 
well test and apply it once I'm happy with them! ;-)

Should be a special exception for this series only.

Thanks,

	Ingo

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@kernel.org>
To: Dmitry Vyukov <dvyukov@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>, Will Deacon <will.deacon@arm.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Andrey Ryabinin <aryabinin@virtuozzo.com>,
	kasan-dev <kasan-dev@googlegroups.com>,
	"x86@kernel.org" <x86@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [PATCH v5 1/4] x86: switch atomic.h to use atomic-instrumented.h
Date: Fri, 23 Jun 2017 10:54:02 +0200	[thread overview]
Message-ID: <20170623085402.kfzu6sri6bwi2ppo@gmail.com> (raw)
In-Reply-To: <CACT4Y+YQchHWK+8jEo03dK21xM77pn0YePkjUTVny0-Cx8yYeg@mail.gmail.com>


* Dmitry Vyukov <dvyukov@google.com> wrote:

> On Thu, Jun 22, 2017 at 11:14 PM, Andrew Morton
> <akpm@linux-foundation.org> wrote:
> > On Thu, 22 Jun 2017 16:14:16 +0200 Dmitry Vyukov <dvyukov@google.com> wrote:
> >
> >> Add arch_ prefix to all atomic operations and include
> >> <asm-generic/atomic-instrumented.h>. This will allow
> >> to add KASAN instrumentation to all atomic ops.
> >
> > This gets a large number of (simple) rejects when applied to
> > linux-next.  Can you please redo against -next?
> 
> 
> This is based on tip/locking tree. Ingo already took a part of these
> series. The plan is that he takes the rest, and this applies on
> tip/locking without conflicts.

Yeah, so I've taken the rest as well, it all looks very clean now. Should show up 
in the next -next, if it passes my (arguably limited) testing.

Andrew, is this workflow fine with you? You usually take KASAN patches, but I was 
unhappy with the atomics instrumention of the earlier patches, and ended up 
reviewing the followup variants, and felt that if I hinder a patchset I might as 
well test and apply it once I'm happy with them! ;-)

Should be a special exception for this series only.

Thanks,

	Ingo

  reply	other threads:[~2017-06-23  8:54 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-22 14:14 [PATCH v5 0/4] x86, kasan: add KASAN checks to atomic operations Dmitry Vyukov
     [not found] ` <cover.1498140838.git.dvyukov@google.com>
2017-06-22 14:14   ` [PATCH v5 1/4] x86: switch atomic.h to use atomic-instrumented.h Dmitry Vyukov
2017-06-22 14:14     ` Dmitry Vyukov
2017-06-22 21:14     ` Andrew Morton
2017-06-22 21:14       ` Andrew Morton
2017-06-23  8:23       ` Dmitry Vyukov
2017-06-23  8:23         ` Dmitry Vyukov
2017-06-23  8:54         ` Ingo Molnar [this message]
2017-06-23  8:54           ` Ingo Molnar
2017-06-23 19:00           ` Andrew Morton
2017-06-23 19:00             ` Andrew Morton
2017-06-23 13:59     ` [tip:locking/core] locking/atomic/x86: Switch " tip-bot for Dmitry Vyukov
2017-06-22 14:14   ` [PATCH v5 2/4] kasan: allow kasan_check_read/write() to accept pointers to volatiles Dmitry Vyukov
2017-06-22 14:14     ` Dmitry Vyukov
2017-06-23 14:00     ` [tip:locking/core] kasan: Allow " tip-bot for Dmitry Vyukov
2017-07-26 12:10     ` tip-bot for Dmitry Vyukov
2017-06-22 14:14   ` [PATCH v5 3/4] asm-generic: add KASAN instrumentation to atomic operations Dmitry Vyukov
2017-06-22 14:14     ` Dmitry Vyukov
2017-06-23 14:01     ` [tip:locking/core] locking/atomics, asm-generic: Add " tip-bot for Dmitry Vyukov
2017-06-28 10:02     ` [PATCH] locking/atomics: don't alias ____ptr Sebastian Andrzej Siewior
2017-06-28 10:02       ` Sebastian Andrzej Siewior
2017-06-28 10:16       ` Dmitry Vyukov
2017-06-28 10:16         ` Dmitry Vyukov
2017-06-28 11:10         ` Thomas Gleixner
2017-06-28 11:10           ` Thomas Gleixner
2017-06-28 11:12           ` Dmitry Vyukov
2017-06-28 11:12             ` Dmitry Vyukov
2017-06-28 11:21             ` Thomas Gleixner
2017-06-28 11:21               ` Thomas Gleixner
2017-06-28 12:45               ` Mark Rutland
2017-06-28 12:45                 ` Mark Rutland
2017-06-28 12:24             ` Thomas Gleixner
2017-06-28 12:24               ` Thomas Gleixner
2017-06-28 12:27               ` Dmitry Vyukov
2017-06-28 12:27                 ` Dmitry Vyukov
2017-06-28 13:33                 ` Thomas Gleixner
2017-06-28 13:33                   ` Thomas Gleixner
2017-06-28 11:15         ` Andrey Ryabinin
2017-06-28 11:15           ` Andrey Ryabinin
2017-06-28 12:12           ` Sebastian Andrzej Siewior
2017-06-28 12:12             ` Sebastian Andrzej Siewior
2017-06-28 13:20             ` Thomas Gleixner
2017-06-28 13:20               ` Thomas Gleixner
2017-06-28 13:54               ` Thomas Gleixner
2017-06-28 13:54                 ` Thomas Gleixner
2017-06-28 14:14                 ` Mark Rutland
2017-06-28 14:14                   ` Mark Rutland
2017-06-28 15:24                   ` Thomas Gleixner
2017-06-28 15:24                     ` Thomas Gleixner
2017-06-28 15:54                     ` Mark Rutland
2017-06-28 15:54                       ` Mark Rutland
2017-06-28 16:56                       ` Ingo Molnar
2017-06-28 16:56                         ` Ingo Molnar
2017-06-28 18:21                       ` Thomas Gleixner
2017-06-28 18:21                         ` Thomas Gleixner
2017-06-29  6:47                         ` Thomas Gleixner
2017-06-29  6:47                           ` Thomas Gleixner
2017-06-28 14:00               ` Andrey Ryabinin
2017-06-28 14:00                 ` Andrey Ryabinin
2017-06-22 14:14   ` [PATCH v5 4/4] asm-generic, x86: add comments for atomic instrumentation Dmitry Vyukov
2017-06-22 14:14     ` Dmitry Vyukov
2017-06-23 14:01     ` [tip:locking/core] locking/atomic/x86, asm-generic: Add " tip-bot for Dmitry Vyukov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170623085402.kfzu6sri6bwi2ppo@gmail.com \
    --to=mingo@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=aryabinin@virtuozzo.com \
    --cc=dvyukov@google.com \
    --cc=hpa@zytor.com \
    --cc=kasan-dev@googlegroups.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=will.deacon@arm.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.