All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: simran singhal <singhalsimran0@gmail.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	Andreas Dilger <andreas.dilger@intel.com>,
	lustre-devel@lists.lustre.org
Subject: [lustre-devel] [PATCH] staging: lustre: lnet: selftest: Change the type of variable to bool
Date: Sat, 24 Jun 2017 00:16:31 +0800	[thread overview]
Message-ID: <20170623161631.GC20104@kroah.com> (raw)
In-Reply-To: <20170620090637.GA15837@singhal-Inspiron-5558>

On Tue, Jun 20, 2017 at 02:36:37PM +0530, simran singhal wrote:
> This patch changes the type of variable done from int to boolean. As it
> is been used as a boolean in the function sfw_test_rpc_done(). It also
> makes the code more readable and bool data type also requires less
> memory in comparison to int data type.

Are you sure it takes less memory?  What is the difference before and
after your patch?  Don't make claims without having a way to back them
up :)

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: simran singhal <singhalsimran0@gmail.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	Andreas Dilger <andreas.dilger@intel.com>,
	lustre-devel@lists.lustre.org
Subject: Re: [PATCH] staging: lustre: lnet: selftest: Change the type of variable to bool
Date: Sat, 24 Jun 2017 00:16:31 +0800	[thread overview]
Message-ID: <20170623161631.GC20104@kroah.com> (raw)
In-Reply-To: <20170620090637.GA15837@singhal-Inspiron-5558>

On Tue, Jun 20, 2017 at 02:36:37PM +0530, simran singhal wrote:
> This patch changes the type of variable done from int to boolean. As it
> is been used as a boolean in the function sfw_test_rpc_done(). It also
> makes the code more readable and bool data type also requires less
> memory in comparison to int data type.

Are you sure it takes less memory?  What is the difference before and
after your patch?  Don't make claims without having a way to back them
up :)

thanks,

greg k-h

  reply	other threads:[~2017-06-23 16:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-20  9:06 [lustre-devel] [PATCH] staging: lustre: lnet: selftest: Change the type of variable to bool simran singhal
2017-06-20  9:06 ` simran singhal
2017-06-23 16:16 ` Greg Kroah-Hartman [this message]
2017-06-23 16:16   ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170623161631.GC20104@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=andreas.dilger@intel.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lustre-devel@lists.lustre.org \
    --cc=oleg.drokin@intel.com \
    --cc=singhalsimran0@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.