From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Simran Singhal <singhalsimran0@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
linux-fbdev@vger.kernel.org,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Teddy Wang <teddy.wang@siliconmotion.com>
Subject: Re: [PATCH] staging: sm750fb: Remove typedefs from _logical_chip_type_t and _clock_type_t
Date: Fri, 23 Jun 2017 17:32:32 +0000 [thread overview]
Message-ID: <20170623173232.GF19626@kroah.com> (raw)
In-Reply-To: <20170619172120.GA28772@singhal-Inspiron-5558>
On Mon, Jun 19, 2017 at 10:51:21PM +0530, Simran Singhal wrote:
> This patch removes typedefs from enum _logical_chip_type_t and enum
> _clock_type_t and rename them to logical_chip_type_t and clock_type_t
> respectively.
Why are you doing two different typedef fixups in a single patch?
Please only do one at a time.
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Simran Singhal <singhalsimran0@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
linux-fbdev@vger.kernel.org,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Teddy Wang <teddy.wang@siliconmotion.com>
Subject: Re: [PATCH] staging: sm750fb: Remove typedefs from _logical_chip_type_t and _clock_type_t
Date: Fri, 23 Jun 2017 19:32:32 +0200 [thread overview]
Message-ID: <20170623173232.GF19626@kroah.com> (raw)
In-Reply-To: <20170619172120.GA28772@singhal-Inspiron-5558>
On Mon, Jun 19, 2017 at 10:51:21PM +0530, Simran Singhal wrote:
> This patch removes typedefs from enum _logical_chip_type_t and enum
> _clock_type_t and rename them to logical_chip_type_t and clock_type_t
> respectively.
Why are you doing two different typedef fixups in a single patch?
Please only do one at a time.
thanks,
greg k-h
next prev parent reply other threads:[~2017-06-23 17:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-19 17:21 [PATCH] staging: sm750fb: Remove typedefs from _logical_chip_type_t and _clock_type_t Simran Singhal
2017-06-19 17:33 ` Simran Singhal
2017-06-23 17:32 ` Greg Kroah-Hartman [this message]
2017-06-23 17:32 ` Greg Kroah-Hartman
2018-02-11 17:23 ` [PATCH] staging: sm750fb: Remove typedefs from enums Christian Luetke-Stetzkamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170623173232.GF19626@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=singhalsimran0@gmail.com \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.