* [PATCH] libkmod: Verify memory sizes on 32 bit systems.
@ 2017-06-25 14:55 Tobias Stoeckmann
0 siblings, 0 replies; only message in thread
From: Tobias Stoeckmann @ 2017-06-25 14:55 UTC (permalink / raw)
To: linux-modules
Large file system support is activated by default, which means that
on 32 bit systems, off_t is 64 bit in size.
Using st.st_size or any other 64 bit variable with mmap can lead to
integer truncation and therefore insufficient memory mapping.
Signed-off-by: Tobias Stoeckmann <tobias@stoeckmann.org>
---
libkmod/libkmod-file.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/libkmod/libkmod-file.c b/libkmod/libkmod-file.c
index 5eeba6a..86f34c6 100644
--- a/libkmod/libkmod-file.c
+++ b/libkmod/libkmod-file.c
@@ -255,6 +255,8 @@ static int load_reg(struct kmod_file *file)
return -errno;
file->size = st.st_size;
+ if ((uintmax_t)st.st_size > (uintmax_t)SIZE_MAX)
+ return -EFBIG;
file->memory = mmap(NULL, file->size, PROT_READ, MAP_PRIVATE,
file->fd, 0);
if (file->memory == MAP_FAILED)
--
2.13.2
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2017-06-25 14:54 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-25 14:55 [PATCH] libkmod: Verify memory sizes on 32 bit systems Tobias Stoeckmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.