From: Will Deacon <will.deacon@arm.com>
To: Jiri Slaby <jslaby@suse.cz>
Cc: Thomas Gleixner <tglx@linutronix.de>,
mingo@redhat.com, peterz@infradead.org, dvhart@infradead.org,
linux-kernel@vger.kernel.org, Richard Henderson <rth@twiddle.net>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Matt Turner <mattst88@gmail.com>,
Vineet Gupta <vgupta@synopsys.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Richard Kuo <rkuo@codeaurora.org>,
Tony Luck <tony.luck@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>,
Michal Simek <monstr@monstr.eu>,
Ralf Baechle <ralf@linux-mips.org>,
Jonas Bonn <jonas@southpole.se>,
Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>,
Stafford Horne <shorne@gmail.com>,
"James E.J. Bottomley" <jejb@parisc-linux.org>,
Helge Deller <deller@gmx.de>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Pa
Subject: Re: [PATCH 1/1] futex: remove duplicated code and fix UB
Date: Mon, 26 Jun 2017 13:08:14 +0100 [thread overview]
Message-ID: <20170626120814.GF1691@arm.com> (raw)
In-Reply-To: <80af8d81-4522-de2d-8289-1ab46565505a@suse.cz>
On Mon, Jun 26, 2017 at 02:02:31PM +0200, Jiri Slaby wrote:
> On 06/23/2017, 09:51 AM, Thomas Gleixner wrote:
> > On Wed, 21 Jun 2017, Jiri Slaby wrote:
> >> diff --git a/arch/arm64/include/asm/futex.h b/arch/arm64/include/asm/futex.h
> >> index f32b42e8725d..5bb2fd4674e7 100644
> >> --- a/arch/arm64/include/asm/futex.h
> >> +++ b/arch/arm64/include/asm/futex.h
> >> @@ -48,20 +48,10 @@ do { \
> >> } while (0)
> >>
> >> static inline int
> >> -futex_atomic_op_inuser(unsigned int encoded_op, u32 __user *uaddr)
> >
> > That unsigned int seems to be a change from the arm64 tree in next. It's
> > not upstream and it'll cause a (easy to resolve) conflict.
>
> Ugh, I thought the arm64 is in upstream already. Note that this patch
> just takes what is in this arm64 fix and makes it effective for all
> architectures. So I will wait with v2 until it merges upstream.
>
> So, Will, will you incorporate Thomas' comments into your arm64 fix?
I wasn't planning to (it's already queued and I think they're just cosmetic
changes). The easiest thing is probably for you to make the changes in the
generic version when you post v2.
Will
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Jiri Slaby <jslaby@suse.cz>
Cc: Thomas Gleixner <tglx@linutronix.de>,
mingo@redhat.com, peterz@infradead.org, dvhart@infradead.org,
linux-kernel@vger.kernel.org, Richard Henderson <rth@twiddle.net>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Matt Turner <mattst88@gmail.com>,
Vineet Gupta <vgupta@synopsys.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Richard Kuo <rkuo@codeaurora.org>,
Tony Luck <tony.luck@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>,
Michal Simek <monstr@monstr.eu>,
Ralf Baechle <ralf@linux-mips.org>,
Jonas Bonn <jonas@southpole.se>,
Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>,
Stafford Horne <shorne@gmail.com>,
"James E.J. Bottomley" <jejb@parisc-linux.org>,
Helge Deller <deller@gmx.de>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
"David S. Miller" <davem@davemloft.net>,
"H. Peter Anvin" <hpa@zytor.com>, Chris Zankel <chris@zankel.net>,
Max Filippov <jcmvbkbc@gmail.com>, Arnd Bergmann <arnd@arndb.de>,
x86@kernel.org, linux-alpha@vger.kernel.org,
linux-snps-arc@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org,
linux-mips@linux-mips.org, openrisc@lists.librecores.org,
linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-s390@vger.kernel.org, linux-sh@vger.kernel.org,
sparclinux@vger.kernel.org, linux-xtensa@linux-xtensa.org,
linux-arch@vger.kernel.org
Subject: Re: [PATCH 1/1] futex: remove duplicated code and fix UB
Date: Mon, 26 Jun 2017 13:08:14 +0100 [thread overview]
Message-ID: <20170626120814.GF1691@arm.com> (raw)
Message-ID: <20170626120814.Cm6zMJ83tNwUZoppZ9xNShO7ovWYQdJ5R8LR0gY2ScA@z> (raw)
In-Reply-To: <80af8d81-4522-de2d-8289-1ab46565505a@suse.cz>
On Mon, Jun 26, 2017 at 02:02:31PM +0200, Jiri Slaby wrote:
> On 06/23/2017, 09:51 AM, Thomas Gleixner wrote:
> > On Wed, 21 Jun 2017, Jiri Slaby wrote:
> >> diff --git a/arch/arm64/include/asm/futex.h b/arch/arm64/include/asm/futex.h
> >> index f32b42e8725d..5bb2fd4674e7 100644
> >> --- a/arch/arm64/include/asm/futex.h
> >> +++ b/arch/arm64/include/asm/futex.h
> >> @@ -48,20 +48,10 @@ do { \
> >> } while (0)
> >>
> >> static inline int
> >> -futex_atomic_op_inuser(unsigned int encoded_op, u32 __user *uaddr)
> >
> > That unsigned int seems to be a change from the arm64 tree in next. It's
> > not upstream and it'll cause a (easy to resolve) conflict.
>
> Ugh, I thought the arm64 is in upstream already. Note that this patch
> just takes what is in this arm64 fix and makes it effective for all
> architectures. So I will wait with v2 until it merges upstream.
>
> So, Will, will you incorporate Thomas' comments into your arm64 fix?
I wasn't planning to (it's already queued and I think they're just cosmetic
changes). The easiest thing is probably for you to make the changes in the
generic version when you post v2.
Will
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Jiri Slaby <jslaby@suse.cz>
Cc: Thomas Gleixner <tglx@linutronix.de>,
mingo@redhat.com, peterz@infradead.org, dvhart@infradead.org,
linux-kernel@vger.kernel.org, Richard Henderson <rth@twiddle.net>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Matt Turner <mattst88@gmail.com>,
Vineet Gupta <vgupta@synopsys.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Richard Kuo <rkuo@codeaurora.org>,
Tony Luck <tony.luck@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>,
Michal Simek <monstr@monstr.eu>,
Ralf Baechle <ralf@linux-mips.org>,
Jonas Bonn <jonas@southpole.se>,
Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>,
Stafford Horne <shorne@gmail.com>,
"James E.J. Bottomley" <jejb@parisc-linux.org>,
Helge Deller <deller@gmx.de>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Pa
Subject: Re: [PATCH 1/1] futex: remove duplicated code and fix UB
Date: Mon, 26 Jun 2017 12:08:14 +0000 [thread overview]
Message-ID: <20170626120814.GF1691@arm.com> (raw)
In-Reply-To: <80af8d81-4522-de2d-8289-1ab46565505a@suse.cz>
On Mon, Jun 26, 2017 at 02:02:31PM +0200, Jiri Slaby wrote:
> On 06/23/2017, 09:51 AM, Thomas Gleixner wrote:
> > On Wed, 21 Jun 2017, Jiri Slaby wrote:
> >> diff --git a/arch/arm64/include/asm/futex.h b/arch/arm64/include/asm/futex.h
> >> index f32b42e8725d..5bb2fd4674e7 100644
> >> --- a/arch/arm64/include/asm/futex.h
> >> +++ b/arch/arm64/include/asm/futex.h
> >> @@ -48,20 +48,10 @@ do { \
> >> } while (0)
> >>
> >> static inline int
> >> -futex_atomic_op_inuser(unsigned int encoded_op, u32 __user *uaddr)
> >
> > That unsigned int seems to be a change from the arm64 tree in next. It's
> > not upstream and it'll cause a (easy to resolve) conflict.
>
> Ugh, I thought the arm64 is in upstream already. Note that this patch
> just takes what is in this arm64 fix and makes it effective for all
> architectures. So I will wait with v2 until it merges upstream.
>
> So, Will, will you incorporate Thomas' comments into your arm64 fix?
I wasn't planning to (it's already queued and I think they're just cosmetic
changes). The easiest thing is probably for you to make the changes in the
generic version when you post v2.
Will
WARNING: multiple messages have this Message-ID (diff)
From: will.deacon@arm.com (Will Deacon)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH 1/1] futex: remove duplicated code and fix UB
Date: Mon, 26 Jun 2017 13:08:14 +0100 [thread overview]
Message-ID: <20170626120814.GF1691@arm.com> (raw)
In-Reply-To: <80af8d81-4522-de2d-8289-1ab46565505a@suse.cz>
On Mon, Jun 26, 2017@02:02:31PM +0200, Jiri Slaby wrote:
> On 06/23/2017, 09:51 AM, Thomas Gleixner wrote:
> > On Wed, 21 Jun 2017, Jiri Slaby wrote:
> >> diff --git a/arch/arm64/include/asm/futex.h b/arch/arm64/include/asm/futex.h
> >> index f32b42e8725d..5bb2fd4674e7 100644
> >> --- a/arch/arm64/include/asm/futex.h
> >> +++ b/arch/arm64/include/asm/futex.h
> >> @@ -48,20 +48,10 @@ do { \
> >> } while (0)
> >>
> >> static inline int
> >> -futex_atomic_op_inuser(unsigned int encoded_op, u32 __user *uaddr)
> >
> > That unsigned int seems to be a change from the arm64 tree in next. It's
> > not upstream and it'll cause a (easy to resolve) conflict.
>
> Ugh, I thought the arm64 is in upstream already. Note that this patch
> just takes what is in this arm64 fix and makes it effective for all
> architectures. So I will wait with v2 until it merges upstream.
>
> So, Will, will you incorporate Thomas' comments into your arm64 fix?
I wasn't planning to (it's already queued and I think they're just cosmetic
changes). The easiest thing is probably for you to make the changes in the
generic version when you post v2.
Will
WARNING: multiple messages have this Message-ID (diff)
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] futex: remove duplicated code and fix UB
Date: Mon, 26 Jun 2017 13:08:14 +0100 [thread overview]
Message-ID: <20170626120814.GF1691@arm.com> (raw)
In-Reply-To: <80af8d81-4522-de2d-8289-1ab46565505a@suse.cz>
On Mon, Jun 26, 2017 at 02:02:31PM +0200, Jiri Slaby wrote:
> On 06/23/2017, 09:51 AM, Thomas Gleixner wrote:
> > On Wed, 21 Jun 2017, Jiri Slaby wrote:
> >> diff --git a/arch/arm64/include/asm/futex.h b/arch/arm64/include/asm/futex.h
> >> index f32b42e8725d..5bb2fd4674e7 100644
> >> --- a/arch/arm64/include/asm/futex.h
> >> +++ b/arch/arm64/include/asm/futex.h
> >> @@ -48,20 +48,10 @@ do { \
> >> } while (0)
> >>
> >> static inline int
> >> -futex_atomic_op_inuser(unsigned int encoded_op, u32 __user *uaddr)
> >
> > That unsigned int seems to be a change from the arm64 tree in next. It's
> > not upstream and it'll cause a (easy to resolve) conflict.
>
> Ugh, I thought the arm64 is in upstream already. Note that this patch
> just takes what is in this arm64 fix and makes it effective for all
> architectures. So I will wait with v2 until it merges upstream.
>
> So, Will, will you incorporate Thomas' comments into your arm64 fix?
I wasn't planning to (it's already queued and I think they're just cosmetic
changes). The easiest thing is probably for you to make the changes in the
generic version when you post v2.
Will
next prev parent reply other threads:[~2017-06-26 12:08 UTC|newest]
Thread overview: 85+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-21 11:53 [PATCH 1/1] futex: remove duplicated code and fix UB Jiri Slaby
2017-06-21 11:53 ` Jiri Slaby
2017-06-21 11:53 ` Jiri Slaby
2017-06-21 11:53 ` Jiri Slaby
2017-06-21 11:53 ` Jiri Slaby
2017-06-21 11:53 ` Jiri Slaby
2017-06-22 3:53 ` Darren Hart
2017-06-22 3:53 ` Darren Hart
2017-06-22 3:53 ` Darren Hart
2017-06-22 3:53 ` Darren Hart
2017-06-22 3:53 ` Darren Hart
2017-06-22 3:53 ` Darren Hart
2017-06-23 7:51 ` Thomas Gleixner
2017-06-23 7:51 ` Thomas Gleixner
2017-06-23 7:51 ` Thomas Gleixner
2017-06-23 7:51 ` Thomas Gleixner
2017-06-23 7:51 ` Thomas Gleixner
2017-06-23 7:51 ` Thomas Gleixner
2017-06-23 7:51 ` Thomas Gleixner
2017-06-26 12:02 ` Jiri Slaby
2017-06-26 12:02 ` Jiri Slaby
2017-06-26 12:02 ` Jiri Slaby
2017-06-26 12:02 ` Jiri Slaby
2017-06-26 12:02 ` Jiri Slaby
2017-06-26 12:08 ` Will Deacon [this message]
2017-06-26 12:08 ` Will Deacon
2017-06-26 12:08 ` Will Deacon
2017-06-26 12:08 ` Will Deacon
2017-06-26 12:08 ` Will Deacon
2017-07-03 10:18 ` Thomas Gleixner
2017-07-03 10:18 ` Thomas Gleixner
2017-07-03 10:18 ` Thomas Gleixner
2017-07-03 10:18 ` Thomas Gleixner
2017-07-03 10:18 ` Thomas Gleixner
2017-07-03 10:18 ` Thomas Gleixner
2017-07-03 10:18 ` Thomas Gleixner
-- strict thread matches above, loose matches on Subject: below --
2017-05-15 13:07 [PATCH 1/1] futex: remove duplicated code Jiri Slaby
2017-05-15 13:07 ` Jiri Slaby
2017-05-15 13:07 ` [OpenRISC] " Jiri Slaby
2017-05-15 13:07 ` Jiri Slaby
2017-05-15 13:07 ` Jiri Slaby
2017-05-15 13:07 ` Jiri Slaby
2017-05-15 13:07 ` Jiri Slaby
2017-05-15 13:16 ` Will Deacon
2017-05-15 13:16 ` Will Deacon
2017-05-15 13:16 ` [OpenRISC] " Will Deacon
2017-05-15 13:16 ` Will Deacon
2017-05-15 13:16 ` Will Deacon
2017-05-15 13:16 ` Will Deacon
2017-05-15 13:16 ` Will Deacon
2017-05-17 8:01 ` Jiri Slaby
2017-05-17 8:01 ` Jiri Slaby
2017-05-17 8:01 ` [OpenRISC] " Jiri Slaby
2017-05-17 8:01 ` Jiri Slaby
2017-05-17 8:01 ` Jiri Slaby
2017-05-17 8:01 ` Jiri Slaby
2017-05-17 8:01 ` Jiri Slaby
2017-05-18 17:30 ` Will Deacon
2017-05-18 17:30 ` Will Deacon
2017-05-18 17:30 ` [OpenRISC] " Will Deacon
2017-05-18 17:30 ` Will Deacon
2017-05-18 17:30 ` Will Deacon
2017-05-18 17:30 ` Will Deacon
2017-05-18 17:30 ` Will Deacon
2017-05-22 21:11 ` Thomas Gleixner
2017-05-22 21:11 ` Thomas Gleixner
2017-05-22 21:11 ` [OpenRISC] " Thomas Gleixner
2017-05-22 21:11 ` Thomas Gleixner
2017-05-22 21:11 ` Thomas Gleixner
2017-05-22 21:11 ` Thomas Gleixner
2017-05-22 21:11 ` Thomas Gleixner
2017-05-25 14:28 ` Will Deacon
2017-05-25 14:28 ` Will Deacon
2017-05-25 14:28 ` [OpenRISC] " Will Deacon
2017-05-25 14:28 ` Will Deacon
2017-05-25 14:28 ` Will Deacon
2017-05-25 14:28 ` Will Deacon
2017-05-25 14:28 ` Will Deacon
2017-05-26 6:54 ` Thomas Gleixner
2017-05-26 6:54 ` Thomas Gleixner
2017-05-26 6:54 ` [OpenRISC] " Thomas Gleixner
2017-05-26 6:54 ` Thomas Gleixner
2017-05-26 6:54 ` Thomas Gleixner
2017-05-26 6:54 ` Thomas Gleixner
2017-05-26 6:54 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170626120814.GF1691@arm.com \
--to=will.deacon@arm.com \
--cc=benh@kernel.crashing.org \
--cc=catalin.marinas@arm.com \
--cc=deller@gmx.de \
--cc=dvhart@infradead.org \
--cc=fenghua.yu@intel.com \
--cc=ink@jurassic.park.msu.ru \
--cc=jejb@parisc-linux.org \
--cc=jonas@southpole.se \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=mattst88@gmail.com \
--cc=mingo@redhat.com \
--cc=monstr@monstr.eu \
--cc=peterz@infradead.org \
--cc=ralf@linux-mips.org \
--cc=rkuo@codeaurora.org \
--cc=rth@twiddle.net \
--cc=shorne@gmail.com \
--cc=stefan.kristiansson@saunalahti.fi \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=vgupta@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.