From: Jerome Glisse <jglisse@redhat.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Andy Lutomirski <luto@kernel.org>,
Logan Gunthorpe <logang@deltatee.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] x86/mm/hotplug: fix BUG_ON() after hotremove by not freeing pud v3
Date: Mon, 26 Jun 2017 10:49:34 -0400 [thread overview]
Message-ID: <20170626144934.GA3706@redhat.com> (raw)
In-Reply-To: <20170626094304.bmvsia5zpixbazpu@gmail.com>
On Mon, Jun 26, 2017 at 11:43:04AM +0200, Ingo Molnar wrote:
>
> * jglisse@redhat.com <jglisse@redhat.com> wrote:
>
> > From: Jerome Glisse <jglisse@redhat.com>
> >
> > With commit af2cf278ef4f we no longer free pud so that we do not
> > have synchronize all pgd on hotremove/vfree. But the new 5 level
> > page table patchset reverted that for 4 level page table.
> >
> > This patch restore af2cf278ef4f and disable free_pud() if we are
> > in the 4 level page table case thus avoiding BUG_ON() after hot-
> > remove.
> >
> > af2cf278ef4f x86/mm/hotplug: Don't remove PGD entries in remove_pagetable()
>
> Am I correct that the _real_ buggy commit that introduced the breakage in v4.12
> is:
>
> f2a6a7050109: ("x86: Convert the rest of the code to support p4d_t")
>
> ... right?
Correct.
Jerome
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Jerome Glisse <jglisse@redhat.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Andy Lutomirski <luto@kernel.org>,
Logan Gunthorpe <logang@deltatee.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] x86/mm/hotplug: fix BUG_ON() after hotremove by not freeing pud v3
Date: Mon, 26 Jun 2017 10:49:34 -0400 [thread overview]
Message-ID: <20170626144934.GA3706@redhat.com> (raw)
In-Reply-To: <20170626094304.bmvsia5zpixbazpu@gmail.com>
On Mon, Jun 26, 2017 at 11:43:04AM +0200, Ingo Molnar wrote:
>
> * jglisse@redhat.com <jglisse@redhat.com> wrote:
>
> > From: Jérôme Glisse <jglisse@redhat.com>
> >
> > With commit af2cf278ef4f we no longer free pud so that we do not
> > have synchronize all pgd on hotremove/vfree. But the new 5 level
> > page table patchset reverted that for 4 level page table.
> >
> > This patch restore af2cf278ef4f and disable free_pud() if we are
> > in the 4 level page table case thus avoiding BUG_ON() after hot-
> > remove.
> >
> > af2cf278ef4f x86/mm/hotplug: Don't remove PGD entries in remove_pagetable()
>
> Am I correct that the _real_ buggy commit that introduced the breakage in v4.12
> is:
>
> f2a6a7050109: ("x86: Convert the rest of the code to support p4d_t")
>
> ... right?
Correct.
Jérôme
next prev parent reply other threads:[~2017-06-26 14:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-24 18:05 [PATCH] x86/mm/hotplug: fix BUG_ON() after hotremove by not freeing pud v3 jglisse
2017-06-24 18:05 ` jglisse
2017-06-26 9:43 ` Ingo Molnar
2017-06-26 9:43 ` Ingo Molnar
2017-06-26 14:49 ` Jerome Glisse [this message]
2017-06-26 14:49 ` Jerome Glisse
2017-06-27 7:19 ` [tip:x86/urgent] x86/mm/hotplug: Fix BUG_ON() after hot-remove by not freeing PUD tip-bot for Jérôme Glisse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170626144934.GA3706@redhat.com \
--to=jglisse@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=logang@deltatee.com \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.