From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Suman Anna <s-anna@ti.com>
Cc: Ohad Ben-Cohen <ohad@wizery.com>,
Rob Herring <robh+dt@kernel.org>,
Santosh Shilimkar <ssantosh@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-remoteproc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, "Andrew F. Davis" <afd@ti.com>,
Sam Nelson <sam.nelson@ti.com>,
Grygorii Strashko <grygorii.strashko@ti.com>
Subject: Re: [PATCH v3 2/3] remoteproc/keystone: Add a remoteproc driver for Keystone 2 DSPs
Date: Mon, 26 Jun 2017 14:19:57 -0700 [thread overview]
Message-ID: <20170626211957.GH18666@tuxbook> (raw)
In-Reply-To: <1f8d65fc-0acc-499e-a98e-953dce60750f@ti.com>
On Mon 26 Jun 13:20 PDT 2017, Suman Anna wrote:
> On 06/26/2017 03:06 PM, Bjorn Andersson wrote:
> > On Mon 26 Jun 08:54 PDT 2017, Suman Anna wrote:
> >> On 06/25/2017 03:15 PM, Bjorn Andersson wrote:
[..]
> > I still would like to have resources allocated at probe() time, so I
> > would appreciate a follow up patch moving the request_irq()s to probe,
> > per above comment (but we can take that after v4.13).
>
> OK thanks. This is a common theme across all the remoteproc drivers
> supporting rpmsg, and I definitely need to disable them in probe since
> the boot or the virtio/rpmsg devices are not guaranteed to be present in
> the probe.
>
We have a consistent struct rproc after rproc_alloc(). So before the
virtio device (rpmsg in your case) calls virtio_find_vqs() rvring->vq
will be NULL and rproc_vq_interrupt() is a nop.
So AFAICT it should be fine to register this at probe time and leave it
enabled...but there's a lot of moving parts involved here, so it's
possible that I'm missing something.
But in for both interrupts it's important to disable them before calling
rproc_free(), as this will free the memory passed to the interrupt
handler.
Regards,
Bjorn
WARNING: multiple messages have this Message-ID (diff)
From: bjorn.andersson@linaro.org (Bjorn Andersson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/3] remoteproc/keystone: Add a remoteproc driver for Keystone 2 DSPs
Date: Mon, 26 Jun 2017 14:19:57 -0700 [thread overview]
Message-ID: <20170626211957.GH18666@tuxbook> (raw)
In-Reply-To: <1f8d65fc-0acc-499e-a98e-953dce60750f@ti.com>
On Mon 26 Jun 13:20 PDT 2017, Suman Anna wrote:
> On 06/26/2017 03:06 PM, Bjorn Andersson wrote:
> > On Mon 26 Jun 08:54 PDT 2017, Suman Anna wrote:
> >> On 06/25/2017 03:15 PM, Bjorn Andersson wrote:
[..]
> > I still would like to have resources allocated at probe() time, so I
> > would appreciate a follow up patch moving the request_irq()s to probe,
> > per above comment (but we can take that after v4.13).
>
> OK thanks. This is a common theme across all the remoteproc drivers
> supporting rpmsg, and I definitely need to disable them in probe since
> the boot or the virtio/rpmsg devices are not guaranteed to be present in
> the probe.
>
We have a consistent struct rproc after rproc_alloc(). So before the
virtio device (rpmsg in your case) calls virtio_find_vqs() rvring->vq
will be NULL and rproc_vq_interrupt() is a nop.
So AFAICT it should be fine to register this at probe time and leave it
enabled...but there's a lot of moving parts involved here, so it's
possible that I'm missing something.
But in for both interrupts it's important to disable them before calling
rproc_free(), as this will free the memory passed to the interrupt
handler.
Regards,
Bjorn
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Andersson <bjorn.andersson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Suman Anna <s-anna-l0cyMroinI0@public.gmane.org>
Cc: Ohad Ben-Cohen <ohad-Ix1uc/W3ht7QT0dZR+AlfA@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Santosh Shilimkar
<ssantosh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
linux-remoteproc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"Andrew F. Davis" <afd-l0cyMroinI0@public.gmane.org>,
Sam Nelson <sam.nelson-l0cyMroinI0@public.gmane.org>,
Grygorii Strashko
<grygorii.strashko-l0cyMroinI0@public.gmane.org>
Subject: Re: [PATCH v3 2/3] remoteproc/keystone: Add a remoteproc driver for Keystone 2 DSPs
Date: Mon, 26 Jun 2017 14:19:57 -0700 [thread overview]
Message-ID: <20170626211957.GH18666@tuxbook> (raw)
In-Reply-To: <1f8d65fc-0acc-499e-a98e-953dce60750f-l0cyMroinI0@public.gmane.org>
On Mon 26 Jun 13:20 PDT 2017, Suman Anna wrote:
> On 06/26/2017 03:06 PM, Bjorn Andersson wrote:
> > On Mon 26 Jun 08:54 PDT 2017, Suman Anna wrote:
> >> On 06/25/2017 03:15 PM, Bjorn Andersson wrote:
[..]
> > I still would like to have resources allocated at probe() time, so I
> > would appreciate a follow up patch moving the request_irq()s to probe,
> > per above comment (but we can take that after v4.13).
>
> OK thanks. This is a common theme across all the remoteproc drivers
> supporting rpmsg, and I definitely need to disable them in probe since
> the boot or the virtio/rpmsg devices are not guaranteed to be present in
> the probe.
>
We have a consistent struct rproc after rproc_alloc(). So before the
virtio device (rpmsg in your case) calls virtio_find_vqs() rvring->vq
will be NULL and rproc_vq_interrupt() is a nop.
So AFAICT it should be fine to register this at probe time and leave it
enabled...but there's a lot of moving parts involved here, so it's
possible that I'm missing something.
But in for both interrupts it's important to disable them before calling
rproc_free(), as this will free the memory passed to the interrupt
handler.
Regards,
Bjorn
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-06-26 21:19 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-13 23:45 [PATCH v3 0/3] Add Keystone2 Remoteproc driver Suman Anna
2017-06-13 23:45 ` Suman Anna
2017-06-13 23:45 ` Suman Anna
2017-06-13 23:45 ` [PATCH v3 1/3] dt-bindings: remoteproc: Add Keystone DSP remoteproc binding Suman Anna
2017-06-13 23:45 ` Suman Anna
2017-06-13 23:45 ` Suman Anna
2017-06-13 23:45 ` Suman Anna
2017-06-13 23:45 ` [PATCH v3 2/3] remoteproc/keystone: Add a remoteproc driver for Keystone 2 DSPs Suman Anna
2017-06-13 23:45 ` Suman Anna
2017-06-13 23:45 ` Suman Anna
2017-06-25 20:15 ` Bjorn Andersson
2017-06-25 20:15 ` Bjorn Andersson
2017-06-25 20:15 ` Bjorn Andersson
2017-06-26 15:54 ` Suman Anna
2017-06-26 15:54 ` Suman Anna
2017-06-26 15:54 ` Suman Anna
2017-06-26 15:54 ` Suman Anna
2017-06-26 20:06 ` Bjorn Andersson
2017-06-26 20:06 ` Bjorn Andersson
2017-06-26 20:06 ` Bjorn Andersson
2017-06-26 20:20 ` Suman Anna
2017-06-26 20:20 ` Suman Anna
2017-06-26 20:20 ` Suman Anna
2017-06-26 20:20 ` Suman Anna
2017-06-26 21:19 ` Bjorn Andersson [this message]
2017-06-26 21:19 ` Bjorn Andersson
2017-06-26 21:19 ` Bjorn Andersson
2022-09-06 3:55 ` Dmitry Torokhov
2022-09-06 3:55 ` Dmitry Torokhov
2017-06-13 23:45 ` [PATCH v3 3/3] remoteproc/keystone: Ensure the DSPs are in reset in probe Suman Anna
2017-06-13 23:45 ` Suman Anna
2017-06-13 23:45 ` Suman Anna
2017-06-13 23:45 ` Suman Anna
2017-06-23 21:31 ` [PATCH v3 0/3] Add Keystone2 Remoteproc driver Suman Anna
2017-06-23 21:31 ` Suman Anna
2017-06-23 21:31 ` Suman Anna
2017-06-23 21:31 ` Suman Anna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170626211957.GH18666@tuxbook \
--to=bjorn.andersson@linaro.org \
--cc=afd@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=grygorii.strashko@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=ohad@wizery.com \
--cc=robh+dt@kernel.org \
--cc=s-anna@ti.com \
--cc=sam.nelson@ti.com \
--cc=ssantosh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.