* [PATCH] ath9k: remove useless variable assignment in ath_mci_intr() @ 2017-06-26 23:26 Gustavo A. R. Silva 2017-06-28 16:57 ` Kalle Valo 0 siblings, 1 reply; 3+ messages in thread From: Gustavo A. R. Silva @ 2017-06-26 23:26 UTC (permalink / raw) To: QCA ath9k Development, Kalle Valo Cc: linux-wireless, netdev, linux-kernel, Gustavo A. R. Silva Value assigned to variable offset at line 551 is overwritten at line 562, before it can be used. This makes such variable assignment useless. Addresses-Coverity-ID: 1226941 Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> --- drivers/net/wireless/ath/ath9k/mci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath9k/mci.c b/drivers/net/wireless/ath/ath9k/mci.c index 66596b9..cf23fd8 100644 --- a/drivers/net/wireless/ath/ath9k/mci.c +++ b/drivers/net/wireless/ath/ath9k/mci.c @@ -548,7 +548,7 @@ void ath_mci_intr(struct ath_softc *sc) if (mci_int_rxmsg & AR_MCI_INTERRUPT_RX_MSG_SCHD_INFO) { mci_int_rxmsg &= ~AR_MCI_INTERRUPT_RX_MSG_SCHD_INFO; - offset = ar9003_mci_state(ah, MCI_STATE_LAST_SCHD_MSG_OFFSET); + ar9003_mci_state(ah, MCI_STATE_LAST_SCHD_MSG_OFFSET); } if (mci_int_rxmsg & AR_MCI_INTERRUPT_RX_MSG_GPM) { -- 2.5.0 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: ath9k: remove useless variable assignment in ath_mci_intr() 2017-06-26 23:26 [PATCH] ath9k: remove useless variable assignment in ath_mci_intr() Gustavo A. R. Silva @ 2017-06-28 16:57 ` Kalle Valo 0 siblings, 0 replies; 3+ messages in thread From: Kalle Valo @ 2017-06-28 16:57 UTC (permalink / raw) To: Gustavo A. R. Silva Cc: QCA ath9k Development, Kalle Valo, linux-wireless, netdev, linux-kernel, Gustavo A. R. Silva "Gustavo A. R. Silva" <garsilva@embeddedor.com> wrote: > Value assigned to variable offset at line 551 is overwritten at line 562, > before it can be used. This makes such variable assignment useless. > > Addresses-Coverity-ID: 1226941 > Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> > Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com> Patch applied to ath-next branch of ath.git, thanks. 6788a3832c70 ath9k: remove useless variable assignment in ath_mci_intr() -- https://patchwork.kernel.org/patch/9810609/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: ath9k: remove useless variable assignment in ath_mci_intr() @ 2017-06-28 16:57 ` Kalle Valo 0 siblings, 0 replies; 3+ messages in thread From: Kalle Valo @ 2017-06-28 16:57 UTC (permalink / raw) To: Gustavo A. R. Silva Cc: QCA ath9k Development, Kalle Valo, linux-wireless-u79uwXL29TY76Z2rM5mHXA, netdev-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, Gustavo A. R. Silva "Gustavo A. R. Silva" <garsilva-L1vi/lXTdts+Va1GwOuvDg@public.gmane.org> wrote: > Value assigned to variable offset at line 551 is overwritten at line 562, > before it can be used. This makes such variable assignment useless. > > Addresses-Coverity-ID: 1226941 > Signed-off-by: Gustavo A. R. Silva <garsilva-L1vi/lXTdts+Va1GwOuvDg@public.gmane.org> > Signed-off-by: Kalle Valo <kvalo-A+ZNKFmMK5xy9aJCnZT0Uw@public.gmane.org> Patch applied to ath-next branch of ath.git, thanks. 6788a3832c70 ath9k: remove useless variable assignment in ath_mci_intr() -- https://patchwork.kernel.org/patch/9810609/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-06-28 16:57 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-06-26 23:26 [PATCH] ath9k: remove useless variable assignment in ath_mci_intr() Gustavo A. R. Silva 2017-06-28 16:57 ` Kalle Valo 2017-06-28 16:57 ` Kalle Valo
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.