From: Wolfram Sang <wsa@the-dreams.de>
To: Brendan Higgins <brendanhiggins@google.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
gregkh@linuxfoundation.org, davem@davemloft.net,
mchehab@kernel.org, Joel Stanley <joel@jms.id.au>,
martin.petersen@oracle.com,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
OpenBMC Maillist <openbmc@lists.ozlabs.org>
Subject: Re: [PATCH v11 3/4] i2c: aspeed: added driver for Aspeed I2C
Date: Tue, 27 Jun 2017 11:00:42 +0200 [thread overview]
Message-ID: <20170627090042.GA2408@katana> (raw)
In-Reply-To: <CAFd5g45=O2_MgfZEkmbY-=ZZY+izxeWSuhZT+B2e08P=O+WEog@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 486 bytes --]
> > If SCL is stuck low, how do you want to send a STOP?
> >
>
> Fair point. I should probably drop that in the future and just do a
> reset, and even then, doing a
> reset is probably just wishful thinking. If a slave is holding down
> SCL, we are pretty screwed.
Yes, you'd need to reset the client device. And that has to be done in
the client driver. I wonder if i2c_transfer and friends should return a
specific error value in that case... need to think about it.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-06-27 9:00 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-20 21:15 [PATCH v11 0/4] i2c: aspeed: added driver for Aspeed I2C Brendan Higgins
[not found] ` <20170620211516.13095-1-brendanhiggins-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2017-06-20 21:15 ` [PATCH v11 1/4] MAINTAINERS: add entry for Aspeed I2C driver Brendan Higgins
2017-06-20 21:15 ` Brendan Higgins
2017-06-23 18:40 ` Wolfram Sang
2017-06-20 21:15 ` [PATCH v11 2/4] i2c: aspeed: added documentation " Brendan Higgins
2017-06-20 21:15 ` Brendan Higgins
[not found] ` <20170620211516.13095-3-brendanhiggins-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2017-06-23 18:41 ` Wolfram Sang
2017-06-23 18:41 ` Wolfram Sang
2017-06-20 21:15 ` [PATCH v11 4/4] i2c: aspeed: added slave support " Brendan Higgins
2017-06-20 21:15 ` Brendan Higgins
2017-06-23 18:41 ` Wolfram Sang
2017-06-20 21:15 ` [PATCH v11 3/4] i2c: aspeed: added driver for Aspeed I2C Brendan Higgins
2017-06-23 18:43 ` Wolfram Sang
2017-06-26 6:18 ` Joel Stanley
2017-06-27 8:36 ` Brendan Higgins
2017-06-27 8:28 ` Brendan Higgins
2017-06-27 9:00 ` Wolfram Sang [this message]
2017-06-27 23:47 ` Brendan Higgins
2017-06-27 23:47 ` Brendan Higgins
[not found] ` <CAFd5g449iu6DGvMuP8-n8C6GBbr62G6_ZYS6Lh9038EB0XO9YA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-06-28 7:45 ` Wolfram Sang
2017-06-28 7:45 ` Wolfram Sang
2017-07-13 22:44 ` Brendan Higgins
2017-07-13 22:44 ` Brendan Higgins
[not found] ` <CAFd5g45V0Ya0UdBZMCoazvE0Sh33F3_oMb84-kLXn1qH0h=b3A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-07-14 7:18 ` Wolfram Sang
2017-07-14 7:18 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170627090042.GA2408@katana \
--to=wsa@the-dreams.de \
--cc=benh@kernel.crashing.org \
--cc=brendanhiggins@google.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=joel@jms.id.au \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=martin.petersen@oracle.com \
--cc=mchehab@kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.