From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: Brendan Higgins <brendanhiggins-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Greg KH
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
"David S . Miller"
<davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
mchehab-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
Joel Stanley <joel-U3u1mxZcP9KHXe+LvDLADg@public.gmane.org>,
martin.petersen-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org,
Benjamin Herrenschmidt
<benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Linux Kernel Mailing List
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
OpenBMC Maillist
<openbmc-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>
Subject: Re: [PATCH v11 3/4] i2c: aspeed: added driver for Aspeed I2C
Date: Fri, 14 Jul 2017 09:18:00 +0200 [thread overview]
Message-ID: <20170714071800.GA1498@katana> (raw)
In-Reply-To: <CAFd5g45V0Ya0UdBZMCoazvE0Sh33F3_oMb84-kLXn1qH0h=b3A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 592 bytes --]
> Basically what I was asking is whether I could use i2c_generic_scl_recovery
> in the case where SCL is hung.
The name is a bit misleading, I am afraid. Recovery can only be used when
SDA is stuck low. And to fix this it *uses* SCL toggling to get out of
it. And 'generic_scl' means 'gimme some SCL to control and I will toggle
it'. Compared to 'gpio_recovery' which will do all the GPIO handling for
you.
When SCL is hung, you can only reset the device which forces SCL low.
> I think I have a pretty good idea of what to do, I should probably just put
> together an RFC patch.
Sure.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: Brendan Higgins <brendanhiggins@google.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Greg KH <gregkh@linuxfoundation.org>,
"David S . Miller" <davem@davemloft.net>,
mchehab@kernel.org, Joel Stanley <joel@jms.id.au>,
martin.petersen@oracle.com,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
linux-i2c@vger.kernel.org,
devicetree <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
OpenBMC Maillist <openbmc@lists.ozlabs.org>
Subject: Re: [PATCH v11 3/4] i2c: aspeed: added driver for Aspeed I2C
Date: Fri, 14 Jul 2017 09:18:00 +0200 [thread overview]
Message-ID: <20170714071800.GA1498@katana> (raw)
In-Reply-To: <CAFd5g45V0Ya0UdBZMCoazvE0Sh33F3_oMb84-kLXn1qH0h=b3A@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 592 bytes --]
> Basically what I was asking is whether I could use i2c_generic_scl_recovery
> in the case where SCL is hung.
The name is a bit misleading, I am afraid. Recovery can only be used when
SDA is stuck low. And to fix this it *uses* SCL toggling to get out of
it. And 'generic_scl' means 'gimme some SCL to control and I will toggle
it'. Compared to 'gpio_recovery' which will do all the GPIO handling for
you.
When SCL is hung, you can only reset the device which forces SCL low.
> I think I have a pretty good idea of what to do, I should probably just put
> together an RFC patch.
Sure.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-07-14 7:18 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-20 21:15 [PATCH v11 0/4] i2c: aspeed: added driver for Aspeed I2C Brendan Higgins
[not found] ` <20170620211516.13095-1-brendanhiggins-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2017-06-20 21:15 ` [PATCH v11 1/4] MAINTAINERS: add entry for Aspeed I2C driver Brendan Higgins
2017-06-20 21:15 ` Brendan Higgins
2017-06-23 18:40 ` Wolfram Sang
2017-06-20 21:15 ` [PATCH v11 2/4] i2c: aspeed: added documentation " Brendan Higgins
2017-06-20 21:15 ` Brendan Higgins
[not found] ` <20170620211516.13095-3-brendanhiggins-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2017-06-23 18:41 ` Wolfram Sang
2017-06-23 18:41 ` Wolfram Sang
2017-06-20 21:15 ` [PATCH v11 4/4] i2c: aspeed: added slave support " Brendan Higgins
2017-06-20 21:15 ` Brendan Higgins
2017-06-23 18:41 ` Wolfram Sang
2017-06-20 21:15 ` [PATCH v11 3/4] i2c: aspeed: added driver for Aspeed I2C Brendan Higgins
2017-06-23 18:43 ` Wolfram Sang
2017-06-26 6:18 ` Joel Stanley
2017-06-27 8:36 ` Brendan Higgins
2017-06-27 8:28 ` Brendan Higgins
2017-06-27 9:00 ` Wolfram Sang
2017-06-27 23:47 ` Brendan Higgins
2017-06-27 23:47 ` Brendan Higgins
[not found] ` <CAFd5g449iu6DGvMuP8-n8C6GBbr62G6_ZYS6Lh9038EB0XO9YA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-06-28 7:45 ` Wolfram Sang
2017-06-28 7:45 ` Wolfram Sang
2017-07-13 22:44 ` Brendan Higgins
2017-07-13 22:44 ` Brendan Higgins
[not found] ` <CAFd5g45V0Ya0UdBZMCoazvE0Sh33F3_oMb84-kLXn1qH0h=b3A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-07-14 7:18 ` Wolfram Sang [this message]
2017-07-14 7:18 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170714071800.GA1498@katana \
--to=wsa-z923lk4zbo2bacvfa/9k2g@public.gmane.org \
--cc=benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org \
--cc=brendanhiggins-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=joel-U3u1mxZcP9KHXe+LvDLADg@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=martin.petersen-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=mchehab-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=openbmc-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.