All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roman Storozhenko <romeusmeister@gmail.com>
To: kvm@vger.kernel.org
Cc: christoffer.dall@linaro.org, marc.zyngier@arm.com,
	pbonzini@redhat.com, rkrcmar@redhat.com,
	linux-arm-kernel@lists.infradead.org,
	kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: Replaces 'unsigned' with 'unsigned int' in the codebase
Date: Tue, 27 Jun 2017 15:06:26 +0300	[thread overview]
Message-ID: <20170627120626.GA21666@home> (raw)
In-Reply-To: <9b50ee4b-d27a-8872-0cd3-cad8f5f0e0f8@redhat.com>

On Tue, Jun 27, 2017 at 12:01:25PM +0200, Paolo Bonzini wrote:
> 
> 
> On 27/06/2017 11:54, Roman Storozhenko wrote:
> > Signed-off-by: Roman Storozhenko <romeusmeister@gmail.com>
> > ---
> >  virt/kvm/arm/arm.c        |  2 +-
> >  virt/kvm/coalesced_mmio.c |  2 +-
> >  virt/kvm/eventfd.c        | 10 ++++++----
> >  virt/kvm/irqchip.c        |  7 ++++---
> >  virt/kvm/kvm_main.c       | 16 ++++++++--------
> >  5 files changed, 20 insertions(+), 17 deletions(-)
> 
> This change is pointless.  Contributors to KVM should know what
> "unsigned" means.

Paolo, thanks that you mentioned this. But I have a question - is this just
useless or this is an error?

I saw many places in the codebase where 'unsigned int' is used. That why I
decided to make the codebase more standartized from the style point of
view.

Thanks, Roman Storozhenko.

WARNING: multiple messages have this Message-ID (diff)
From: romeusmeister@gmail.com (Roman Storozhenko)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] KVM: Replaces 'unsigned' with 'unsigned int' in the codebase
Date: Tue, 27 Jun 2017 15:06:26 +0300	[thread overview]
Message-ID: <20170627120626.GA21666@home> (raw)
In-Reply-To: <9b50ee4b-d27a-8872-0cd3-cad8f5f0e0f8@redhat.com>

On Tue, Jun 27, 2017 at 12:01:25PM +0200, Paolo Bonzini wrote:
> 
> 
> On 27/06/2017 11:54, Roman Storozhenko wrote:
> > Signed-off-by: Roman Storozhenko <romeusmeister@gmail.com>
> > ---
> >  virt/kvm/arm/arm.c        |  2 +-
> >  virt/kvm/coalesced_mmio.c |  2 +-
> >  virt/kvm/eventfd.c        | 10 ++++++----
> >  virt/kvm/irqchip.c        |  7 ++++---
> >  virt/kvm/kvm_main.c       | 16 ++++++++--------
> >  5 files changed, 20 insertions(+), 17 deletions(-)
> 
> This change is pointless.  Contributors to KVM should know what
> "unsigned" means.

Paolo, thanks that you mentioned this. But I have a question - is this just
useless or this is an error?

I saw many places in the codebase where 'unsigned int' is used. That why I
decided to make the codebase more standartized from the style point of
view.

Thanks, Roman Storozhenko.

  reply	other threads:[~2017-06-27 12:06 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-27  9:54 [PATCH] KVM: Replaces 'unsigned' with 'unsigned int' in the codebase Roman Storozhenko
2017-06-27  9:54 ` Roman Storozhenko
2017-06-27 10:01 ` Paolo Bonzini
2017-06-27 10:01   ` Paolo Bonzini
2017-06-27 12:06   ` Roman Storozhenko [this message]
2017-06-27 12:06     ` Roman Storozhenko
2017-06-27 12:21     ` Joe Perches
2017-06-27 12:21       ` Joe Perches
2017-06-27 12:21       ` Joe Perches
2017-06-27 13:31       ` Roman Storozhenko
2017-06-27 13:31         ` Roman Storozhenko
2017-06-27 13:31         ` Roman Storozhenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170627120626.GA21666@home \
    --to=romeusmeister@gmail.com \
    --cc='@home \
    --cc=christoffer.dall@linaro.org \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=pbonzini@redhat.com \
    --cc=rkrcmar@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.