From: Wei Yang <richard.weiyang@gmail.com>
To: John Hubbard <jhubbard@nvidia.com>
Cc: Wei Yang <richard.weiyang@gmail.com>,
mhocko@suse.com, linux-mm@kvack.org
Subject: Re: [RFC PATCH 4/4] base/memory: pass start_section_nr to init_memory_block()
Date: Wed, 28 Jun 2017 08:18:36 +0800 [thread overview]
Message-ID: <20170628001836.GC66023@WeideMacBook-Pro.local> (raw)
In-Reply-To: <ac2b2750-d673-ce91-cd48-fc95e41ae6f7@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 779 bytes --]
On Tue, Jun 27, 2017 at 12:11:52AM -0700, John Hubbard wrote:
>On 06/24/2017 07:52 PM, Wei Yang wrote:
>> The second parameter of init_memory_block() is to calculate the
>> start_section_nr for the memory_block. While current implementation dose
>> some unnecessary transform between mem_sectioni and section_nr.
>
>Hi Wei,
>
>I am unable to find anything wrong with this patch (except of course
>that your top-level description in the "[PATCH 0/4" thread will need
>to be added somewhere).
>
>Here's a slight typo/grammar improvement for the patch
>description above, if you like:
>
>"The current implementation does some unnecessary conversions
>between mem_section and section_nr."
>
Thanks :-)
>thanks,
>john h
>
--
Wei Yang
Help you, Help me
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2017-06-28 0:18 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-25 2:52 [RFC PATCH 0/4] mm/hotplug: make hotplug memory_block alligned Wei Yang
2017-06-25 2:52 ` [RFC PATCH 1/4] mm/hotplug: aligne the hotplugable range with memory_block Wei Yang
2017-06-25 3:31 ` John Hubbard
2017-06-26 0:20 ` Wei Yang
2017-06-26 6:49 ` John Hubbard
2017-06-26 23:21 ` Wei Yang
2017-06-25 2:52 ` [RFC PATCH 2/4] mm/hotplug: walk_memroy_range on memory_block uit Wei Yang
2017-06-26 7:32 ` John Hubbard
2017-06-26 23:40 ` Wei Yang
2017-06-27 6:59 ` John Hubbard
2017-06-28 0:11 ` Wei Yang
2017-06-25 2:52 ` [RFC PATCH 3/4] mm/hotplug: make __add_pages() iterate on memory_block and split __add_section() Wei Yang
2017-06-26 7:50 ` John Hubbard
2017-06-26 23:53 ` Wei Yang
2017-06-27 6:47 ` John Hubbard
2017-06-28 0:16 ` Wei Yang
2017-06-28 0:22 ` Wei Yang
2017-06-25 2:52 ` [RFC PATCH 4/4] base/memory: pass start_section_nr to init_memory_block() Wei Yang
2017-06-27 7:11 ` John Hubbard
2017-06-28 0:18 ` Wei Yang [this message]
2017-06-26 7:46 ` [RFC PATCH 0/4] mm/hotplug: make hotplug memory_block alligned Michal Hocko
2017-06-27 2:13 ` Wei Yang
2017-06-28 9:43 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170628001836.GC66023@WeideMacBook-Pro.local \
--to=richard.weiyang@gmail.com \
--cc=jhubbard@nvidia.com \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.