Re: [RFC PATCH 3/4] mm/hotplug: make __add_pages() iterate on memory_block and split __add_section()

[Wei Yang <richard.weiyang@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1014 bytes --]

>diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
>index a79a83ec965f..14a08b980b59 100644
>--- a/mm/memory_hotplug.c
>+++ b/mm/memory_hotplug.c
>@@ -302,8 +302,7 @@ void __init register_page_bootmem_info_node(struct pglist_data *pgdat)
> }
> #endif /* CONFIG_HAVE_BOOTMEM_INFO_NODE */
> 
>-static int __meminit __add_section(int nid, unsigned long phys_start_pfn,
>-		bool want_memblock)
>+static int __meminit __add_section(int nid, unsigned long phys_start_pfn)
> {
> 	int ret;
> 	int i;
>@@ -332,6 +331,18 @@ static int __meminit __add_section(int nid, unsigned long phys_start_pfn,
> 		SetPageReserved(page);
> 	}
> 
>+	return 0;
>+}
>+
>+static int __meminit __add_memory_block(int nid, unsigned long phys_start_pfn,
>+		bool want_memblock)
>+{
>+	int ret;
>+
>+	ret = __add_section(nid, phys_start_pfn);
>+	if (ret)
>+		return ret;
>+

One error here.

I forget to iterate on each section in the memory_block.
Fixed in my repo.


-- 
Wei Yang
Help you, Help me

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]