All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
To: Arvind Yadav <arvind.yadav.cs-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] iommu/vt-d: constify intel_dma_ops.
Date: Wed, 28 Jun 2017 10:53:19 +0200	[thread overview]
Message-ID: <20170628085318.GB14532@8bytes.org> (raw)
In-Reply-To: <b1e3c53042ae405bf5bf86b0c06a4ee4f74c3fc3.1497349024.git.arvind.yadav.cs-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

On Tue, Jun 13, 2017 at 03:48:34PM +0530, Arvind Yadav wrote:
> File size before:
>    text	   data	    bss	    dec	    hex	filename
>   32765	    758	   1824	  35347	   8a13	drivers/iommu/intel-iommu.o
> 
> File size After adding 'const':
>    text	   data	    bss	    dec	    hex	filename
>   32925	    598	   1824	  35347	   8a13	drivers/iommu/intel-iommu.o

What is the point of those commit-messages? They just show that the
struct moved from data to the text segment. The overall size doesn't
change much.



	Joerg

WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: dwmw2@infradead.org, iommu@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iommu/vt-d: constify intel_dma_ops.
Date: Wed, 28 Jun 2017 10:53:19 +0200	[thread overview]
Message-ID: <20170628085318.GB14532@8bytes.org> (raw)
In-Reply-To: <b1e3c53042ae405bf5bf86b0c06a4ee4f74c3fc3.1497349024.git.arvind.yadav.cs@gmail.com>

On Tue, Jun 13, 2017 at 03:48:34PM +0530, Arvind Yadav wrote:
> File size before:
>    text	   data	    bss	    dec	    hex	filename
>   32765	    758	   1824	  35347	   8a13	drivers/iommu/intel-iommu.o
> 
> File size After adding 'const':
>    text	   data	    bss	    dec	    hex	filename
>   32925	    598	   1824	  35347	   8a13	drivers/iommu/intel-iommu.o

What is the point of those commit-messages? They just show that the
struct moved from data to the text segment. The overall size doesn't
change much.



	Joerg

  parent reply	other threads:[~2017-06-28  8:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-13 10:18 [PATCH] iommu/vt-d: constify intel_dma_ops Arvind Yadav
     [not found] ` <b1e3c53042ae405bf5bf86b0c06a4ee4f74c3fc3.1497349024.git.arvind.yadav.cs-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-06-28  8:53   ` Joerg Roedel [this message]
2017-06-28  8:53     ` Joerg Roedel
     [not found]     ` <20170628085318.GB14532-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2017-06-28 10:01       ` Arvind Yadav
2017-06-28 10:01         ` Arvind Yadav
     [not found]         ` <0868ed89-f9f2-1983-ea63-2e391142b44b-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-06-28 10:20           ` Joerg Roedel
2017-06-28 10:20             ` Joerg Roedel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170628085318.GB14532@8bytes.org \
    --to=joro-zlv9swrftaidnm+yrofe0a@public.gmane.org \
    --cc=arvind.yadav.cs-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
    --cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.