All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@codeaurora.org>
To: Gabriel FERNANDEZ <gabriel.fernandez@st.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Russell King <linux@armlinux.org.uk>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre TORGUE <alexandre.torgue@st.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Nicolas Pitre <nico@linaro.org>, Arnd Bergmann <arnd@arndb.de>,
	"daniel.thompson@linaro.org" <daniel.thompson@linaro.org>,
	"andrea.merello@gmail.com" <andrea.merello@gmail.com>,
	"radoslaw.pietrzyk@gmail.com" <radoslaw.pietrzyk@gmail.com>,
	Lee Jones <lee.jones@linaro.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
	Ludovic BARRE <ludovic.barre@st.com>,
	Olivier BIDEAU <olivier.bideau@st.com>,
	Amelie DELAUNAY <amelie.delaunay@st.com>,
	"gabriel.fernandez.st@gmail.com" <gabriel.fernandez.st@gmail.com>
Subject: Re: [RESEND PATCH v4] clk: stm32h7: Add stm32h743 clock driver
Date: Thu, 29 Jun 2017 17:20:08 -0700	[thread overview]
Message-ID: <20170630002008.GD22780@codeaurora.org> (raw)
In-Reply-To: <7c0c3861-cf61-a9e2-cd5d-2ae30b8f32fa@st.com>

On 06/29, Gabriel FERNANDEZ wrote:
> 
> 
> On 06/28/2017 05:59 PM, Stephen Boyd wrote:
> > On 06/27, Gabriel FERNANDEZ wrote:
> >>
> >> On 06/22/2017 12:07 AM, Stephen Boyd wrote:
> >>> readl_poll_timeout?
> >>>
> >> if i use readl_poll_timeout (wich use 'ktime_get()') it can be
> >> operational only after the selection of clocksource ? (device_initcall).
> >> And then if a driver turn on a clock before, it could blocked the linux
> >> console ?
> >>
> > Ok. I wonder if we could add some sort of starting check to
> > readl_poll_timeout() that tests system_state for booting vs.
> > scheduling? That should be sufficient to handle this case?
> >
> Oops i think i understood my problem...
> i used readl_poll_timeout in atomic context.
> I have to move my code in the .prepare ops.
> 
> If you are ok with that i will send a v5
> 

There's readl_poll_timeout_atomic() for those modes.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCH v4] clk: stm32h7: Add stm32h743 clock driver
Date: Thu, 29 Jun 2017 17:20:08 -0700	[thread overview]
Message-ID: <20170630002008.GD22780@codeaurora.org> (raw)
In-Reply-To: <7c0c3861-cf61-a9e2-cd5d-2ae30b8f32fa@st.com>

On 06/29, Gabriel FERNANDEZ wrote:
> 
> 
> On 06/28/2017 05:59 PM, Stephen Boyd wrote:
> > On 06/27, Gabriel FERNANDEZ wrote:
> >>
> >> On 06/22/2017 12:07 AM, Stephen Boyd wrote:
> >>> readl_poll_timeout?
> >>>
> >> if i use readl_poll_timeout (wich use 'ktime_get()') it can be
> >> operational only after the selection of clocksource ? (device_initcall).
> >> And then if a driver turn on a clock before, it could blocked the linux
> >> console ?
> >>
> > Ok. I wonder if we could add some sort of starting check to
> > readl_poll_timeout() that tests system_state for booting vs.
> > scheduling? That should be sufficient to handle this case?
> >
> Oops i think i understood my problem...
> i used readl_poll_timeout in atomic context.
> I have to move my code in the .prepare ops.
> 
> If you are ok with that i will send a v5
> 

There's readl_poll_timeout_atomic() for those modes.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@codeaurora.org>
To: Gabriel FERNANDEZ <gabriel.fernandez@st.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Russell King <linux@armlinux.org.uk>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre TORGUE <alexandre.torgue@st.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Nicolas Pitre <nico@linaro.org>, Arnd Bergmann <arnd@arndb.de>,
	"daniel.thompson@linaro.org" <daniel.thompson@linaro.org>,
	"andrea.merello@gmail.com" <andrea.merello@gmail.com>,
	"radoslaw.pietrzyk@gmail.com" <radoslaw.pietrzyk@gmail.com>,
	Lee Jones <lee.jones@linaro.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>
Subject: Re: [RESEND PATCH v4] clk: stm32h7: Add stm32h743 clock driver
Date: Thu, 29 Jun 2017 17:20:08 -0700	[thread overview]
Message-ID: <20170630002008.GD22780@codeaurora.org> (raw)
In-Reply-To: <7c0c3861-cf61-a9e2-cd5d-2ae30b8f32fa@st.com>

On 06/29, Gabriel FERNANDEZ wrote:
> 
> 
> On 06/28/2017 05:59 PM, Stephen Boyd wrote:
> > On 06/27, Gabriel FERNANDEZ wrote:
> >>
> >> On 06/22/2017 12:07 AM, Stephen Boyd wrote:
> >>> readl_poll_timeout?
> >>>
> >> if i use readl_poll_timeout (wich use 'ktime_get()') it can be
> >> operational only after the selection of clocksource ? (device_initcall).
> >> And then if a driver turn on a clock before, it could blocked the linux
> >> console ?
> >>
> > Ok. I wonder if we could add some sort of starting check to
> > readl_poll_timeout() that tests system_state for booting vs.
> > scheduling? That should be sufficient to handle this case?
> >
> Oops i think i understood my problem...
> i used readl_poll_timeout in atomic context.
> I have to move my code in the .prepare ops.
> 
> If you are ok with that i will send a v5
> 

There's readl_poll_timeout_atomic() for those modes.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

  reply	other threads:[~2017-06-30  0:20 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-07  6:59 [RESEND PATCH v4] clk: stm32h7: Add stm32h743 clock driver gabriel.fernandez
2017-06-07  6:59 ` gabriel.fernandez
2017-06-07  6:59 ` gabriel.fernandez at st.com
2017-06-21 22:07 ` Stephen Boyd
2017-06-21 22:07   ` Stephen Boyd
2017-06-22 14:20   ` Gabriel FERNANDEZ
2017-06-22 14:20     ` Gabriel FERNANDEZ
2017-06-22 14:20     ` Gabriel FERNANDEZ
2017-06-22 14:20     ` Gabriel FERNANDEZ
2017-06-27 12:17   ` Gabriel FERNANDEZ
2017-06-27 12:17     ` Gabriel FERNANDEZ
2017-06-27 12:17     ` Gabriel FERNANDEZ
2017-06-27 12:17     ` Gabriel FERNANDEZ
2017-06-28 15:59     ` Stephen Boyd
2017-06-28 15:59       ` Stephen Boyd
2017-06-28 15:59       ` Stephen Boyd
2017-06-29 13:41       ` Gabriel FERNANDEZ
2017-06-29 13:41         ` Gabriel FERNANDEZ
2017-06-29 13:41         ` Gabriel FERNANDEZ
2017-06-29 13:41         ` Gabriel FERNANDEZ
2017-06-30  0:20         ` Stephen Boyd [this message]
2017-06-30  0:20           ` Stephen Boyd
2017-06-30  0:20           ` Stephen Boyd
2017-06-30  7:14           ` Gabriel FERNANDEZ
2017-06-30  7:14             ` Gabriel FERNANDEZ
2017-06-30  7:14             ` Gabriel FERNANDEZ
2017-06-30  7:14             ` Gabriel FERNANDEZ
2017-06-30 18:54             ` Stephen Boyd
2017-06-30 18:54               ` Stephen Boyd
2017-06-30 18:54               ` Stephen Boyd
2017-07-05  9:27               ` Gabriel FERNANDEZ
2017-07-05  9:27                 ` Gabriel FERNANDEZ
2017-07-05  9:27                 ` Gabriel FERNANDEZ
2017-07-05  9:27                 ` Gabriel FERNANDEZ

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170630002008.GD22780@codeaurora.org \
    --to=sboyd@codeaurora.org \
    --cc=alexandre.torgue@st.com \
    --cc=amelie.delaunay@st.com \
    --cc=andrea.merello@gmail.com \
    --cc=arnd@arndb.de \
    --cc=daniel.thompson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gabriel.fernandez.st@gmail.com \
    --cc=gabriel.fernandez@st.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=ludovic.barre@st.com \
    --cc=mark.rutland@arm.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=mturquette@baylibre.com \
    --cc=nico@linaro.org \
    --cc=olivier.bideau@st.com \
    --cc=radoslaw.pietrzyk@gmail.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.