From: Stephen Boyd <sboyd@codeaurora.org>
To: Jerome Brunet <jbrunet@baylibre.com>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
Michael Turquette <mturquette@baylibre.com>,
linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org,
Neil Armstrong <narmstrong@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>
Subject: Re: [PATCH] clk: scpi: error when clock fails to register
Date: Thu, 29 Jun 2017 17:25:34 -0700 [thread overview]
Message-ID: <20170630002534.GF22780@codeaurora.org> (raw)
In-Reply-To: <20170628135345.9337-1-jbrunet@baylibre.com>
On 06/28, Jerome Brunet wrote:
> Current implementation of scpi_clk_add just print a warning when clock
> fails to register but then keep going as if nothing happened. The
> provider is then registered with bogus data.
>
> This may latter lead to an Oops in __clk_create_clk when
> hlist_add_head(&clk->clks_node, &hw->core->clks) is called.
>
> This patch fixes the issue and errors if a clock fails to register.
>
> Fixes: cd52c2a4b5c4 ("clk: add support for clocks provided by SCP(System Control Processor)")
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
Applied to clk-next
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: scpi: error when clock fails to register
Date: Thu, 29 Jun 2017 17:25:34 -0700 [thread overview]
Message-ID: <20170630002534.GF22780@codeaurora.org> (raw)
In-Reply-To: <20170628135345.9337-1-jbrunet@baylibre.com>
On 06/28, Jerome Brunet wrote:
> Current implementation of scpi_clk_add just print a warning when clock
> fails to register but then keep going as if nothing happened. The
> provider is then registered with bogus data.
>
> This may latter lead to an Oops in __clk_create_clk when
> hlist_add_head(&clk->clks_node, &hw->core->clks) is called.
>
> This patch fixes the issue and errors if a clock fails to register.
>
> Fixes: cd52c2a4b5c4 ("clk: add support for clocks provided by SCP(System Control Processor)")
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
Applied to clk-next
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2017-06-30 0:25 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-28 13:53 [PATCH] clk: scpi: error when clock fails to register Jerome Brunet
2017-06-28 13:53 ` Jerome Brunet
2017-06-28 15:04 ` Sudeep Holla
2017-06-28 15:04 ` Sudeep Holla
2017-06-28 15:38 ` Jerome Brunet
2017-06-28 15:38 ` Jerome Brunet
2017-06-28 15:52 ` Sudeep Holla
2017-06-28 15:52 ` Sudeep Holla
2017-06-28 16:46 ` Jerome Brunet
2017-06-28 16:46 ` Jerome Brunet
2017-06-28 17:07 ` Sudeep Holla
2017-06-28 17:07 ` Sudeep Holla
2017-06-28 22:33 ` Stephen Boyd
2017-06-28 22:33 ` Stephen Boyd
2017-06-29 8:50 ` Jerome Brunet
2017-06-29 8:50 ` Jerome Brunet
2017-06-29 9:12 ` Sudeep Holla
2017-06-29 9:12 ` Sudeep Holla
2017-06-29 9:03 ` Sudeep Holla
2017-06-29 9:03 ` Sudeep Holla
2017-06-30 0:25 ` Stephen Boyd [this message]
2017-06-30 0:25 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170630002534.GF22780@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=narmstrong@baylibre.com \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.