From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Dmitriy Cherkasov <dmitriy@oss-tech.org>
Cc: devel@driverdev.osuosl.org, Oleg Drokin <oleg.drokin@intel.com>,
Andreas Dilger <andreas.dilger@intel.com>,
James Simmons <jsimmons@infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Lustre Development List <lustre-devel@lists.lustre.org>
Subject: [lustre-devel] [PATCH v3] staging: lustre: lnet: remove dead code and crc32_le() wrapper
Date: Fri, 30 Jun 2017 08:01:20 +0200 [thread overview]
Message-ID: <20170630060120.GA29779@kroah.com> (raw)
In-Reply-To: <1498794766-12298-1-git-send-email-dmitriy@oss-tech.org>
On Fri, Jun 30, 2017 at 03:52:46AM +0000, Dmitriy Cherkasov wrote:
> After removing code which was premanently disabled with ifdefs, the
> function ksocknal_csum() becomes just a wrapper for crc32_le(). Remove
> this useless wrapper and instead call crc32_le() directly.
>
> This also resolves the following checkpatch warning which was
> triggered by the dead code:
>
> WARNING: space prohibited before semicolon
>
> Signed-off-by: Dmitriy Cherkasov <dmitriy@oss-tech.org>
> ---
> drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h | 11 -----------
> drivers/staging/lustre/lnet/klnds/socklnd/socklnd_lib.c | 14 +++++++-------
> 2 files changed, 7 insertions(+), 18 deletions(-)
What changed from previous versions of this patch? You need to put that
information below the --- line, as documented.
v4? :)
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Dmitriy Cherkasov <dmitriy@oss-tech.org>
Cc: devel@driverdev.osuosl.org, Oleg Drokin <oleg.drokin@intel.com>,
Andreas Dilger <andreas.dilger@intel.com>,
James Simmons <jsimmons@infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Lustre Development List <lustre-devel@lists.lustre.org>
Subject: Re: [PATCH v3] staging: lustre: lnet: remove dead code and crc32_le() wrapper
Date: Fri, 30 Jun 2017 08:01:20 +0200 [thread overview]
Message-ID: <20170630060120.GA29779@kroah.com> (raw)
In-Reply-To: <1498794766-12298-1-git-send-email-dmitriy@oss-tech.org>
On Fri, Jun 30, 2017 at 03:52:46AM +0000, Dmitriy Cherkasov wrote:
> After removing code which was premanently disabled with ifdefs, the
> function ksocknal_csum() becomes just a wrapper for crc32_le(). Remove
> this useless wrapper and instead call crc32_le() directly.
>
> This also resolves the following checkpatch warning which was
> triggered by the dead code:
>
> WARNING: space prohibited before semicolon
>
> Signed-off-by: Dmitriy Cherkasov <dmitriy@oss-tech.org>
> ---
> drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h | 11 -----------
> drivers/staging/lustre/lnet/klnds/socklnd/socklnd_lib.c | 14 +++++++-------
> 2 files changed, 7 insertions(+), 18 deletions(-)
What changed from previous versions of this patch? You need to put that
information below the --- line, as documented.
v4? :)
thanks,
greg k-h
next prev parent reply other threads:[~2017-06-30 6:01 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-29 4:42 [lustre-devel] [PATCH] staging: lustre: lnet: remove dead code Dmitriy Cherkasov
2017-06-29 4:42 ` Dmitriy Cherkasov
2017-06-29 14:32 ` [lustre-devel] " Greg Kroah-Hartman
2017-06-29 14:32 ` Greg Kroah-Hartman
2017-06-30 3:29 ` [lustre-devel] [PATCH v2] staging: lustre: lnet: remove dead code and crc32_le() wrapper Dmitriy Cherkasov
2017-06-30 3:29 ` Dmitriy Cherkasov
2017-06-30 3:37 ` [lustre-devel] " Joe Perches
2017-06-30 3:37 ` Joe Perches
2017-06-30 3:54 ` [lustre-devel] " Dmitriy Cherkasov
2017-06-30 3:54 ` Dmitriy Cherkasov
2017-06-30 3:52 ` [lustre-devel] [PATCH v3] " Dmitriy Cherkasov
2017-06-30 3:52 ` Dmitriy Cherkasov
2017-06-30 5:50 ` [lustre-devel] [PATCH v4] " Dmitriy Cherkasov
2017-06-30 5:50 ` Dmitriy Cherkasov
2017-07-06 19:14 ` [lustre-devel] " Dmitriy Cherkasov
2017-07-06 19:14 ` Dmitriy Cherkasov
2017-07-07 23:03 ` [lustre-devel] [PATCH v5] staging: lustre: lnet: remove dead code and useless wrapper Dmitriy Cherkasov
2017-07-07 23:03 ` Dmitriy Cherkasov
2017-07-13 0:27 ` [lustre-devel] " Dilger, Andreas
2017-07-13 0:27 ` Dilger, Andreas
2017-07-13 0:27 ` [lustre-devel] " Dilger, Andreas
2017-07-13 0:27 ` Dilger, Andreas
2017-06-30 6:01 ` Greg Kroah-Hartman [this message]
2017-06-30 6:01 ` [PATCH v3] staging: lustre: lnet: remove dead code and crc32_le() wrapper Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170630060120.GA29779@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=dmitriy@oss-tech.org \
--cc=jsimmons@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.