* [PATCH] dmaengine: zynqmp_dma: fix error return code in zynqmp_dma_chan_probe()
@ 2017-06-30 7:42 ` Gustavo A. R. Silva
0 siblings, 0 replies; 4+ messages in thread
From: Gustavo A. R. Silva @ 2017-06-30 7:42 UTC (permalink / raw)
To: linux-arm-kernel
Print error message and propagate the return value of
platform_get_irq on failure.
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
drivers/dma/xilinx/zynqmp_dma.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/dma/xilinx/zynqmp_dma.c b/drivers/dma/xilinx/zynqmp_dma.c
index 6d221e5..5fa6d0d 100644
--- a/drivers/dma/xilinx/zynqmp_dma.c
+++ b/drivers/dma/xilinx/zynqmp_dma.c
@@ -996,8 +996,11 @@ static int zynqmp_dma_chan_probe(struct zynqmp_dma_device *zdev,
zynqmp_dma_init(chan);
chan->irq = platform_get_irq(pdev, 0);
- if (chan->irq < 0)
- return -ENXIO;
+ if (chan->irq < 0) {
+ dev_err(&pdev->dev, "failed to get IRQ: %d\n", chan->irq);
+ return chan->irq;
+ }
+
err = devm_request_irq(&pdev->dev, chan->irq, zynqmp_dma_irq_handler, 0,
"zynqmp-dma", chan);
if (err)
--
2.5.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] dmaengine: zynqmp_dma: fix error return code in zynqmp_dma_chan_probe()
@ 2017-06-30 7:42 ` Gustavo A. R. Silva
0 siblings, 0 replies; 4+ messages in thread
From: Gustavo A. R. Silva @ 2017-06-30 7:42 UTC (permalink / raw)
To: Vinod Koul, Dan Williams, Michal Simek, Sören Brinkmann
Cc: dmaengine, linux-arm-kernel, linux-kernel, Gustavo A. R. Silva
Print error message and propagate the return value of
platform_get_irq on failure.
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
drivers/dma/xilinx/zynqmp_dma.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/dma/xilinx/zynqmp_dma.c b/drivers/dma/xilinx/zynqmp_dma.c
index 6d221e5..5fa6d0d 100644
--- a/drivers/dma/xilinx/zynqmp_dma.c
+++ b/drivers/dma/xilinx/zynqmp_dma.c
@@ -996,8 +996,11 @@ static int zynqmp_dma_chan_probe(struct zynqmp_dma_device *zdev,
zynqmp_dma_init(chan);
chan->irq = platform_get_irq(pdev, 0);
- if (chan->irq < 0)
- return -ENXIO;
+ if (chan->irq < 0) {
+ dev_err(&pdev->dev, "failed to get IRQ: %d\n", chan->irq);
+ return chan->irq;
+ }
+
err = devm_request_irq(&pdev->dev, chan->irq, zynqmp_dma_irq_handler, 0,
"zynqmp-dma", chan);
if (err)
--
2.5.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] dmaengine: zynqmp_dma: fix error return code in zynqmp_dma_chan_probe()
2017-06-30 7:42 ` Gustavo A. R. Silva
@ 2017-06-30 13:13 ` Sören Brinkmann
-1 siblings, 0 replies; 4+ messages in thread
From: Sören Brinkmann @ 2017-06-30 13:13 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, 2017-06-30 at 02:42:47 -0500, Gustavo A. R. Silva wrote:
> Print error message and propagate the return value of
> platform_get_irq on failure.
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Reviewed-by: S?ren Brinkmann <soren.brinkmann@xilinx.com>
S?ren
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dmaengine: zynqmp_dma: fix error return code in zynqmp_dma_chan_probe()
@ 2017-06-30 13:13 ` Sören Brinkmann
0 siblings, 0 replies; 4+ messages in thread
From: Sören Brinkmann @ 2017-06-30 13:13 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Vinod Koul, Dan Williams, Michal Simek, dmaengine,
linux-arm-kernel, linux-kernel
On Fri, 2017-06-30 at 02:42:47 -0500, Gustavo A. R. Silva wrote:
> Print error message and propagate the return value of
> platform_get_irq on failure.
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Reviewed-by: Sören Brinkmann <soren.brinkmann@xilinx.com>
Sören
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-06-30 13:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-30 7:42 [PATCH] dmaengine: zynqmp_dma: fix error return code in zynqmp_dma_chan_probe() Gustavo A. R. Silva
2017-06-30 7:42 ` Gustavo A. R. Silva
2017-06-30 13:13 ` Sören Brinkmann
2017-06-30 13:13 ` Sören Brinkmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.