From: Vinod Koul <vinod.koul@intel.com>
To: Sinan Kaya <okaya@codeaurora.org>
Cc: dmaengine@vger.kernel.org, timur@codeaurora.org,
linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
Dan Williams <dan.j.williams@intel.com>,
linux-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] dmaengine: qcom_hidma: correct API violation for submit
Date: Mon, 3 Jul 2017 10:40:22 +0530 [thread overview]
Message-ID: <20170703051022.GZ19154@localhost> (raw)
In-Reply-To: <1498833785-22632-1-git-send-email-okaya@codeaurora.org>
On Fri, Jun 30, 2017 at 10:43:05AM -0400, Sinan Kaya wrote:
> Current code is violating the DMA Engine API by putting the submitted
> requests directly into the HW queue. This causes queued transactions
> to be started by another thread as soon as the first one finishes.
>
> The DMA Engine document clearly states this.
>
> "dmaengine_submit() will not start the DMA operation".
>
> Move HW queuing of the requests into the issue_pending() routine
> to comply with API requirements also create a new queued state for
> temporarily holding the requests.
>
> A descriptor goes through these transitions now.
>
> free->prepared->queued->active->completed->free
>
> as opposed to
>
> free->prepared->active->completed->free
Applied, thanks
--
~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: vinod.koul@intel.com (Vinod Koul)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2] dmaengine: qcom_hidma: correct API violation for submit
Date: Mon, 3 Jul 2017 10:40:22 +0530 [thread overview]
Message-ID: <20170703051022.GZ19154@localhost> (raw)
In-Reply-To: <1498833785-22632-1-git-send-email-okaya@codeaurora.org>
On Fri, Jun 30, 2017 at 10:43:05AM -0400, Sinan Kaya wrote:
> Current code is violating the DMA Engine API by putting the submitted
> requests directly into the HW queue. This causes queued transactions
> to be started by another thread as soon as the first one finishes.
>
> The DMA Engine document clearly states this.
>
> "dmaengine_submit() will not start the DMA operation".
>
> Move HW queuing of the requests into the issue_pending() routine
> to comply with API requirements also create a new queued state for
> temporarily holding the requests.
>
> A descriptor goes through these transitions now.
>
> free->prepared->queued->active->completed->free
>
> as opposed to
>
> free->prepared->active->completed->free
Applied, thanks
--
~Vinod
next prev parent reply other threads:[~2017-07-03 5:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-30 14:43 [PATCH V2] dmaengine: qcom_hidma: correct API violation for submit Sinan Kaya
2017-06-30 14:43 ` Sinan Kaya
2017-07-03 5:10 ` Vinod Koul [this message]
2017-07-03 5:10 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170703051022.GZ19154@localhost \
--to=vinod.koul@intel.com \
--cc=andy.gross@linaro.org \
--cc=dan.j.williams@intel.com \
--cc=david.brown@linaro.org \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=okaya@codeaurora.org \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.