All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Lynn Lei <lynnl.wit@gmail.com>
Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
	linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: sm750fb: refactor method and fix potential type inconsistence
Date: Mon, 03 Jul 2017 06:22:29 +0000	[thread overview]
Message-ID: <20170703062229.GD13523@kroah.com> (raw)
In-Reply-To: <20170702142335.GA9915@lynnl.wit>

On Sun, Jul 02, 2017 at 10:27:40PM +0800, Lynn Lei wrote:
> make reg variable typed `u32' not `unsigned int'
> this can fix potential type inconsistence in some platforms

It can?  What platform?

> 
> refactor swPanelPowerSequence() make the code less redundant
> 
> a early check for disp to skip unnecessary delay

Only do one thing per patch please.

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Lynn Lei <lynnl.wit@gmail.com>
Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
	linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: sm750fb: refactor method and fix potential type inconsistence
Date: Mon, 3 Jul 2017 08:22:29 +0200	[thread overview]
Message-ID: <20170703062229.GD13523@kroah.com> (raw)
In-Reply-To: <20170702142335.GA9915@lynnl.wit>

On Sun, Jul 02, 2017 at 10:27:40PM +0800, Lynn Lei wrote:
> make reg variable typed `u32' not `unsigned int'
> this can fix potential type inconsistence in some platforms

It can?  What platform?

> 
> refactor swPanelPowerSequence() make the code less redundant
> 
> a early check for disp to skip unnecessary delay

Only do one thing per patch please.

thanks,

greg k-h

  reply	other threads:[~2017-07-03  6:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-02 14:27 [PATCH] staging: sm750fb: refactor method and fix potential type inconsistence Lynn Lei
2017-07-02 14:27 ` Lynn Lei
2017-07-03  6:22 ` Greg KH [this message]
2017-07-03  6:22   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170703062229.GD13523@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lynnl.wit@gmail.com \
    --cc=sudipm.mukherjee@gmail.com \
    --cc=teddy.wang@siliconmotion.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.