From: Baolin Wang <baolin.wang-lxIno14LUO0EEoCn2XhGlw@public.gmane.org>
To: wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
baolin.wang-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org
Subject: Re: [PATCH v3 2/2] i2c: Add Spreadtrum I2C controller driver
Date: Mon, 3 Jul 2017 14:22:44 +0800 [thread overview]
Message-ID: <20170703062244.GA24742@spreadtrum.com> (raw)
In-Reply-To: <6941c6866078fac8fe81d108b573f7408245a0b9.1498472593.git.baolin.wang-lxIno14LUO0EEoCn2XhGlw@public.gmane.org>
Hi Andy and Wolfram,
On 一, 6月 26, 2017 at 06:28:14下午 +0800, Baolin Wang wrote:
> This patch adds the I2C controller driver for Spreadtrum SC9860 platform.
>
> Signed-off-by: Baolin Wang <baolin.wang-lxIno14LUO0EEoCn2XhGlw@public.gmane.org>
> ---
> Changes since v2:
> - Remove some redundant comments and parens.
> - Define macros instead of magic number.
> - Add some comments to explain clock formula.
> - Change of_clk_get_by_name() to devm_clk_get().
> - Deal with other frequency.
> - Change register definiton to low case.
> - Change is_last_msg to boolean.
> - Other optimization.
>
> Changes sice v1:
> - Power on I2C device in probe().
> - Remove redundant macros and usb __maybe_unused.
> - Remove redundant 'of_match_ptr'.
> - Modify return values and check the return value for 'clk_prepare_enable'.
> ---
Do you have any more comments about this patch? Thanks.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Baolin Wang <baolin.wang@spreadtrum.com>
To: <wsa@the-dreams.de>, <mark.rutland@arm.com>, <robh+dt@kernel.org>
Cc: <linux-i2c@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <broonie@kernel.org>,
<baolin.wang@linaro.org>
Subject: Re: [PATCH v3 2/2] i2c: Add Spreadtrum I2C controller driver
Date: Mon, 3 Jul 2017 14:22:44 +0800 [thread overview]
Message-ID: <20170703062244.GA24742@spreadtrum.com> (raw)
In-Reply-To: <6941c6866078fac8fe81d108b573f7408245a0b9.1498472593.git.baolin.wang@spreadtrum.com>
Hi Andy and Wolfram,
On 一, 6月 26, 2017 at 06:28:14下午 +0800, Baolin Wang wrote:
> This patch adds the I2C controller driver for Spreadtrum SC9860 platform.
>
> Signed-off-by: Baolin Wang <baolin.wang@spreadtrum.com>
> ---
> Changes since v2:
> - Remove some redundant comments and parens.
> - Define macros instead of magic number.
> - Add some comments to explain clock formula.
> - Change of_clk_get_by_name() to devm_clk_get().
> - Deal with other frequency.
> - Change register definiton to low case.
> - Change is_last_msg to boolean.
> - Other optimization.
>
> Changes sice v1:
> - Power on I2C device in probe().
> - Remove redundant macros and usb __maybe_unused.
> - Remove redundant 'of_match_ptr'.
> - Modify return values and check the return value for 'clk_prepare_enable'.
> ---
Do you have any more comments about this patch? Thanks.
next prev parent reply other threads:[~2017-07-03 6:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-26 10:28 [PATCH v3 1/2] dt-bindings: i2c: Add Spreadtrum I2C controller documentation Baolin Wang
2017-06-26 10:28 ` Baolin Wang
2017-06-26 10:28 ` [PATCH v3 2/2] i2c: Add Spreadtrum I2C controller driver Baolin Wang
2017-06-26 10:28 ` Baolin Wang
[not found] ` <6941c6866078fac8fe81d108b573f7408245a0b9.1498472593.git.baolin.wang-lxIno14LUO0EEoCn2XhGlw@public.gmane.org>
2017-07-03 6:22 ` Baolin Wang [this message]
2017-07-03 6:22 ` Baolin Wang
2017-07-03 9:29 ` Chunyan Zhang
[not found] ` <CAAfSe-uJZFMA4nr8Ah3OKz0Wx9bJOLHXcWK9Ujxx3kSi=PvaLw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-07-06 8:30 ` Baolin Wang
2017-07-06 8:30 ` Baolin Wang
[not found] ` <2083c9d6e96a72f9c1324c8a277acfd780a34094.1498472593.git.baolin.wang-lxIno14LUO0EEoCn2XhGlw@public.gmane.org>
2017-06-26 14:05 ` [PATCH v3 1/2] dt-bindings: i2c: Add Spreadtrum I2C controller documentation Rob Herring
2017-06-26 14:05 ` Rob Herring
[not found] ` <CAL_JsqL5GcMAvO0-TLHqq5ho9bN_Xs45DWj8dtKRf-t_mr0n0g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-06-27 8:00 ` Baolin Wang
2017-06-27 8:00 ` Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170703062244.GA24742@spreadtrum.com \
--to=baolin.wang-lxino14luo0eeocn2xhglw@public.gmane.org \
--cc=baolin.wang-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.