All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Lynn Lei <lynnl.wit@gmail.com>
Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
	linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: sm750fb: fixed a assignment typo
Date: Mon, 03 Jul 2017 08:30:32 +0000	[thread overview]
Message-ID: <20170703083031.GA26406@kroah.com> (raw)
In-Reply-To: <20170703081315.GA1115@lynnl.wit>

On Mon, Jul 03, 2017 at 04:13:15PM +0800, Lynn Lei wrote:
> fixed a typo issue in get_mxclk_freq().
> 
> the original code using PLL_CTRL_M_SHIFT for shifting to set N flag.
> which is not right, it should be PLL_CTRL_N_SHIFT.
> 
> both PLL_CTRL_M_SHIFT and PLL_CTRL_N_SHIFT
>   defined in drivers/staging/sm750fb/ddk750_reg.h
> 
> Signed-off-by: Lynn Lei <lynnl.wit@gmail.com>
> ---
>  drivers/staging/sm750fb/ddk750_chip.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Always put what changed from the previous version here below the ---
line, like the Documentation states to do.

v3 please?

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Lynn Lei <lynnl.wit@gmail.com>
Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
	linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: sm750fb: fixed a assignment typo
Date: Mon, 3 Jul 2017 10:30:32 +0200	[thread overview]
Message-ID: <20170703083031.GA26406@kroah.com> (raw)
In-Reply-To: <20170703081315.GA1115@lynnl.wit>

On Mon, Jul 03, 2017 at 04:13:15PM +0800, Lynn Lei wrote:
> fixed a typo issue in get_mxclk_freq().
> 
> the original code using PLL_CTRL_M_SHIFT for shifting to set N flag.
> which is not right, it should be PLL_CTRL_N_SHIFT.
> 
> both PLL_CTRL_M_SHIFT and PLL_CTRL_N_SHIFT
>   defined in drivers/staging/sm750fb/ddk750_reg.h
> 
> Signed-off-by: Lynn Lei <lynnl.wit@gmail.com>
> ---
>  drivers/staging/sm750fb/ddk750_chip.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Always put what changed from the previous version here below the ---
line, like the Documentation states to do.

v3 please?

thanks,

greg k-h

  reply	other threads:[~2017-07-03  8:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-03  8:13 [PATCH v2] staging: sm750fb: fixed a assignment typo Lynn Lei
2017-07-03  8:13 ` Lynn Lei
2017-07-03  8:30 ` Greg KH [this message]
2017-07-03  8:30   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170703083031.GA26406@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lynnl.wit@gmail.com \
    --cc=sudipm.mukherjee@gmail.com \
    --cc=teddy.wang@siliconmotion.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.