All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Hocko <mhocko@kernel.org>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Joonsoo Kim <js1304@gmail.com>, Yang Shi <yang.shi@linaro.org>,
	Mel Gorman <mgorman@techsingularity.net>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: "mm: use early_pfn_to_nid in page_ext_init" broken on some configurations?
Date: Tue, 4 Jul 2017 12:53:42 +0200	[thread overview]
Message-ID: <20170704105342.GJ14722@dhcp22.suse.cz> (raw)
In-Reply-To: <45268b53-88dc-4129-725c-df5849e494db@suse.cz>

On Tue 04-07-17 11:39:57, Vlastimil Babka wrote:
> On 07/04/2017 07:23 AM, Joonsoo Kim wrote:
> > On Mon, Jul 03, 2017 at 04:18:01PM +0200, Vlastimil Babka wrote:
> >> allocated" looks much more sane there. But there's a warning nevertheless.
> > 
> > Warning would comes from the fact that drain_all_pages() is called
> > before mm_percpu_wq is initialised. We could remove WARN_ON_ONCE() and add
> > drain_local_page(zone) to fix the problem.
> 
> Wouldn't that still leave some period during boot where kernel already
> runs on multiple CPU's, but mm_percpu_wq is not yet initialized and
> somebody tries to use it? We want to catch such cases, right?

I haven't checked the boot sequence but if we know that we need
mm_percpu_wq initialized earlier than moving it should be not a big deal
I guess.
-- 
Michal Hocko
SUSE Labs

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Michal Hocko <mhocko@kernel.org>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Joonsoo Kim <js1304@gmail.com>, Yang Shi <yang.shi@linaro.org>,
	Mel Gorman <mgorman@techsingularity.net>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: "mm: use early_pfn_to_nid in page_ext_init" broken on some configurations?
Date: Tue, 4 Jul 2017 12:53:42 +0200	[thread overview]
Message-ID: <20170704105342.GJ14722@dhcp22.suse.cz> (raw)
In-Reply-To: <45268b53-88dc-4129-725c-df5849e494db@suse.cz>

On Tue 04-07-17 11:39:57, Vlastimil Babka wrote:
> On 07/04/2017 07:23 AM, Joonsoo Kim wrote:
> > On Mon, Jul 03, 2017 at 04:18:01PM +0200, Vlastimil Babka wrote:
> >> allocated" looks much more sane there. But there's a warning nevertheless.
> > 
> > Warning would comes from the fact that drain_all_pages() is called
> > before mm_percpu_wq is initialised. We could remove WARN_ON_ONCE() and add
> > drain_local_page(zone) to fix the problem.
> 
> Wouldn't that still leave some period during boot where kernel already
> runs on multiple CPU's, but mm_percpu_wq is not yet initialized and
> somebody tries to use it? We want to catch such cases, right?

I haven't checked the boot sequence but if we know that we need
mm_percpu_wq initialized earlier than moving it should be not a big deal
I guess.
-- 
Michal Hocko
SUSE Labs

  reply	other threads:[~2017-07-04 10:53 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-30 14:18 "mm: use early_pfn_to_nid in page_ext_init" broken on some configurations? Michal Hocko
2017-06-30 14:18 ` Michal Hocko
2017-06-30 15:42 ` Michal Hocko
2017-06-30 15:42   ` Michal Hocko
2017-06-30 15:44   ` Michal Hocko
2017-06-30 15:44     ` Michal Hocko
2017-07-04  5:11     ` Joonsoo Kim
2017-07-04  5:11       ` Joonsoo Kim
2017-07-04  6:51       ` Michal Hocko
2017-07-04  6:51         ` Michal Hocko
2017-07-03 11:48 ` Vlastimil Babka
2017-07-03 11:48   ` Vlastimil Babka
2017-07-03 14:18   ` Vlastimil Babka
2017-07-03 14:18     ` Vlastimil Babka
2017-07-04  5:23     ` Joonsoo Kim
2017-07-04  5:23       ` Joonsoo Kim
2017-07-04  9:39       ` Vlastimil Babka
2017-07-04  9:39         ` Vlastimil Babka
2017-07-04 10:53         ` Michal Hocko [this message]
2017-07-04 10:53           ` Michal Hocko
2017-07-04  5:17   ` Joonsoo Kim
2017-07-04  5:17     ` Joonsoo Kim
2017-07-07 12:00     ` Vlastimil Babka
2017-07-07 12:00       ` Vlastimil Babka
2017-07-14  9:13       ` Michal Hocko
2017-07-14  9:13         ` Michal Hocko
2017-07-14  9:34         ` Vlastimil Babka
2017-07-14  9:34           ` Vlastimil Babka
2017-07-14 11:35           ` Michal Hocko
2017-07-14 11:35             ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170704105342.GJ14722@dhcp22.suse.cz \
    --to=mhocko@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=js1304@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@techsingularity.net \
    --cc=vbabka@suse.cz \
    --cc=yang.shi@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.