All of lore.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Colin King <colin.king@canonical.com>
Cc: Ingo Molnar <mingo@kernel.org>,
	Luc Van Oostenryck <luc.vanoostenryck@gmail.com>,
	Steven Whitehouse <swhiteho@redhat.com>,
	Deepa Dinamani <deepa.kernel@gmail.com>,
	Waiman Long <longman@redhat.com>,
	kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][-next] mqueue: fix incorrect memset size for object v
Date: Tue, 04 Jul 2017 17:13:10 +0000	[thread overview]
Message-ID: <20170704171310.GW10672@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20170704160919.19406-1-colin.king@canonical.com>

On Tue, Jul 04, 2017 at 05:09:19PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The size of the memset is incorrect, it is currently using the size
> of attr (a struct mq_attr *) and not of v (a struct compat_mq_attr)

Folded (and that was a moderate infoleak - ->__reserved[] thing had
been copied out uninitialized).

WARNING: multiple messages have this Message-ID (diff)
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Colin King <colin.king@canonical.com>
Cc: Ingo Molnar <mingo@kernel.org>,
	Luc Van Oostenryck <luc.vanoostenryck@gmail.com>,
	Steven Whitehouse <swhiteho@redhat.com>,
	Deepa Dinamani <deepa.kernel@gmail.com>,
	Waiman Long <longman@redhat.com>,
	kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][-next] mqueue: fix incorrect memset size for object v
Date: Tue, 4 Jul 2017 18:13:10 +0100	[thread overview]
Message-ID: <20170704171310.GW10672@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20170704160919.19406-1-colin.king@canonical.com>

On Tue, Jul 04, 2017 at 05:09:19PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The size of the memset is incorrect, it is currently using the size
> of attr (a struct mq_attr *) and not of v (a struct compat_mq_attr)

Folded (and that was a moderate infoleak - ->__reserved[] thing had
been copied out uninitialized).

  reply	other threads:[~2017-07-04 17:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-04 16:09 [PATCH][-next] mqueue: fix incorrect memset size for object v Colin King
2017-07-04 16:09 ` Colin King
2017-07-04 17:13 ` Al Viro [this message]
2017-07-04 17:13   ` Al Viro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170704171310.GW10672@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=colin.king@canonical.com \
    --cc=deepa.kernel@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=longman@redhat.com \
    --cc=luc.vanoostenryck@gmail.com \
    --cc=mingo@kernel.org \
    --cc=swhiteho@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.