All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] crda: enable staging install
@ 2017-07-04 16:34 Maxime Hadjinlian
  2017-07-04 16:34 ` [Buildroot] [PATCH] qt5base: disable libraries not built Maxime Hadjinlian
  2017-07-04 17:08 ` [Buildroot] [PATCH] crda: enable staging install Thomas Petazzoni
  0 siblings, 2 replies; 3+ messages in thread
From: Maxime Hadjinlian @ 2017-07-04 16:34 UTC (permalink / raw)
  To: buildroot

It's needed to make mklibs work otherwise it can't find the missing
library for the crda binary.

Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
---
 package/crda/crda.mk | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/package/crda/crda.mk b/package/crda/crda.mk
index df879f68bb..713f852b65 100644
--- a/package/crda/crda.mk
+++ b/package/crda/crda.mk
@@ -10,12 +10,17 @@ CRDA_SITE = $(BR2_KERNEL_MIRROR)/software/network/crda
 CRDA_DEPENDENCIES = host-pkgconf host-python-pycrypto libnl libgcrypt
 CRDA_LICENSE = ISC
 CRDA_LICENSE_FILES = LICENSE
+CRDA_INSTALL_STAGING = YES

 define CRDA_BUILD_CMDS
 	$(TARGET_CONFIGURE_OPTS) \
 		$(MAKE) all_noverify -C $(@D)
 endef

+define CRDA_INSTALL_STAGING_CMDS
+	$(TARGET_CONFIGURE_OPTS) $(MAKE) install -C $(@D) DESTDIR=$(STAGING_DIR)
+endef
+
 define CRDA_INSTALL_TARGET_CMDS
 	$(TARGET_CONFIGURE_OPTS) $(MAKE) install -C $(@D) DESTDIR=$(TARGET_DIR)
 endef
--
2.13.2

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] qt5base: disable libraries not built
  2017-07-04 16:34 [Buildroot] [PATCH] crda: enable staging install Maxime Hadjinlian
@ 2017-07-04 16:34 ` Maxime Hadjinlian
  2017-07-04 17:08 ` [Buildroot] [PATCH] crda: enable staging install Thomas Petazzoni
  1 sibling, 0 replies; 3+ messages in thread
From: Maxime Hadjinlian @ 2017-07-04 16:34 UTC (permalink / raw)
  To: buildroot

From: Maxime Hadjinlian <maxime.hadjinlian@devialet.com>

We don't build theses libraries by default (we deactivate them at
configure time).
Theses are at the moment enabled by default in BR, a better patch will
be made at a later time.
---
 package/qt5/qt5base/qt5base.mk | 32 ++++++++++++++++----------------
 1 file changed, 16 insertions(+), 16 deletions(-)

diff --git a/package/qt5/qt5base/qt5base.mk b/package/qt5/qt5base/qt5base.mk
index 2b9db5cb66..ddc1f64174 100644
--- a/package/qt5/qt5base/qt5base.mk
+++ b/package/qt5/qt5base/qt5base.mk
@@ -186,22 +186,22 @@ QT5BASE_INSTALL_LIBS_y                                 += Qt5Core
 QT5BASE_INSTALL_LIBS_$(BR2_PACKAGE_QT5BASE_XCB)        += Qt5XcbQpa
 QT5BASE_INSTALL_LIBS_$(BR2_PACKAGE_QT5BASE_NETWORK)    += Qt5Network
 QT5BASE_INSTALL_LIBS_$(BR2_PACKAGE_QT5BASE_CONCURRENT) += Qt5Concurrent
-QT5BASE_INSTALL_LIBS_$(BR2_PACKAGE_QT5BASE_SQL)        += Qt5Sql
-QT5BASE_INSTALL_LIBS_$(BR2_PACKAGE_QT5BASE_TEST)       += Qt5Test
-QT5BASE_INSTALL_LIBS_$(BR2_PACKAGE_QT5BASE_XML)        += Qt5Xml
-QT5BASE_INSTALL_LIBS_$(BR2_PACKAGE_QT5BASE_OPENGL_LIB) += Qt5OpenGL
-ifeq ($(BR2_PACKAGE_QT5_VERSION_LATEST),y)
-QT5BASE_INSTALL_LIBS_$(BR2_PACKAGE_QT5BASE_EGLFS)      += Qt5EglFSDeviceIntegration
-ifeq ($(BR2_PACKAGE_MESA3D_OPENGL_EGL),y)
-QT5BASE_INSTALL_LIBS_$(BR2_PACKAGE_QT5BASE_EGLFS)      += Qt5EglFsKmsSupport
-endif
-else
-QT5BASE_INSTALL_LIBS_$(BR2_PACKAGE_QT5BASE_EGLFS)      += Qt5EglDeviceIntegration
-endif
-
-QT5BASE_INSTALL_LIBS_$(BR2_PACKAGE_QT5BASE_GUI)          += Qt5Gui
-QT5BASE_INSTALL_LIBS_$(BR2_PACKAGE_QT5BASE_WIDGETS)      += Qt5Widgets
-QT5BASE_INSTALL_LIBS_$(BR2_PACKAGE_QT5BASE_PRINTSUPPORT) += Qt5PrintSupport
+#QT5BASE_INSTALL_LIBS_$(BR2_PACKAGE_QT5BASE_SQL)        += Qt5Sql
+#QT5BASE_INSTALL_LIBS_$(BR2_PACKAGE_QT5BASE_TEST)       += Qt5Test
+#QT5BASE_INSTALL_LIBS_$(BR2_PACKAGE_QT5BASE_XML)        += Qt5Xml
+#QT5BASE_INSTALL_LIBS_$(BR2_PACKAGE_QT5BASE_OPENGL_LIB) += Qt5OpenGL
+#ifeq ($(BR2_PACKAGE_QT5_VERSION_LATEST),y)
+#QT5BASE_INSTALL_LIBS_$(BR2_PACKAGE_QT5BASE_EGLFS)      += Qt5EglFSDeviceIntegration
+#ifeq ($(BR2_PACKAGE_MESA3D_OPENGL_EGL),y)
+#QT5BASE_INSTALL_LIBS_$(BR2_PACKAGE_QT5BASE_EGLFS)      += Qt5EglFsKmsSupport
+#endif
+#else
+#QT5BASE_INSTALL_LIBS_$(BR2_PACKAGE_QT5BASE_EGLFS)      += Qt5EglDeviceIntegration
+#endif
+#
+#QT5BASE_INSTALL_LIBS_$(BR2_PACKAGE_QT5BASE_GUI)          += Qt5Gui
+#QT5BASE_INSTALL_LIBS_$(BR2_PACKAGE_QT5BASE_WIDGETS)      += Qt5Widgets
+#QT5BASE_INSTALL_LIBS_$(BR2_PACKAGE_QT5BASE_PRINTSUPPORT) += Qt5PrintSupport
 
 QT5BASE_INSTALL_LIBS_$(BR2_PACKAGE_QT5BASE_DBUS) += Qt5DBus
 
-- 
2.13.2

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] crda: enable staging install
  2017-07-04 16:34 [Buildroot] [PATCH] crda: enable staging install Maxime Hadjinlian
  2017-07-04 16:34 ` [Buildroot] [PATCH] qt5base: disable libraries not built Maxime Hadjinlian
@ 2017-07-04 17:08 ` Thomas Petazzoni
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2017-07-04 17:08 UTC (permalink / raw)
  To: buildroot

Hello,

On Tue,  4 Jul 2017 18:34:11 +0200, Maxime Hadjinlian wrote:
> It's needed to make mklibs work otherwise it can't find the missing
> library for the crda binary.

What is this mklibs thing? Why does it matter? We need a better
justification for this change :)

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-07-04 17:08 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-04 16:34 [Buildroot] [PATCH] crda: enable staging install Maxime Hadjinlian
2017-07-04 16:34 ` [Buildroot] [PATCH] qt5base: disable libraries not built Maxime Hadjinlian
2017-07-04 17:08 ` [Buildroot] [PATCH] crda: enable staging install Thomas Petazzoni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.