From: "Michael S. Tsirkin" <mst@redhat.com>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
Christoph Hellwig <hch@lst.de>,
Keith Busch <keith.busch@intel.com>,
Jason Wang <jasowang@redhat.com>
Subject: Re: [PATCH 7/8] virtio_blk: quiesce/unquiesce live IO when entering PM states
Date: Wed, 5 Jul 2017 00:39:34 +0300 [thread overview]
Message-ID: <20170705003734-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <1499154912-10420-8-git-send-email-sagi@grimberg.me>
On Tue, Jul 04, 2017 at 10:55:11AM +0300, Sagi Grimberg wrote:
> We must make sure that no requests are being queued before we iterate
> delete vqs. quiesce/unquiesce the request queue istead of start/stop
> hw queues.
>
> Cc: Michael S. Tsirkin <mst@redhat.com>
> Cc: Jason Wang <jasowang@redhat.com>
> Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
But please remember to Cc virtio mailing list on virtio patches.
> ---
> drivers/block/virtio_blk.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c
> index 0297ad7c1452..4e02aa5fdac0 100644
> --- a/drivers/block/virtio_blk.c
> +++ b/drivers/block/virtio_blk.c
> @@ -840,7 +840,7 @@ static int virtblk_freeze(struct virtio_device *vdev)
> /* Make sure no work handler is accessing the device. */
> flush_work(&vblk->config_work);
>
> - blk_mq_stop_hw_queues(vblk->disk->queue);
> + blk_mq_quiesce_queue(vblk->disk->queue);
>
> vdev->config->del_vqs(vdev);
> return 0;
> @@ -857,7 +857,7 @@ static int virtblk_restore(struct virtio_device *vdev)
>
> virtio_device_ready(vdev);
>
> - blk_mq_start_stopped_hw_queues(vblk->disk->queue, true);
> + blk_mq_unquiesce_queue(vblk->disk->queue);
> return 0;
> }
> #endif
> --
> 2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: mst@redhat.com (Michael S. Tsirkin)
Subject: [PATCH 7/8] virtio_blk: quiesce/unquiesce live IO when entering PM states
Date: Wed, 5 Jul 2017 00:39:34 +0300 [thread overview]
Message-ID: <20170705003734-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <1499154912-10420-8-git-send-email-sagi@grimberg.me>
On Tue, Jul 04, 2017@10:55:11AM +0300, Sagi Grimberg wrote:
> We must make sure that no requests are being queued before we iterate
> delete vqs. quiesce/unquiesce the request queue istead of start/stop
> hw queues.
>
> Cc: Michael S. Tsirkin <mst at redhat.com>
> Cc: Jason Wang <jasowang at redhat.com>
> Signed-off-by: Sagi Grimberg <sagi at grimberg.me>
Acked-by: Michael S. Tsirkin <mst at redhat.com>
But please remember to Cc virtio mailing list on virtio patches.
> ---
> drivers/block/virtio_blk.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c
> index 0297ad7c1452..4e02aa5fdac0 100644
> --- a/drivers/block/virtio_blk.c
> +++ b/drivers/block/virtio_blk.c
> @@ -840,7 +840,7 @@ static int virtblk_freeze(struct virtio_device *vdev)
> /* Make sure no work handler is accessing the device. */
> flush_work(&vblk->config_work);
>
> - blk_mq_stop_hw_queues(vblk->disk->queue);
> + blk_mq_quiesce_queue(vblk->disk->queue);
>
> vdev->config->del_vqs(vdev);
> return 0;
> @@ -857,7 +857,7 @@ static int virtblk_restore(struct virtio_device *vdev)
>
> virtio_device_ready(vdev);
>
> - blk_mq_start_stopped_hw_queues(vblk->disk->queue, true);
> + blk_mq_unquiesce_queue(vblk->disk->queue);
> return 0;
> }
> #endif
> --
> 2.7.4
next prev parent reply other threads:[~2017-07-04 21:39 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-04 7:55 [PATCH 0/8] correct quiescing in several block drivers Sagi Grimberg
2017-07-04 7:55 ` Sagi Grimberg
2017-07-04 7:55 ` [PATCH 1/8] nvme-rdma: quiesce/unquiesce admin_q instead of start/stop its hw queues Sagi Grimberg
2017-07-04 7:55 ` Sagi Grimberg
2017-07-04 8:15 ` Ming Lei
2017-07-04 8:15 ` Ming Lei
2017-07-04 8:59 ` Sagi Grimberg
2017-07-04 8:59 ` Sagi Grimberg
2017-07-04 9:07 ` Sagi Grimberg
2017-07-04 9:07 ` Sagi Grimberg
2017-07-04 12:41 ` Ming Lei
2017-07-04 12:41 ` Ming Lei
2017-07-04 15:35 ` Sagi Grimberg
2017-07-04 15:35 ` Sagi Grimberg
2017-07-04 7:55 ` [PATCH 2/8] nvme-fc: " Sagi Grimberg
2017-07-04 7:55 ` Sagi Grimberg
2017-07-04 8:18 ` Ming Lei
2017-07-04 8:18 ` Ming Lei
2017-07-04 7:55 ` [PATCH 3/8] nvme-loop: quiesce admin_q instead of stopping " Sagi Grimberg
2017-07-04 7:55 ` Sagi Grimberg
2017-07-04 8:23 ` Ming Lei
2017-07-04 8:23 ` Ming Lei
2017-07-04 9:24 ` Sagi Grimberg
2017-07-04 9:24 ` Sagi Grimberg
2017-07-04 10:38 ` Ming Lei
2017-07-04 7:55 ` [PATCH 4/8] nvme-pci: quiesce/unquiesce admin_q instead of start/stop its " Sagi Grimberg
2017-07-04 7:55 ` Sagi Grimberg
2017-07-04 8:26 ` Ming Lei
2017-07-04 8:26 ` Ming Lei
2017-07-04 7:55 ` [PATCH 5/8] nbd: quiesce request queues to make sure no submissions are inflight Sagi Grimberg
2017-07-04 7:55 ` Sagi Grimberg
2017-07-04 8:28 ` Ming Lei
2017-07-04 8:28 ` Ming Lei
2017-07-04 7:55 ` [PATCH 6/8] mtip32xx: " Sagi Grimberg
2017-07-04 7:55 ` Sagi Grimberg
2017-07-04 22:32 ` Ming Lei
2017-07-04 22:32 ` Ming Lei
2017-07-05 6:34 ` Sagi Grimberg
2017-07-05 6:34 ` Sagi Grimberg
2017-07-04 7:55 ` [PATCH 7/8] virtio_blk: quiesce/unquiesce live IO when entering PM states Sagi Grimberg
2017-07-04 7:55 ` Sagi Grimberg
2017-07-04 8:41 ` Ming Lei
2017-07-04 8:41 ` Ming Lei
2017-07-04 21:39 ` Michael S. Tsirkin [this message]
2017-07-04 21:39 ` Michael S. Tsirkin
2017-07-04 7:55 ` [PATCH 8/8] xen-blockfront: quiesce IO before device removal Sagi Grimberg
2017-07-04 7:55 ` Sagi Grimberg
2017-07-04 22:19 ` Ming Lei
2017-07-04 22:19 ` Ming Lei
2017-07-05 6:29 ` Sagi Grimberg
2017-07-05 6:29 ` Sagi Grimberg
2017-07-05 22:56 ` Christoph Hellwig
2017-07-05 22:56 ` Christoph Hellwig
2017-07-06 6:52 ` Sagi Grimberg
2017-07-06 6:52 ` Sagi Grimberg
2017-07-04 8:12 ` [PATCH 0/8] correct quiescing in several block drivers Ming Lei
2017-07-04 8:12 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170705003734-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=jasowang@redhat.com \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.