From: Ming Lei <ming.lei@redhat.com>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Keith Busch <keith.busch@intel.com>,
Christoph Hellwig <hch@lst.de>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH v2 2/8] nvme-fc: quiesce/unquiesce admin_q instead of start/stop its hw queues
Date: Wed, 5 Jul 2017 15:16:35 +0800 [thread overview]
Message-ID: <20170705071632.GC11084@ming.t460p> (raw)
In-Reply-To: <1499237591-15861-3-git-send-email-sagi@grimberg.me>
On Wed, Jul 05, 2017 at 09:53:05AM +0300, Sagi Grimberg wrote:
> unlike blk_mq_stop_hw_queues and blk_mq_start_stopped_hw_queues
> quiescing/unquiescing respects the submission path rcu grace.
>
> Also, make sure to unquiesce before cleanup the admin queue.
>
> Reviewed-By: James Smart <james.smart@broadcom.com>
> Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
> ---
> drivers/nvme/host/fc.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/nvme/host/fc.c b/drivers/nvme/host/fc.c
> index 50cc3b2b0e11..3e35fc622680 100644
> --- a/drivers/nvme/host/fc.c
> +++ b/drivers/nvme/host/fc.c
> @@ -1703,6 +1703,7 @@ nvme_fc_ctrl_free(struct kref *ref)
> list_del(&ctrl->ctrl_list);
> spin_unlock_irqrestore(&ctrl->rport->lock, flags);
>
> + blk_mq_unquiesce_queue(ctrl->ctrl.admin_q);
> blk_cleanup_queue(ctrl->ctrl.admin_q);
> blk_mq_free_tag_set(&ctrl->admin_tag_set);
>
> @@ -2320,8 +2321,10 @@ nvme_fc_create_association(struct nvme_fc_ctrl *ctrl)
> if (ret)
> goto out_delete_hw_queue;
>
> - if (ctrl->ctrl.state != NVME_CTRL_NEW)
> - blk_mq_start_stopped_hw_queues(ctrl->ctrl.admin_q, true);
> + if (ctrl->ctrl.state != NVME_CTRL_NEW) {
> + blk_mq_unquiesce_queue(ctrl->ctrl.admin_q);
> + blk_mq_kick_requeue_list(ctrl->ctrl.admin_q);
Same comment with patch 1
--
Ming
WARNING: multiple messages have this Message-ID (diff)
From: ming.lei@redhat.com (Ming Lei)
Subject: [PATCH v2 2/8] nvme-fc: quiesce/unquiesce admin_q instead of start/stop its hw queues
Date: Wed, 5 Jul 2017 15:16:35 +0800 [thread overview]
Message-ID: <20170705071632.GC11084@ming.t460p> (raw)
In-Reply-To: <1499237591-15861-3-git-send-email-sagi@grimberg.me>
On Wed, Jul 05, 2017@09:53:05AM +0300, Sagi Grimberg wrote:
> unlike blk_mq_stop_hw_queues and blk_mq_start_stopped_hw_queues
> quiescing/unquiescing respects the submission path rcu grace.
>
> Also, make sure to unquiesce before cleanup the admin queue.
>
> Reviewed-By: James Smart <james.smart at broadcom.com>
> Signed-off-by: Sagi Grimberg <sagi at grimberg.me>
> ---
> drivers/nvme/host/fc.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/nvme/host/fc.c b/drivers/nvme/host/fc.c
> index 50cc3b2b0e11..3e35fc622680 100644
> --- a/drivers/nvme/host/fc.c
> +++ b/drivers/nvme/host/fc.c
> @@ -1703,6 +1703,7 @@ nvme_fc_ctrl_free(struct kref *ref)
> list_del(&ctrl->ctrl_list);
> spin_unlock_irqrestore(&ctrl->rport->lock, flags);
>
> + blk_mq_unquiesce_queue(ctrl->ctrl.admin_q);
> blk_cleanup_queue(ctrl->ctrl.admin_q);
> blk_mq_free_tag_set(&ctrl->admin_tag_set);
>
> @@ -2320,8 +2321,10 @@ nvme_fc_create_association(struct nvme_fc_ctrl *ctrl)
> if (ret)
> goto out_delete_hw_queue;
>
> - if (ctrl->ctrl.state != NVME_CTRL_NEW)
> - blk_mq_start_stopped_hw_queues(ctrl->ctrl.admin_q, true);
> + if (ctrl->ctrl.state != NVME_CTRL_NEW) {
> + blk_mq_unquiesce_queue(ctrl->ctrl.admin_q);
> + blk_mq_kick_requeue_list(ctrl->ctrl.admin_q);
Same comment with patch 1
--
Ming
next prev parent reply other threads:[~2017-07-05 7:16 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-05 6:53 [PATCH v2 0/8] correct quiescing in several block drivers Sagi Grimberg
2017-07-05 6:53 ` Sagi Grimberg
2017-07-05 6:53 ` [PATCH v2 1/8] nvme-rdma: quiesce/unquiesce admin_q instead of start/stop its hw queues Sagi Grimberg
2017-07-05 6:53 ` Sagi Grimberg
2017-07-05 7:12 ` Ming Lei
2017-07-05 7:12 ` Ming Lei
2017-07-05 7:15 ` Sagi Grimberg
2017-07-05 7:15 ` Sagi Grimberg
2017-07-05 7:34 ` Ming Lei
2017-07-05 7:34 ` Ming Lei
2017-07-05 6:53 ` [PATCH v2 2/8] nvme-fc: " Sagi Grimberg
2017-07-05 6:53 ` Sagi Grimberg
2017-07-05 7:16 ` Ming Lei [this message]
2017-07-05 7:16 ` Ming Lei
2017-07-05 6:53 ` [PATCH v2 3/8] nvme-loop: " Sagi Grimberg
2017-07-05 6:53 ` Sagi Grimberg
2017-07-05 7:14 ` Ming Lei
2017-07-05 7:14 ` Ming Lei
2017-07-05 6:53 ` [PATCH v2 4/8] nvme-pci: " Sagi Grimberg
2017-07-05 6:53 ` Sagi Grimberg
2017-07-05 7:20 ` Ming Lei
2017-07-05 7:20 ` Ming Lei
2017-07-05 6:53 ` [PATCH v2 5/8] nvme: kick requeue list when requeueing a request instead of when starting the queues Sagi Grimberg
2017-07-05 6:53 ` Sagi Grimberg
2017-07-05 7:22 ` Ming Lei
2017-07-05 7:22 ` Ming Lei
2017-07-05 6:53 ` [PATCH v2 6/8] nbd: quiesce request queues to make sure no submissions are inflight Sagi Grimberg
2017-07-05 6:53 ` Sagi Grimberg
2017-07-05 6:53 ` [PATCH v2 7/8] mtip32xx: " Sagi Grimberg
2017-07-05 6:53 ` Sagi Grimberg
2017-07-05 7:28 ` Ming Lei
2017-07-05 7:28 ` Ming Lei
2017-07-05 6:53 ` [PATCH v2 8/8] virtio_blk: quiesce/unquiesce live IO when entering PM states Sagi Grimberg
2017-07-05 6:53 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170705071632.GC11084@ming.t460p \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.