From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
To: Tomasz Figa <tfiga-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Cc: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
Greg Kroah-Hartman
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Krzysztof Kozlowski
<krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
Vineet Gupta <vgupta-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>,
Hans-Christian Noren Egtvedt
<egtvedt-BrfabpQBY5qlHtIdYg32fQ@public.gmane.org>,
Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
Subject: Re: [RFC PATCH 1/5] base: dma-mapping: Export commonly used symbols
Date: Wed, 5 Jul 2017 17:17:28 +0200 [thread overview]
Message-ID: <20170705151728.GA2479@lst.de> (raw)
In-Reply-To: <20170705071215.17603-2-tfiga-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Please use EXPORT_SYMBOL_GPL for any of these exports, as they are
internal linux implementration details by any definition of it.
On Wed, Jul 05, 2017 at 04:12:11PM +0900, Tomasz Figa wrote:
> There is nothing wrong in having a loadable module implementing DMA API,
> for example to be used for sub-devices registered by the module.
> However, most of the functions from dma-mapping do not have their
> symbols exported, making it impossible to use them from loadable modules.
I'd like to see the patches for this use case as well. We don't
generally export symbols without seeing the users.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Tomasz Figa <tfiga@chromium.org>
Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@lst.de>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Robin Murphy <robin.murphy@arm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Joerg Roedel <joro@8bytes.org>, Will Deacon <will.deacon@arm.com>,
Vineet Gupta <vgupta@synopsys.com>,
Hans-Christian Noren Egtvedt <egtvedt@samfundet.no>,
Mitchel Humpherys <mitchelh@codeaurora.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [RFC PATCH 1/5] base: dma-mapping: Export commonly used symbols
Date: Wed, 5 Jul 2017 17:17:28 +0200 [thread overview]
Message-ID: <20170705151728.GA2479@lst.de> (raw)
In-Reply-To: <20170705071215.17603-2-tfiga@chromium.org>
Please use EXPORT_SYMBOL_GPL for any of these exports, as they are
internal linux implementration details by any definition of it.
On Wed, Jul 05, 2017 at 04:12:11PM +0900, Tomasz Figa wrote:
> There is nothing wrong in having a loadable module implementing DMA API,
> for example to be used for sub-devices registered by the module.
> However, most of the functions from dma-mapping do not have their
> symbols exported, making it impossible to use them from loadable modules.
I'd like to see the patches for this use case as well. We don't
generally export symbols without seeing the users.
next prev parent reply other threads:[~2017-07-05 15:17 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-05 7:12 [RFC PATCH 0/5] Fixes for loadable modules implementing DMA/IOMMU APIs Tomasz Figa
[not found] ` <20170705071215.17603-1-tfiga-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2017-07-05 7:12 ` [RFC PATCH 1/5] base: dma-mapping: Export commonly used symbols Tomasz Figa
2017-07-05 7:12 ` Tomasz Figa
[not found] ` <20170705071215.17603-2-tfiga-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2017-07-05 15:17 ` Christoph Hellwig [this message]
2017-07-05 15:17 ` Christoph Hellwig
[not found] ` <20170705151728.GA2479-jcswGhMUV9g@public.gmane.org>
2017-07-05 15:22 ` Tomasz Figa
2017-07-05 15:22 ` Tomasz Figa
[not found] ` <CAAFQd5DijKbNJ-8wHh=+2Z2y1nSF-LC8R+d+NktTRF4iQqPsrA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-07-05 17:20 ` Christoph Hellwig
2017-07-05 17:20 ` Christoph Hellwig
[not found] ` <20170705172019.GB5246-jcswGhMUV9g@public.gmane.org>
2017-07-06 1:44 ` Tomasz Figa
2017-07-06 1:44 ` Tomasz Figa
[not found] ` <CAAFQd5CkVYd6uyoFP_15N8ZaZp8jivJ-4S=CAvrTynRU2ShFYg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-07-06 8:26 ` Arnd Bergmann
2017-07-06 8:26 ` Arnd Bergmann
2017-07-06 8:34 ` Tomasz Figa
2017-07-06 8:34 ` Tomasz Figa
2017-07-06 8:36 ` Tomasz Figa
[not found] ` <CAAFQd5BFLvWS5n8owm053GNC5VniMq-8Gh0BHo43B-TYShpsnA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-07-06 12:23 ` Arnd Bergmann
2017-07-06 12:23 ` Arnd Bergmann
[not found] ` <CAK8P3a2JyQ-qLgh+ig4yWMJvB0AGjspMu8P8fNrPHgm3NMCGNw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-07-06 13:31 ` Tomasz Figa
2017-07-06 13:31 ` Tomasz Figa
2017-07-06 13:49 ` Tomasz Figa
[not found] ` <CAAFQd5Axz2yMnOo4rtP3jgEBJxUVOW0RLmFEGFejBHkYjq0s5A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-07-06 14:02 ` Arnd Bergmann
2017-07-06 14:02 ` Arnd Bergmann
2017-07-06 14:06 ` Tomasz Figa
[not found] ` <CAAFQd5BgVRaEym9fXt3sMSafFPK1cXwTdMgSiB87w8QVeXzzVw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-07-06 14:27 ` Arnd Bergmann
2017-07-06 14:27 ` Arnd Bergmann
2017-07-06 14:35 ` Tomasz Figa
[not found] ` <CAAFQd5DS1NxKh4OJ52T2AJNTHg6K2fnuDm5-GHzmUk-kjowf2w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-07-06 13:56 ` Arnd Bergmann
2017-07-06 13:56 ` Arnd Bergmann
2017-07-05 7:12 ` [RFC PATCH 2/5] base: dma-mapping: Provide a function to look up remapped pages Tomasz Figa
2017-07-05 7:12 ` Tomasz Figa
2017-07-05 7:12 ` [RFC PATCH 3/5] iommu: Export non-static functions to use in modules Tomasz Figa
2017-07-05 7:12 ` Tomasz Figa
2017-07-05 7:12 ` [RFC PATCH 4/5] iommu/dma: " Tomasz Figa
2017-07-05 7:12 ` Tomasz Figa
[not found] ` <20170705071215.17603-5-tfiga-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2017-07-05 16:22 ` Robin Murphy
2017-07-05 16:22 ` Robin Murphy
[not found] ` <d02d47f2-8e89-ddba-54d9-1d1f52ae394a-5wv7dgnIgG8@public.gmane.org>
2017-07-06 2:25 ` Tomasz Figa
2017-07-06 2:25 ` Tomasz Figa
[not found] ` <CAAFQd5C3P7Rpohq=5xoBs1mUtbQ63FbQ80-Rm08JEY-iDyipYA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-07-06 11:09 ` Robin Murphy
2017-07-06 11:09 ` Robin Murphy
[not found] ` <f66b6ebc-9977-8783-4e6a-10dcfcadf60d-5wv7dgnIgG8@public.gmane.org>
2017-07-06 14:10 ` Christoph Hellwig
2017-07-06 14:10 ` Christoph Hellwig
2017-07-06 14:17 ` Tomasz Figa
[not found] ` <CAAFQd5Af_rFDpDjRP2Vb875nPCrx+8FV6wMFDHt71YQ5BWOOSg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-07-06 14:24 ` Tomasz Figa
2017-07-06 14:24 ` Tomasz Figa
2017-07-06 14:35 ` Arnd Bergmann
2017-07-06 14:41 ` Tomasz Figa
2017-07-05 7:12 ` [RFC PATCH 5/5] iommu/dma: Add iommu_dma_cleanup() Tomasz Figa
2017-07-05 7:12 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170705151728.GA2479@lst.de \
--to=hch-jcswghmuv9g@public.gmane.org \
--cc=arnd-r2nGTMty4D4@public.gmane.org \
--cc=egtvedt-BrfabpQBY5qlHtIdYg32fQ@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=tfiga-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=vgupta-HKixBCOQz3hWk0Htik3J/w@public.gmane.org \
--cc=will.deacon-5wv7dgnIgG8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.