From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Olliver Schinagl <o.schinagl@ultimaker.com>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Chen-Yu Tsai <wens@csie.org>, Jonathan Liu <net147@gmail.com>,
linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/3] pwm: sun4i: switch to atomic PWM
Date: Thu, 6 Jul 2017 09:02:10 +0200 [thread overview]
Message-ID: <20170706090210.3bbfd3e6@bbrezillon> (raw)
In-Reply-To: <20170706070016.asujxs3ibkqq6jzj@piout.net>
On Thu, 6 Jul 2017 09:00:16 +0200
Alexandre Belloni <alexandre.belloni@free-electrons.com> wrote:
> On 06/07/2017 at 08:49:22 +0200, Thierry Reding wrote:
> > On Tue, May 30, 2017 at 09:32:06PM +0200, Alexandre Belloni wrote:
> > > Switch to atomic PWM. The main goal is to properly wait for a period before
> > > disabling a channel to ensure the correct level is set on the output.
> > >
> > > Changes in v2:
> > > - fixed remaining checkpatch warnings
> > > - split the series to ease reviews
> > > - changed the delay handling to ensure the proper amount of time has elapsed
> > > before disabling a channel
> > > - dropped RDY bit handling as it doesn't have any real effect.
> > >
> > > Alexandre Belloni (3):
> > > pwm: sun4i: improve hardware read out
> > > pwm: sun4i: switch to atomic PWM
> > > pwm: sun4i: drop legacy callbacks
> > >
> > > drivers/pwm/pwm-sun4i.c | 263 +++++++++++++++++++++++++++---------------------
> > > 1 file changed, 148 insertions(+), 115 deletions(-)
> >
> > Series applied, though you could've just squashed together patches 2 and
> > 3 because they don't make sense apart.
> >
>
> Ok, thanks. IIRC, Boris suggested the split ;)
Yes, I did it because the diff was really hard to review.
WARNING: multiple messages have this Message-ID (diff)
From: boris.brezillon@free-electrons.com (Boris Brezillon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 0/3] pwm: sun4i: switch to atomic PWM
Date: Thu, 6 Jul 2017 09:02:10 +0200 [thread overview]
Message-ID: <20170706090210.3bbfd3e6@bbrezillon> (raw)
In-Reply-To: <20170706070016.asujxs3ibkqq6jzj@piout.net>
On Thu, 6 Jul 2017 09:00:16 +0200
Alexandre Belloni <alexandre.belloni@free-electrons.com> wrote:
> On 06/07/2017 at 08:49:22 +0200, Thierry Reding wrote:
> > On Tue, May 30, 2017 at 09:32:06PM +0200, Alexandre Belloni wrote:
> > > Switch to atomic PWM. The main goal is to properly wait for a period before
> > > disabling a channel to ensure the correct level is set on the output.
> > >
> > > Changes in v2:
> > > - fixed remaining checkpatch warnings
> > > - split the series to ease reviews
> > > - changed the delay handling to ensure the proper amount of time has elapsed
> > > before disabling a channel
> > > - dropped RDY bit handling as it doesn't have any real effect.
> > >
> > > Alexandre Belloni (3):
> > > pwm: sun4i: improve hardware read out
> > > pwm: sun4i: switch to atomic PWM
> > > pwm: sun4i: drop legacy callbacks
> > >
> > > drivers/pwm/pwm-sun4i.c | 263 +++++++++++++++++++++++++++---------------------
> > > 1 file changed, 148 insertions(+), 115 deletions(-)
> >
> > Series applied, though you could've just squashed together patches 2 and
> > 3 because they don't make sense apart.
> >
>
> Ok, thanks. IIRC, Boris suggested the split ;)
Yes, I did it because the diff was really hard to review.
next prev parent reply other threads:[~2017-07-06 7:02 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-30 19:32 [PATCH v2 0/3] pwm: sun4i: switch to atomic PWM Alexandre Belloni
2017-05-30 19:32 ` Alexandre Belloni
2017-05-30 19:32 ` [PATCH v2 1/3] pwm: sun4i: improve hardware read out Alexandre Belloni
2017-05-30 19:32 ` Alexandre Belloni
2017-05-31 3:34 ` Chen-Yu Tsai
2017-05-31 3:34 ` Chen-Yu Tsai
2017-05-31 7:35 ` Alexandre Belloni
2017-05-31 7:35 ` Alexandre Belloni
2017-05-31 14:13 ` Chen-Yu Tsai
2017-05-31 14:13 ` Chen-Yu Tsai
2017-05-30 19:32 ` [PATCH v2 2/3] pwm: sun4i: switch to atomic PWM Alexandre Belloni
2017-05-30 19:32 ` Alexandre Belloni
2017-05-30 19:32 ` [PATCH v2 3/3] pwm: sun4i: drop legacy callbacks Alexandre Belloni
2017-05-30 19:32 ` Alexandre Belloni
2017-06-09 16:22 ` Chen-Yu Tsai
2017-06-09 16:22 ` Chen-Yu Tsai
2017-05-31 6:13 ` [PATCH v2 0/3] pwm: sun4i: switch to atomic PWM Maxime Ripard
2017-05-31 6:13 ` Maxime Ripard
2017-07-06 6:49 ` Thierry Reding
2017-07-06 6:49 ` Thierry Reding
2017-07-06 7:00 ` Alexandre Belloni
2017-07-06 7:00 ` Alexandre Belloni
2017-07-06 7:02 ` Boris Brezillon [this message]
2017-07-06 7:02 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170706090210.3bbfd3e6@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=net147@gmail.com \
--cc=o.schinagl@ultimaker.com \
--cc=thierry.reding@gmail.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.