From: Roland Kammerer <roland.kammerer@linbit.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Lars Ellenberg <lars.ellenberg@linbit.com>,
drbd-dev@lists.linbit.com,
Philipp Reisner <philipp.reisner@linbit.com>,
linux-kernel@vger.kernel.org
Subject: Re: [Drbd-dev] [PATCH] drbd: rename "usermode_helper" to "drbd_usermode_helper"
Date: Thu, 6 Jul 2017 19:56:07 +0200 [thread overview]
Message-ID: <20170706175607.GE1453@rck.sh> (raw)
In-Reply-To: <20170605092623.GA20170@kroah.com>
On Mon, Jun 05, 2017 at 11:26:23AM +0200, Greg KH wrote:
> From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> Nothing like having a very generic global variable in a tiny driver
> subsystem to make a mess of the global namespace...
Thanks for the patch. As this did not happen magically in mainline, I
queued it up in our out-of-tree repo.
>
> Note, there are many other "generic" named global variables in the drbd
> subsystem, someone should fix those up one day before they hit a linking
> error.
Did that as well.
Both should hit some merge-window soon.
Thanks, rck
--
Roland Kammerer
roland.kammerer@linbit.com
LINBIT | Keeping the Digital World Running
DRBD – Corosync – Pacemaker
WARNING: multiple messages have this Message-ID (diff)
From: Roland Kammerer <roland.kammerer@linbit.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Philipp Reisner <philipp.reisner@linbit.com>,
Lars Ellenberg <lars.ellenberg@linbit.com>,
linux-kernel@vger.kernel.org, drbd-dev@lists.linbit.com
Subject: Re: [Drbd-dev] [PATCH] drbd: rename "usermode_helper" to "drbd_usermode_helper"
Date: Thu, 6 Jul 2017 19:56:07 +0200 [thread overview]
Message-ID: <20170706175607.GE1453@rck.sh> (raw)
In-Reply-To: <20170605092623.GA20170@kroah.com>
On Mon, Jun 05, 2017 at 11:26:23AM +0200, Greg KH wrote:
> From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> Nothing like having a very generic global variable in a tiny driver
> subsystem to make a mess of the global namespace...
Thanks for the patch. As this did not happen magically in mainline, I
queued it up in our out-of-tree repo.
>
> Note, there are many other "generic" named global variables in the drbd
> subsystem, someone should fix those up one day before they hit a linking
> error.
Did that as well.
Both should hit some merge-window soon.
Thanks, rck
--
Roland Kammerer
roland.kammerer@linbit.com
LINBIT | Keeping the Digital World Running
DRBD – Corosync – Pacemaker
next prev parent reply other threads:[~2017-07-06 18:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-05 9:26 [Drbd-dev] [PATCH] drbd: rename "usermode_helper" to "drbd_usermode_helper" Greg KH
2017-06-05 9:26 ` Greg KH
2017-06-08 12:50 ` [Drbd-dev] " Lars Ellenberg
2017-06-08 12:50 ` Lars Ellenberg
2017-07-06 17:56 ` Roland Kammerer [this message]
2017-07-06 17:56 ` [Drbd-dev] " Roland Kammerer
2017-07-06 18:02 ` Greg KH
2017-07-06 19:19 ` Roland Kammerer
2017-07-06 19:19 ` Roland Kammerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170706175607.GE1453@rck.sh \
--to=roland.kammerer@linbit.com \
--cc=drbd-dev@lists.linbit.com \
--cc=gregkh@linuxfoundation.org \
--cc=lars.ellenberg@linbit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=philipp.reisner@linbit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.