From: clabbe.montjoie@gmail.com (Corentin Labbe)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: sunxi: h3/h5: Correct emac register size
Date: Thu, 6 Jul 2017 21:05:41 +0200 [thread overview]
Message-ID: <20170706190541.GA28678@Red> (raw)
In-Reply-To: <20170706185205.f4jwskpnz4d3udvv@flea>
On Thu, Jul 06, 2017 at 08:52:05PM +0200, Maxime Ripard wrote:
> On Thu, Jul 06, 2017 at 10:53:34AM +0200, Corentin Labbe wrote:
> > The datasheet said that emac register size is 0x1000 not 0x104
> >
> > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> > ---
> > arch/arm/boot/dts/sunxi-h3-h5.dtsi | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/sunxi-h3-h5.dtsi b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> > index 716e7d668dec..5a57b67c9b77 100644
> > --- a/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> > +++ b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> > @@ -406,7 +406,7 @@
> > emac: ethernet at 1c30000 {
> > compatible = "allwinner,sun8i-h3-emac";
> > syscon = <&syscon>;
> > - reg = <0x01c30000 0x104>;
> > + reg = <0x01c30000 0x1000>;
>
> The size is actually 0x10000. I fixed it and applied.
>
> The A64 DTSI has the same issue, can you send a patch for this one
> too?
>
Yes
Thanks for the fixing
Regards
Corentin Labbe
WARNING: multiple messages have this Message-ID (diff)
From: Corentin Labbe <clabbe.montjoie@gmail.com>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk,
wens@csie.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: sunxi: h3/h5: Correct emac register size
Date: Thu, 6 Jul 2017 21:05:41 +0200 [thread overview]
Message-ID: <20170706190541.GA28678@Red> (raw)
In-Reply-To: <20170706185205.f4jwskpnz4d3udvv@flea>
On Thu, Jul 06, 2017 at 08:52:05PM +0200, Maxime Ripard wrote:
> On Thu, Jul 06, 2017 at 10:53:34AM +0200, Corentin Labbe wrote:
> > The datasheet said that emac register size is 0x1000 not 0x104
> >
> > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> > ---
> > arch/arm/boot/dts/sunxi-h3-h5.dtsi | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/sunxi-h3-h5.dtsi b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> > index 716e7d668dec..5a57b67c9b77 100644
> > --- a/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> > +++ b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> > @@ -406,7 +406,7 @@
> > emac: ethernet@1c30000 {
> > compatible = "allwinner,sun8i-h3-emac";
> > syscon = <&syscon>;
> > - reg = <0x01c30000 0x104>;
> > + reg = <0x01c30000 0x1000>;
>
> The size is actually 0x10000. I fixed it and applied.
>
> The A64 DTSI has the same issue, can you send a patch for this one
> too?
>
Yes
Thanks for the fixing
Regards
Corentin Labbe
next prev parent reply other threads:[~2017-07-06 19:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-06 8:53 [PATCH] ARM: sunxi: h3/h5: Correct emac register size Corentin Labbe
2017-07-06 8:53 ` Corentin Labbe
2017-07-06 8:53 ` Corentin Labbe
2017-07-06 18:52 ` Maxime Ripard
2017-07-06 18:52 ` Maxime Ripard
2017-07-06 19:05 ` Corentin Labbe [this message]
2017-07-06 19:05 ` Corentin Labbe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170706190541.GA28678@Red \
--to=clabbe.montjoie@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.