* [PATCH] fpga: altera-hps2fpga: add NULL check on of_match_device() return value
@ 2017-07-07 6:22 Gustavo A. R. Silva
2017-07-10 15:17 ` Alan Tull
2017-07-10 16:25 ` Moritz Fischer
0 siblings, 2 replies; 5+ messages in thread
From: Gustavo A. R. Silva @ 2017-07-07 6:22 UTC (permalink / raw)
To: Alan Tull, Moritz Fischer; +Cc: linux-fpga, linux-kernel, Gustavo A. R. Silva
Check return value from call to of_match_device()
in order to prevent a NULL pointer dereference.
In case of NULL print error message and return -ENODEV
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
drivers/fpga/altera-hps2fpga.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/fpga/altera-hps2fpga.c b/drivers/fpga/altera-hps2fpga.c
index 3066b80..ca8212c 100644
--- a/drivers/fpga/altera-hps2fpga.c
+++ b/drivers/fpga/altera-hps2fpga.c
@@ -143,6 +143,11 @@ static int alt_fpga_bridge_probe(struct platform_device *pdev)
int ret;
of_id = of_match_device(altera_fpga_of_match, dev);
+ if (!of_id) {
+ dev_err(dev, "failed to match device\n");
+ return -ENODEV;
+ }
+
priv = (struct altera_hps2fpga_data *)of_id->data;
priv->bridge_reset = of_reset_control_get_by_index(dev->of_node, 0);
--
2.5.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] fpga: altera-hps2fpga: add NULL check on of_match_device() return value
2017-07-07 6:22 [PATCH] fpga: altera-hps2fpga: add NULL check on of_match_device() return value Gustavo A. R. Silva
@ 2017-07-10 15:17 ` Alan Tull
2017-07-10 15:25 ` Gustavo A. R. Silva
2017-07-10 16:25 ` Moritz Fischer
1 sibling, 1 reply; 5+ messages in thread
From: Alan Tull @ 2017-07-10 15:17 UTC (permalink / raw)
To: Gustavo A. R. Silva; +Cc: Moritz Fischer, linux-fpga, linux-kernel
On Fri, Jul 7, 2017 at 1:22 AM, Gustavo A. R. Silva
Hi Gustavo,
Thanks for the fix!
Alan
<garsilva@embeddedor.com> wrote:
> Check return value from call to of_match_device()
> in order to prevent a NULL pointer dereference.
>
> In case of NULL print error message and return -ENODEV
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Acked-by: Alan Tull <atull@kernel.org>
> ---
> drivers/fpga/altera-hps2fpga.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/fpga/altera-hps2fpga.c b/drivers/fpga/altera-hps2fpga.c
> index 3066b80..ca8212c 100644
> --- a/drivers/fpga/altera-hps2fpga.c
> +++ b/drivers/fpga/altera-hps2fpga.c
> @@ -143,6 +143,11 @@ static int alt_fpga_bridge_probe(struct platform_device *pdev)
> int ret;
>
> of_id = of_match_device(altera_fpga_of_match, dev);
> + if (!of_id) {
> + dev_err(dev, "failed to match device\n");
> + return -ENODEV;
> + }
> +
> priv = (struct altera_hps2fpga_data *)of_id->data;
>
> priv->bridge_reset = of_reset_control_get_by_index(dev->of_node, 0);
> --
> 2.5.0
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] fpga: altera-hps2fpga: add NULL check on of_match_device() return value
2017-07-10 15:17 ` Alan Tull
@ 2017-07-10 15:25 ` Gustavo A. R. Silva
0 siblings, 0 replies; 5+ messages in thread
From: Gustavo A. R. Silva @ 2017-07-10 15:25 UTC (permalink / raw)
To: Alan Tull; +Cc: Moritz Fischer, linux-fpga, linux-kernel
Hi Alan,
Quoting Alan Tull <atull@kernel.org>:
> On Fri, Jul 7, 2017 at 1:22 AM, Gustavo A. R. Silva
>
> Hi Gustavo,
>
> Thanks for the fix!
>
Absolutely, glad to help. :)
> Alan
>
> <garsilva@embeddedor.com> wrote:
>> Check return value from call to of_match_device()
>> in order to prevent a NULL pointer dereference.
>>
>> In case of NULL print error message and return -ENODEV
>>
>> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
>
> Acked-by: Alan Tull <atull@kernel.org>
>
>> ---
>> drivers/fpga/altera-hps2fpga.c | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/drivers/fpga/altera-hps2fpga.c b/drivers/fpga/altera-hps2fpga.c
>> index 3066b80..ca8212c 100644
>> --- a/drivers/fpga/altera-hps2fpga.c
>> +++ b/drivers/fpga/altera-hps2fpga.c
>> @@ -143,6 +143,11 @@ static int alt_fpga_bridge_probe(struct
>> platform_device *pdev)
>> int ret;
>>
>> of_id = of_match_device(altera_fpga_of_match, dev);
>> + if (!of_id) {
>> + dev_err(dev, "failed to match device\n");
>> + return -ENODEV;
>> + }
>> +
>> priv = (struct altera_hps2fpga_data *)of_id->data;
>>
>> priv->bridge_reset = of_reset_control_get_by_index(dev->of_node, 0);
>> --
>> 2.5.0
>>
--
Gustavo A. R. Silva
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] fpga: altera-hps2fpga: add NULL check on of_match_device() return value
2017-07-07 6:22 [PATCH] fpga: altera-hps2fpga: add NULL check on of_match_device() return value Gustavo A. R. Silva
2017-07-10 15:17 ` Alan Tull
@ 2017-07-10 16:25 ` Moritz Fischer
2017-07-17 4:58 ` Gustavo A. R. Silva
1 sibling, 1 reply; 5+ messages in thread
From: Moritz Fischer @ 2017-07-10 16:25 UTC (permalink / raw)
To: Gustavo A. R. Silva; +Cc: Alan Tull, linux-fpga, Linux Kernel Mailing List
On Thu, Jul 6, 2017 at 11:22 PM, Gustavo A. R. Silva
<garsilva@embeddedor.com> wrote:
> Check return value from call to of_match_device()
> in order to prevent a NULL pointer dereference.
>
> In case of NULL print error message and return -ENODEV
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Reviewed-by: Moritz Fischer <mdf@kernel.org>
> ---
> drivers/fpga/altera-hps2fpga.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/fpga/altera-hps2fpga.c b/drivers/fpga/altera-hps2fpga.c
> index 3066b80..ca8212c 100644
> --- a/drivers/fpga/altera-hps2fpga.c
> +++ b/drivers/fpga/altera-hps2fpga.c
> @@ -143,6 +143,11 @@ static int alt_fpga_bridge_probe(struct platform_device *pdev)
> int ret;
>
> of_id = of_match_device(altera_fpga_of_match, dev);
> + if (!of_id) {
> + dev_err(dev, "failed to match device\n");
> + return -ENODEV;
> + }
> +
> priv = (struct altera_hps2fpga_data *)of_id->data;
>
> priv->bridge_reset = of_reset_control_get_by_index(dev->of_node, 0);
> --
> 2.5.0
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] fpga: altera-hps2fpga: add NULL check on of_match_device() return value
2017-07-10 16:25 ` Moritz Fischer
@ 2017-07-17 4:58 ` Gustavo A. R. Silva
0 siblings, 0 replies; 5+ messages in thread
From: Gustavo A. R. Silva @ 2017-07-17 4:58 UTC (permalink / raw)
To: Moritz Fischer; +Cc: Alan Tull, linux-fpga, Linux Kernel Mailing List
On 07/10/2017 11:25 AM, Moritz Fischer wrote:
> On Thu, Jul 6, 2017 at 11:22 PM, Gustavo A. R. Silva
> <garsilva@embeddedor.com> wrote:
>> Check return value from call to of_match_device()
>> in order to prevent a NULL pointer dereference.
>>
>> In case of NULL print error message and return -ENODEV
>>
>> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> Reviewed-by: Moritz Fischer <mdf@kernel.org>
Thank you, Moritz.
>> ---
>> drivers/fpga/altera-hps2fpga.c | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/drivers/fpga/altera-hps2fpga.c b/drivers/fpga/altera-hps2fpga.c
>> index 3066b80..ca8212c 100644
>> --- a/drivers/fpga/altera-hps2fpga.c
>> +++ b/drivers/fpga/altera-hps2fpga.c
>> @@ -143,6 +143,11 @@ static int alt_fpga_bridge_probe(struct platform_device *pdev)
>> int ret;
>>
>> of_id = of_match_device(altera_fpga_of_match, dev);
>> + if (!of_id) {
>> + dev_err(dev, "failed to match device\n");
>> + return -ENODEV;
>> + }
>> +
>> priv = (struct altera_hps2fpga_data *)of_id->data;
>>
>> priv->bridge_reset = of_reset_control_get_by_index(dev->of_node, 0);
>> --
>> 2.5.0
>>
--
Gustavo A. R. Silva
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-07-17 4:58 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-07 6:22 [PATCH] fpga: altera-hps2fpga: add NULL check on of_match_device() return value Gustavo A. R. Silva
2017-07-10 15:17 ` Alan Tull
2017-07-10 15:25 ` Gustavo A. R. Silva
2017-07-10 16:25 ` Moritz Fischer
2017-07-17 4:58 ` Gustavo A. R. Silva
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.