* [PATCH] iio: adc: meson-saradc: add NULL check on of_match_device() return value
@ 2017-07-07 6:46 ` Gustavo A. R. Silva
0 siblings, 0 replies; 15+ messages in thread
From: Gustavo A. R. Silva @ 2017-07-07 6:46 UTC (permalink / raw)
To: linus-amlogic
Check return value from call to of_match_device()
in order to prevent a NULL pointer dereference.
In case of NULL print error message and return -ENODEV
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
drivers/iio/adc/meson_saradc.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/iio/adc/meson_saradc.c b/drivers/iio/adc/meson_saradc.c
index 83da50e..07dbcc3 100644
--- a/drivers/iio/adc/meson_saradc.c
+++ b/drivers/iio/adc/meson_saradc.c
@@ -915,6 +915,11 @@ static int meson_sar_adc_probe(struct platform_device *pdev)
init_completion(&priv->done);
match = of_match_device(meson_sar_adc_of_match, &pdev->dev);
+ if (!match) {
+ dev_err(&pdev->dev, "failed to match device\n");
+ return -ENODEV;
+ }
+
priv->data = match->data;
indio_dev->name = priv->data->name;
--
2.5.0
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH] iio: adc: meson-saradc: add NULL check on of_match_device() return value
@ 2017-07-07 6:46 ` Gustavo A. R. Silva
0 siblings, 0 replies; 15+ messages in thread
From: Gustavo A. R. Silva @ 2017-07-07 6:46 UTC (permalink / raw)
To: Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, Carlo Caione, Kevin Hilman
Cc: linux-iio, linux-arm-kernel, linux-amlogic, linux-kernel,
Gustavo A. R. Silva
Check return value from call to of_match_device()
in order to prevent a NULL pointer dereference.
In case of NULL print error message and return -ENODEV
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
drivers/iio/adc/meson_saradc.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/iio/adc/meson_saradc.c b/drivers/iio/adc/meson_saradc.c
index 83da50e..07dbcc3 100644
--- a/drivers/iio/adc/meson_saradc.c
+++ b/drivers/iio/adc/meson_saradc.c
@@ -915,6 +915,11 @@ static int meson_sar_adc_probe(struct platform_device *pdev)
init_completion(&priv->done);
match = of_match_device(meson_sar_adc_of_match, &pdev->dev);
+ if (!match) {
+ dev_err(&pdev->dev, "failed to match device\n");
+ return -ENODEV;
+ }
+
priv->data = match->data;
indio_dev->name = priv->data->name;
--
2.5.0
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH] iio: adc: meson-saradc: add NULL check on of_match_device() return value
@ 2017-07-07 6:46 ` Gustavo A. R. Silva
0 siblings, 0 replies; 15+ messages in thread
From: Gustavo A. R. Silva @ 2017-07-07 6:46 UTC (permalink / raw)
To: linux-arm-kernel
Check return value from call to of_match_device()
in order to prevent a NULL pointer dereference.
In case of NULL print error message and return -ENODEV
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
drivers/iio/adc/meson_saradc.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/iio/adc/meson_saradc.c b/drivers/iio/adc/meson_saradc.c
index 83da50e..07dbcc3 100644
--- a/drivers/iio/adc/meson_saradc.c
+++ b/drivers/iio/adc/meson_saradc.c
@@ -915,6 +915,11 @@ static int meson_sar_adc_probe(struct platform_device *pdev)
init_completion(&priv->done);
match = of_match_device(meson_sar_adc_of_match, &pdev->dev);
+ if (!match) {
+ dev_err(&pdev->dev, "failed to match device\n");
+ return -ENODEV;
+ }
+
priv->data = match->data;
indio_dev->name = priv->data->name;
--
2.5.0
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH] iio: adc: meson-saradc: add NULL check on of_match_device() return value
2017-07-07 6:46 ` Gustavo A. R. Silva
(?)
@ 2017-07-08 13:42 ` Martin Blumenstingl
-1 siblings, 0 replies; 15+ messages in thread
From: Martin Blumenstingl @ 2017-07-08 13:42 UTC (permalink / raw)
To: linus-amlogic
On Fri, Jul 7, 2017 at 8:46 AM, Gustavo A. R. Silva
<garsilva@embeddedor.com> wrote:
> Check return value from call to of_match_device()
> in order to prevent a NULL pointer dereference.
>
> In case of NULL print error message and return -ENODEV
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
thanks for finding this. a crash here is a rather theoretical problem
(since all compatible strings have their corresponding match data) -
but it doesn't hurt either, so:
Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> drivers/iio/adc/meson_saradc.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/iio/adc/meson_saradc.c b/drivers/iio/adc/meson_saradc.c
> index 83da50e..07dbcc3 100644
> --- a/drivers/iio/adc/meson_saradc.c
> +++ b/drivers/iio/adc/meson_saradc.c
> @@ -915,6 +915,11 @@ static int meson_sar_adc_probe(struct platform_device *pdev)
> init_completion(&priv->done);
>
> match = of_match_device(meson_sar_adc_of_match, &pdev->dev);
> + if (!match) {
> + dev_err(&pdev->dev, "failed to match device\n");
> + return -ENODEV;
> + }
> +
> priv->data = match->data;
>
> indio_dev->name = priv->data->name;
> --
> 2.5.0
>
>
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] iio: adc: meson-saradc: add NULL check on of_match_device() return value
@ 2017-07-08 13:42 ` Martin Blumenstingl
0 siblings, 0 replies; 15+ messages in thread
From: Martin Blumenstingl @ 2017-07-08 13:42 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, Carlo Caione, Kevin Hilman, linux-iio,
linux-amlogic, linux-kernel, linux-arm-kernel
On Fri, Jul 7, 2017 at 8:46 AM, Gustavo A. R. Silva
<garsilva@embeddedor.com> wrote:
> Check return value from call to of_match_device()
> in order to prevent a NULL pointer dereference.
>
> In case of NULL print error message and return -ENODEV
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
thanks for finding this. a crash here is a rather theoretical problem
(since all compatible strings have their corresponding match data) -
but it doesn't hurt either, so:
Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> drivers/iio/adc/meson_saradc.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/iio/adc/meson_saradc.c b/drivers/iio/adc/meson_saradc.c
> index 83da50e..07dbcc3 100644
> --- a/drivers/iio/adc/meson_saradc.c
> +++ b/drivers/iio/adc/meson_saradc.c
> @@ -915,6 +915,11 @@ static int meson_sar_adc_probe(struct platform_device *pdev)
> init_completion(&priv->done);
>
> match = of_match_device(meson_sar_adc_of_match, &pdev->dev);
> + if (!match) {
> + dev_err(&pdev->dev, "failed to match device\n");
> + return -ENODEV;
> + }
> +
> priv->data = match->data;
>
> indio_dev->name = priv->data->name;
> --
> 2.5.0
>
>
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH] iio: adc: meson-saradc: add NULL check on of_match_device() return value
@ 2017-07-08 13:42 ` Martin Blumenstingl
0 siblings, 0 replies; 15+ messages in thread
From: Martin Blumenstingl @ 2017-07-08 13:42 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Jul 7, 2017 at 8:46 AM, Gustavo A. R. Silva
<garsilva@embeddedor.com> wrote:
> Check return value from call to of_match_device()
> in order to prevent a NULL pointer dereference.
>
> In case of NULL print error message and return -ENODEV
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
thanks for finding this. a crash here is a rather theoretical problem
(since all compatible strings have their corresponding match data) -
but it doesn't hurt either, so:
Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> drivers/iio/adc/meson_saradc.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/iio/adc/meson_saradc.c b/drivers/iio/adc/meson_saradc.c
> index 83da50e..07dbcc3 100644
> --- a/drivers/iio/adc/meson_saradc.c
> +++ b/drivers/iio/adc/meson_saradc.c
> @@ -915,6 +915,11 @@ static int meson_sar_adc_probe(struct platform_device *pdev)
> init_completion(&priv->done);
>
> match = of_match_device(meson_sar_adc_of_match, &pdev->dev);
> + if (!match) {
> + dev_err(&pdev->dev, "failed to match device\n");
> + return -ENODEV;
> + }
> +
> priv->data = match->data;
>
> indio_dev->name = priv->data->name;
> --
> 2.5.0
>
>
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH] iio: adc: meson-saradc: add NULL check on of_match_device() return value
2017-07-08 13:42 ` Martin Blumenstingl
(?)
@ 2017-07-09 18:08 ` Jonathan Cameron
-1 siblings, 0 replies; 15+ messages in thread
From: Jonathan Cameron @ 2017-07-09 18:08 UTC (permalink / raw)
To: linus-amlogic
On Sat, 8 Jul 2017 15:42:46 +0200
Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote:
> On Fri, Jul 7, 2017 at 8:46 AM, Gustavo A. R. Silva
> <garsilva@embeddedor.com> wrote:
> > Check return value from call to of_match_device()
> > in order to prevent a NULL pointer dereference.
> >
> > In case of NULL print error message and return -ENODEV
> >
> > Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> thanks for finding this. a crash here is a rather theoretical problem
> (since all compatible strings have their corresponding match data) -
> but it doesn't hurt either, so:
>
> Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Applied.
Jonathan
>
>
> > ---
> > drivers/iio/adc/meson_saradc.c | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/drivers/iio/adc/meson_saradc.c b/drivers/iio/adc/meson_saradc.c
> > index 83da50e..07dbcc3 100644
> > --- a/drivers/iio/adc/meson_saradc.c
> > +++ b/drivers/iio/adc/meson_saradc.c
> > @@ -915,6 +915,11 @@ static int meson_sar_adc_probe(struct platform_device *pdev)
> > init_completion(&priv->done);
> >
> > match = of_match_device(meson_sar_adc_of_match, &pdev->dev);
> > + if (!match) {
> > + dev_err(&pdev->dev, "failed to match device\n");
> > + return -ENODEV;
> > + }
> > +
> > priv->data = match->data;
> >
> > indio_dev->name = priv->data->name;
> > --
> > 2.5.0
> >
> >
> > _______________________________________________
> > linux-amlogic mailing list
> > linux-amlogic at lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-amlogic
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] iio: adc: meson-saradc: add NULL check on of_match_device() return value
@ 2017-07-09 18:08 ` Jonathan Cameron
0 siblings, 0 replies; 15+ messages in thread
From: Jonathan Cameron @ 2017-07-09 18:08 UTC (permalink / raw)
To: Martin Blumenstingl
Cc: Gustavo A. R. Silva, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, Carlo Caione, Kevin Hilman, linux-iio,
linux-amlogic, linux-kernel, linux-arm-kernel
On Sat, 8 Jul 2017 15:42:46 +0200
Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote:
> On Fri, Jul 7, 2017 at 8:46 AM, Gustavo A. R. Silva
> <garsilva@embeddedor.com> wrote:
> > Check return value from call to of_match_device()
> > in order to prevent a NULL pointer dereference.
> >
> > In case of NULL print error message and return -ENODEV
> >
> > Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> thanks for finding this. a crash here is a rather theoretical problem
> (since all compatible strings have their corresponding match data) -
> but it doesn't hurt either, so:
>
> Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Applied.
Jonathan
>
>
> > ---
> > drivers/iio/adc/meson_saradc.c | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/drivers/iio/adc/meson_saradc.c b/drivers/iio/adc/meson_saradc.c
> > index 83da50e..07dbcc3 100644
> > --- a/drivers/iio/adc/meson_saradc.c
> > +++ b/drivers/iio/adc/meson_saradc.c
> > @@ -915,6 +915,11 @@ static int meson_sar_adc_probe(struct platform_device *pdev)
> > init_completion(&priv->done);
> >
> > match = of_match_device(meson_sar_adc_of_match, &pdev->dev);
> > + if (!match) {
> > + dev_err(&pdev->dev, "failed to match device\n");
> > + return -ENODEV;
> > + }
> > +
> > priv->data = match->data;
> >
> > indio_dev->name = priv->data->name;
> > --
> > 2.5.0
> >
> >
> > _______________________________________________
> > linux-amlogic mailing list
> > linux-amlogic@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-amlogic
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH] iio: adc: meson-saradc: add NULL check on of_match_device() return value
@ 2017-07-09 18:08 ` Jonathan Cameron
0 siblings, 0 replies; 15+ messages in thread
From: Jonathan Cameron @ 2017-07-09 18:08 UTC (permalink / raw)
To: linux-arm-kernel
On Sat, 8 Jul 2017 15:42:46 +0200
Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote:
> On Fri, Jul 7, 2017 at 8:46 AM, Gustavo A. R. Silva
> <garsilva@embeddedor.com> wrote:
> > Check return value from call to of_match_device()
> > in order to prevent a NULL pointer dereference.
> >
> > In case of NULL print error message and return -ENODEV
> >
> > Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> thanks for finding this. a crash here is a rather theoretical problem
> (since all compatible strings have their corresponding match data) -
> but it doesn't hurt either, so:
>
> Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Applied.
Jonathan
>
>
> > ---
> > drivers/iio/adc/meson_saradc.c | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/drivers/iio/adc/meson_saradc.c b/drivers/iio/adc/meson_saradc.c
> > index 83da50e..07dbcc3 100644
> > --- a/drivers/iio/adc/meson_saradc.c
> > +++ b/drivers/iio/adc/meson_saradc.c
> > @@ -915,6 +915,11 @@ static int meson_sar_adc_probe(struct platform_device *pdev)
> > init_completion(&priv->done);
> >
> > match = of_match_device(meson_sar_adc_of_match, &pdev->dev);
> > + if (!match) {
> > + dev_err(&pdev->dev, "failed to match device\n");
> > + return -ENODEV;
> > + }
> > +
> > priv->data = match->data;
> >
> > indio_dev->name = priv->data->name;
> > --
> > 2.5.0
> >
> >
> > _______________________________________________
> > linux-amlogic mailing list
> > linux-amlogic at lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-amlogic
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH] iio: adc: meson-saradc: add NULL check on of_match_device() return value
2017-07-08 13:42 ` Martin Blumenstingl
(?)
@ 2017-07-10 19:40 ` Gustavo A. R. Silva
-1 siblings, 0 replies; 15+ messages in thread
From: Gustavo A. R. Silva @ 2017-07-10 19:40 UTC (permalink / raw)
To: linus-amlogic
Hi Martin,
Quoting Martin Blumenstingl <martin.blumenstingl@googlemail.com>:
> On Fri, Jul 7, 2017 at 8:46 AM, Gustavo A. R. Silva
> <garsilva@embeddedor.com> wrote:
>> Check return value from call to of_match_device()
>> in order to prevent a NULL pointer dereference.
>>
>> In case of NULL print error message and return -ENODEV
>>
>> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> thanks for finding this. a crash here is a rather theoretical problem
> (since all compatible strings have their corresponding match data) -
> but it doesn't hurt either, so:
>
I get it, glad to help. :)
> Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>
>
>> ---
>> drivers/iio/adc/meson_saradc.c | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/drivers/iio/adc/meson_saradc.c b/drivers/iio/adc/meson_saradc.c
>> index 83da50e..07dbcc3 100644
>> --- a/drivers/iio/adc/meson_saradc.c
>> +++ b/drivers/iio/adc/meson_saradc.c
>> @@ -915,6 +915,11 @@ static int meson_sar_adc_probe(struct
>> platform_device *pdev)
>> init_completion(&priv->done);
>>
>> match = of_match_device(meson_sar_adc_of_match, &pdev->dev);
>> + if (!match) {
>> + dev_err(&pdev->dev, "failed to match device\n");
>> + return -ENODEV;
>> + }
>> +
>> priv->data = match->data;
>>
>> indio_dev->name = priv->data->name;
>> --
>> 2.5.0
>>
>>
>> _______________________________________________
>> linux-amlogic mailing list
>> linux-amlogic at lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-amlogic
--
Gustavo A. R. Silva
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] iio: adc: meson-saradc: add NULL check on of_match_device() return value
@ 2017-07-10 19:40 ` Gustavo A. R. Silva
0 siblings, 0 replies; 15+ messages in thread
From: Gustavo A. R. Silva @ 2017-07-10 19:40 UTC (permalink / raw)
To: Martin Blumenstingl
Cc: Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, Carlo Caione, Kevin Hilman, linux-iio,
linux-amlogic, linux-kernel, linux-arm-kernel
Hi Martin,
Quoting Martin Blumenstingl <martin.blumenstingl@googlemail.com>:
> On Fri, Jul 7, 2017 at 8:46 AM, Gustavo A. R. Silva
> <garsilva@embeddedor.com> wrote:
>> Check return value from call to of_match_device()
>> in order to prevent a NULL pointer dereference.
>>
>> In case of NULL print error message and return -ENODEV
>>
>> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> thanks for finding this. a crash here is a rather theoretical problem
> (since all compatible strings have their corresponding match data) -
> but it doesn't hurt either, so:
>
I get it, glad to help. :)
> Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>
>
>> ---
>> drivers/iio/adc/meson_saradc.c | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/drivers/iio/adc/meson_saradc.c b/drivers/iio/adc/meson_saradc.c
>> index 83da50e..07dbcc3 100644
>> --- a/drivers/iio/adc/meson_saradc.c
>> +++ b/drivers/iio/adc/meson_saradc.c
>> @@ -915,6 +915,11 @@ static int meson_sar_adc_probe(struct
>> platform_device *pdev)
>> init_completion(&priv->done);
>>
>> match = of_match_device(meson_sar_adc_of_match, &pdev->dev);
>> + if (!match) {
>> + dev_err(&pdev->dev, "failed to match device\n");
>> + return -ENODEV;
>> + }
>> +
>> priv->data = match->data;
>>
>> indio_dev->name = priv->data->name;
>> --
>> 2.5.0
>>
>>
>> _______________________________________________
>> linux-amlogic mailing list
>> linux-amlogic@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-amlogic
--
Gustavo A. R. Silva
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH] iio: adc: meson-saradc: add NULL check on of_match_device() return value
@ 2017-07-10 19:40 ` Gustavo A. R. Silva
0 siblings, 0 replies; 15+ messages in thread
From: Gustavo A. R. Silva @ 2017-07-10 19:40 UTC (permalink / raw)
To: linux-arm-kernel
Hi Martin,
Quoting Martin Blumenstingl <martin.blumenstingl@googlemail.com>:
> On Fri, Jul 7, 2017 at 8:46 AM, Gustavo A. R. Silva
> <garsilva@embeddedor.com> wrote:
>> Check return value from call to of_match_device()
>> in order to prevent a NULL pointer dereference.
>>
>> In case of NULL print error message and return -ENODEV
>>
>> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> thanks for finding this. a crash here is a rather theoretical problem
> (since all compatible strings have their corresponding match data) -
> but it doesn't hurt either, so:
>
I get it, glad to help. :)
> Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>
>
>> ---
>> drivers/iio/adc/meson_saradc.c | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/drivers/iio/adc/meson_saradc.c b/drivers/iio/adc/meson_saradc.c
>> index 83da50e..07dbcc3 100644
>> --- a/drivers/iio/adc/meson_saradc.c
>> +++ b/drivers/iio/adc/meson_saradc.c
>> @@ -915,6 +915,11 @@ static int meson_sar_adc_probe(struct
>> platform_device *pdev)
>> init_completion(&priv->done);
>>
>> match = of_match_device(meson_sar_adc_of_match, &pdev->dev);
>> + if (!match) {
>> + dev_err(&pdev->dev, "failed to match device\n");
>> + return -ENODEV;
>> + }
>> +
>> priv->data = match->data;
>>
>> indio_dev->name = priv->data->name;
>> --
>> 2.5.0
>>
>>
>> _______________________________________________
>> linux-amlogic mailing list
>> linux-amlogic at lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-amlogic
--
Gustavo A. R. Silva
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH] iio: adc: meson-saradc: add NULL check on of_match_device() return value
2017-07-09 18:08 ` Jonathan Cameron
(?)
@ 2017-07-17 4:55 ` Gustavo A. R. Silva
-1 siblings, 0 replies; 15+ messages in thread
From: Gustavo A. R. Silva @ 2017-07-17 4:55 UTC (permalink / raw)
To: linus-amlogic
On 07/09/2017 01:08 PM, Jonathan Cameron wrote:
> On Sat, 8 Jul 2017 15:42:46 +0200
> Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote:
>
>> On Fri, Jul 7, 2017 at 8:46 AM, Gustavo A. R. Silva
>> <garsilva@embeddedor.com> wrote:
>>> Check return value from call to of_match_device()
>>> in order to prevent a NULL pointer dereference.
>>>
>>> In case of NULL print error message and return -ENODEV
>>>
>>> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
>> thanks for finding this. a crash here is a rather theoretical problem
>> (since all compatible strings have their corresponding match data) -
>> but it doesn't hurt either, so:
>>
>> Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> Applied.
>
Thank you, Jonathan.
> Jonathan
>>
>>
>>> ---
>>> drivers/iio/adc/meson_saradc.c | 5 +++++
>>> 1 file changed, 5 insertions(+)
>>>
>>> diff --git a/drivers/iio/adc/meson_saradc.c b/drivers/iio/adc/meson_saradc.c
>>> index 83da50e..07dbcc3 100644
>>> --- a/drivers/iio/adc/meson_saradc.c
>>> +++ b/drivers/iio/adc/meson_saradc.c
>>> @@ -915,6 +915,11 @@ static int meson_sar_adc_probe(struct platform_device *pdev)
>>> init_completion(&priv->done);
>>>
>>> match = of_match_device(meson_sar_adc_of_match, &pdev->dev);
>>> + if (!match) {
>>> + dev_err(&pdev->dev, "failed to match device\n");
>>> + return -ENODEV;
>>> + }
>>> +
>>> priv->data = match->data;
>>>
>>> indio_dev->name = priv->data->name;
>>> --
>>> 2.5.0
>>>
>>>
>>> _______________________________________________
>>> linux-amlogic mailing list
>>> linux-amlogic at lists.infradead.org
>>> http://lists.infradead.org/mailman/listinfo/linux-amlogic
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
>> the body of a message to majordomo at vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Gustavo A. R. Silva
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] iio: adc: meson-saradc: add NULL check on of_match_device() return value
@ 2017-07-17 4:55 ` Gustavo A. R. Silva
0 siblings, 0 replies; 15+ messages in thread
From: Gustavo A. R. Silva @ 2017-07-17 4:55 UTC (permalink / raw)
To: Jonathan Cameron, Martin Blumenstingl
Cc: Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler,
Carlo Caione, Kevin Hilman, linux-iio, linux-amlogic,
linux-kernel, linux-arm-kernel
On 07/09/2017 01:08 PM, Jonathan Cameron wrote:
> On Sat, 8 Jul 2017 15:42:46 +0200
> Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote:
>
>> On Fri, Jul 7, 2017 at 8:46 AM, Gustavo A. R. Silva
>> <garsilva@embeddedor.com> wrote:
>>> Check return value from call to of_match_device()
>>> in order to prevent a NULL pointer dereference.
>>>
>>> In case of NULL print error message and return -ENODEV
>>>
>>> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
>> thanks for finding this. a crash here is a rather theoretical problem
>> (since all compatible strings have their corresponding match data) -
>> but it doesn't hurt either, so:
>>
>> Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> Applied.
>
Thank you, Jonathan.
> Jonathan
>>
>>
>>> ---
>>> drivers/iio/adc/meson_saradc.c | 5 +++++
>>> 1 file changed, 5 insertions(+)
>>>
>>> diff --git a/drivers/iio/adc/meson_saradc.c b/drivers/iio/adc/meson_saradc.c
>>> index 83da50e..07dbcc3 100644
>>> --- a/drivers/iio/adc/meson_saradc.c
>>> +++ b/drivers/iio/adc/meson_saradc.c
>>> @@ -915,6 +915,11 @@ static int meson_sar_adc_probe(struct platform_device *pdev)
>>> init_completion(&priv->done);
>>>
>>> match = of_match_device(meson_sar_adc_of_match, &pdev->dev);
>>> + if (!match) {
>>> + dev_err(&pdev->dev, "failed to match device\n");
>>> + return -ENODEV;
>>> + }
>>> +
>>> priv->data = match->data;
>>>
>>> indio_dev->name = priv->data->name;
>>> --
>>> 2.5.0
>>>
>>>
>>> _______________________________________________
>>> linux-amlogic mailing list
>>> linux-amlogic@lists.infradead.org
>>> http://lists.infradead.org/mailman/listinfo/linux-amlogic
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Gustavo A. R. Silva
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH] iio: adc: meson-saradc: add NULL check on of_match_device() return value
@ 2017-07-17 4:55 ` Gustavo A. R. Silva
0 siblings, 0 replies; 15+ messages in thread
From: Gustavo A. R. Silva @ 2017-07-17 4:55 UTC (permalink / raw)
To: linux-arm-kernel
On 07/09/2017 01:08 PM, Jonathan Cameron wrote:
> On Sat, 8 Jul 2017 15:42:46 +0200
> Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote:
>
>> On Fri, Jul 7, 2017 at 8:46 AM, Gustavo A. R. Silva
>> <garsilva@embeddedor.com> wrote:
>>> Check return value from call to of_match_device()
>>> in order to prevent a NULL pointer dereference.
>>>
>>> In case of NULL print error message and return -ENODEV
>>>
>>> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
>> thanks for finding this. a crash here is a rather theoretical problem
>> (since all compatible strings have their corresponding match data) -
>> but it doesn't hurt either, so:
>>
>> Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> Applied.
>
Thank you, Jonathan.
> Jonathan
>>
>>
>>> ---
>>> drivers/iio/adc/meson_saradc.c | 5 +++++
>>> 1 file changed, 5 insertions(+)
>>>
>>> diff --git a/drivers/iio/adc/meson_saradc.c b/drivers/iio/adc/meson_saradc.c
>>> index 83da50e..07dbcc3 100644
>>> --- a/drivers/iio/adc/meson_saradc.c
>>> +++ b/drivers/iio/adc/meson_saradc.c
>>> @@ -915,6 +915,11 @@ static int meson_sar_adc_probe(struct platform_device *pdev)
>>> init_completion(&priv->done);
>>>
>>> match = of_match_device(meson_sar_adc_of_match, &pdev->dev);
>>> + if (!match) {
>>> + dev_err(&pdev->dev, "failed to match device\n");
>>> + return -ENODEV;
>>> + }
>>> +
>>> priv->data = match->data;
>>>
>>> indio_dev->name = priv->data->name;
>>> --
>>> 2.5.0
>>>
>>>
>>> _______________________________________________
>>> linux-amlogic mailing list
>>> linux-amlogic at lists.infradead.org
>>> http://lists.infradead.org/mailman/listinfo/linux-amlogic
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
>> the body of a message to majordomo at vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Gustavo A. R. Silva
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2017-07-17 4:55 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-07 6:46 [PATCH] iio: adc: meson-saradc: add NULL check on of_match_device() return value Gustavo A. R. Silva
2017-07-07 6:46 ` Gustavo A. R. Silva
2017-07-07 6:46 ` Gustavo A. R. Silva
2017-07-08 13:42 ` Martin Blumenstingl
2017-07-08 13:42 ` Martin Blumenstingl
2017-07-08 13:42 ` Martin Blumenstingl
2017-07-09 18:08 ` Jonathan Cameron
2017-07-09 18:08 ` Jonathan Cameron
2017-07-09 18:08 ` Jonathan Cameron
2017-07-17 4:55 ` Gustavo A. R. Silva
2017-07-17 4:55 ` Gustavo A. R. Silva
2017-07-17 4:55 ` Gustavo A. R. Silva
2017-07-10 19:40 ` Gustavo A. R. Silva
2017-07-10 19:40 ` Gustavo A. R. Silva
2017-07-10 19:40 ` Gustavo A. R. Silva
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.