From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] printk: Move printk_delay to separate file
Date: Sat, 8 Jul 2017 14:24:20 +0900 [thread overview]
Message-ID: <20170708052420.GC488@tigerII.localdomain> (raw)
In-Reply-To: <df7851a1308425cfa6c09510a1a97dcbce5de981.1499450194.git.joe@perches.com>
On (07/07/17 11:08), Joe Perches wrote:
> printk.c is a huge file with too many local functions for a
> human to read and easily parse.
>
> Start to separate out bits into smaller files.
>
> Miscellanea:
>
> o Rename suppress_message_printing to printk_suppress_message
> o Add function definitions to printk.h
I don't mind, in general, but I'm a bit hesitant. we want to have
automatic printk throttling (printk delay basically) and we need
some of those printk-internal *_seq numbers to see how far consoles
are behind the logbuf. so either we need to 'un-static' those *_seq
and extern them in delay.c or simply keep printk-delay machinery in
printk.c and add the new function.
// p.s. I'll take a look at the patch a bit later. I'm on a sick leave now.
-ss
next prev parent reply other threads:[~2017-07-08 5:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-07 18:08 [PATCH] printk: Move printk_delay to separate file Joe Perches
2017-07-08 5:24 ` Sergey Senozhatsky [this message]
2017-07-08 5:44 ` Joe Perches
2017-07-14 15:17 ` Petr Mladek
2017-07-14 15:45 ` Joe Perches
2017-07-14 15:57 ` Petr Mladek
2017-07-14 16:14 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170708052420.GC488@tigerII.localdomain \
--to=sergey.senozhatsky@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.