* [RFC PATCH v2] Bluetooth: btusb: fix QCA Rome suspend/resume
@ 2017-07-08 18:55 Leif Liddy
2017-07-08 19:54 ` Marcel Holtmann
0 siblings, 1 reply; 2+ messages in thread
From: Leif Liddy @ 2017-07-08 18:55 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Leif Liddy
**update: sent with 'git send-email'
There's been numerous reported instances where BTUSB_QCA_ROME
bluetooth controllers stop functioning upon resume from suspend. These
devices seem to be losing power during suspend. Patch will detect a status
change on resume and perform a reset.
Signed-off-by: Leif Liddy <leif.linux@gmail.com>
---
drivers/bluetooth/btusb.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index fa24d69..0804a52 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -3067,6 +3067,11 @@ static int btusb_probe(struct usb_interface *intf,
if (id->driver_info & BTUSB_QCA_ROME) {
data->setup_on_usb = btusb_setup_qca;
hdev->set_bdaddr = btusb_set_bdaddr_ath3012;
+ /* QCA Rome devices lose their updated firmware over suspend,
+ * but the USB hub doesn't notice any status change.
+ * Explicitly request a device reset on resume.
+ */
+ set_bit(BTUSB_RESET_RESUME, &data->flags);
}
#ifdef CONFIG_BT_HCIBTUSB_RTL
--
2.9.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [RFC PATCH v2] Bluetooth: btusb: fix QCA Rome suspend/resume
2017-07-08 18:55 [RFC PATCH v2] Bluetooth: btusb: fix QCA Rome suspend/resume Leif Liddy
@ 2017-07-08 19:54 ` Marcel Holtmann
0 siblings, 0 replies; 2+ messages in thread
From: Marcel Holtmann @ 2017-07-08 19:54 UTC (permalink / raw)
To: Leif Liddy; +Cc: linux-bluetooth
Hi Leif,
> There's been numerous reported instances where BTUSB_QCA_ROME
> bluetooth controllers stop functioning upon resume from suspend. These
> devices seem to be losing power during suspend. Patch will detect a status
> change on resume and perform a reset.
>
> Signed-off-by: Leif Liddy <leif.linux@gmail.com>
> ---
> drivers/bluetooth/btusb.c | 5 +++++
> 1 file changed, 5 insertions(+)
patch has been applied to bluetooth-next tree.
Regards
Marcel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-08 19:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-08 18:55 [RFC PATCH v2] Bluetooth: btusb: fix QCA Rome suspend/resume Leif Liddy
2017-07-08 19:54 ` Marcel Holtmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.