All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, Pranith Kumar <bobby.prani@gmail.com>
Subject: [Qemu-devel] [PULL 4/5] util/cacheinfo: Fix warning generated by clang
Date: Sun,  9 Jul 2017 21:35:00 -1000	[thread overview]
Message-ID: <20170710073501.5207-5-rth@twiddle.net> (raw)
In-Reply-To: <20170710073501.5207-1-rth@twiddle.net>

From: Pranith Kumar <bobby.prani@gmail.com>

Clang generates the following warning on aarch64 host:

  CC      util/cacheinfo.o
/home/pranith/qemu/util/cacheinfo.c:121:48: warning: value size does not match register size specified by the constraint and modifier [-Wasm-operand-widths]
        asm volatile("mrs\t%0, ctr_el0" : "=r"(ctr));
                                               ^
/home/pranith/qemu/util/cacheinfo.c:121:28: note: use constraint modifier "w"
        asm volatile("mrs\t%0, ctr_el0" : "=r"(ctr));
                           ^~
                           %w0

Constraint modifier 'w' is not (yet?) accepted by gcc. Fix this by increasing the ctr size.

Tested-by: Emilio G. Cota <cota@braap.org>
Reviewed-by: Emilio G. Cota <cota@braap.org>
Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
Message-Id: <20170630153946.11997-1-bobby.prani@gmail.com>
Signed-off-by: Richard Henderson <rth@twiddle.net>
---
 util/cacheinfo.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/util/cacheinfo.c b/util/cacheinfo.c
index f987522..6253049 100644
--- a/util/cacheinfo.c
+++ b/util/cacheinfo.c
@@ -112,7 +112,7 @@ static void sys_cache_info(int *isize, int *dsize)
 static void arch_cache_info(int *isize, int *dsize)
 {
     if (*isize == 0 || *dsize == 0) {
-        unsigned ctr;
+        unsigned long ctr;
 
         /* The real cache geometry is in CCSIDR_EL1/CLIDR_EL1/CSSELR_EL1,
            but (at least under Linux) these are marked protected by the
-- 
2.9.4

  parent reply	other threads:[~2017-07-10  7:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-10  7:34 [Qemu-devel] [PULL 0/5] Queued tcg patches Richard Henderson
2017-07-10  7:34 ` [Qemu-devel] [PULL 1/5] tcg/aarch64: Introduce and use long branch to register Richard Henderson
2017-07-10  7:34 ` [Qemu-devel] [PULL 2/5] tcg/aarch64: Use ADRP+ADD to compute target address Richard Henderson
2017-07-10  7:34 ` [Qemu-devel] [PULL 3/5] tcg/aarch64: Enable indirect jump path using LDR (literal) Richard Henderson
2017-07-10  7:35 ` Richard Henderson [this message]
2017-07-10  7:35 ` [Qemu-devel] [PULL 5/5] tcg/mips: Bugfix for crash when running program with qemu-i386 Richard Henderson
2017-07-10 13:06 ` [Qemu-devel] [PULL 0/5] Queued tcg patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170710073501.5207-5-rth@twiddle.net \
    --to=rth@twiddle.net \
    --cc=bobby.prani@gmail.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.