From: Eduardo Habkost <ehabkost@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Marcel Apfelbaum <marcel@redhat.com>,
Thomas Huth <thuth@redhat.com>,
Chao Peng <chao.p.peng@linux.intel.com>,
qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
"Tian, Kevin" <kevin.tian@intel.com>,
Laszlo Ersek <lersek@redhat.com>,
libvir-list@redhat.com
Subject: Re: [Qemu-devel] change x86 default machine type to Q35?
Date: Mon, 10 Jul 2017 14:47:30 -0300 [thread overview]
Message-ID: <20170710174730.GL12152@localhost.localdomain> (raw)
In-Reply-To: <20170710194345-mutt-send-email-mst@kernel.org>
(CCing libvir-list)
On Mon, Jul 10, 2017 at 07:45:54PM +0300, Michael S. Tsirkin wrote:
> On Mon, Jul 10, 2017 at 10:59:43AM -0300, Eduardo Habkost wrote:
> > On Mon, Jul 10, 2017 at 10:42:26AM +0300, Marcel Apfelbaum wrote:
> > > On 07/07/2017 21:03, Eduardo Habkost wrote:
> > > > On Fri, Jul 07, 2017 at 06:17:57PM +0300, Michael S. Tsirkin wrote:
> > > > > On Fri, Jul 07, 2017 at 10:39:49AM -0300, Eduardo Habkost wrote:
> > > > > > On Wed, Jul 05, 2017 at 12:32:10PM +0300, Marcel Apfelbaum wrote:
> > [...]
> > > > > > >
> > > > > > > The upper layers should manage the defaults by themselves so
> > > > > > > are not supposed to be affected.
> > > > > >
> > > > > > But they would be. libvirt uses the default machine-type from
> > > > > > QEMU.
> > > > >
> > > > > How about extending the command for supported machines with a
> > > > > recommended machine type, and teaching libvirt to use that?
> > > >
> > > > I don't think QEMU has enough information to decide if it should
> > > > recommend "q35" or "pc".
> > >
> > > We don't really need a complicated rule set, we would just recommend q35
> > > by default. Libvirt will try to create the default machine and if fails
> > > for some reason (what would it be?) it can switch to PC.
> > >
> > > The advanced logic would be "old systems should use PC", where old
> > > means Windows XP and before and so on. But this logic should appear
> > > in management layers above.
> >
> > In this case, is there any difference between "changing the
> > default to q35" and "recommending q35", for libvirt users?
> >
> > --
> > Eduardo
>
> No but libvirt users do not manage e.g. pci slots manually.
> They do not use the -cdrom flag.
> Etc.
> So changing the default is unlikely to break things for them.
>
I see. If this part is really true (can libvirt developers
confirm that?), then the proposed end result makes sense (not
having a default for running QEMU directly, but changing default
to "q35" for people using libvirt).
But I don't see why we would need a new mechanism to make QEMU
recommend a machine-type for libvirt, if libvirt could simply
choose its own default (or maybe also refuse to pick a default,
if libvirt developers decide that's the best solution).
> People not using libvirt use some or all of this
> and other such functionality,
> and changing the default might break things for them.
--
Eduardo
next prev parent reply other threads:[~2017-07-10 17:47 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-05 6:57 [Qemu-devel] change x86 default machine type to Q35? Chao Peng
2017-07-05 8:14 ` Thomas Huth
2017-07-05 9:32 ` Marcel Apfelbaum
2017-07-07 13:39 ` Eduardo Habkost
2017-07-07 15:17 ` Michael S. Tsirkin
2017-07-07 18:03 ` Eduardo Habkost
2017-07-10 7:42 ` Marcel Apfelbaum
2017-07-10 9:45 ` Paolo Bonzini
2017-07-10 13:59 ` Eduardo Habkost
2017-07-10 16:45 ` Michael S. Tsirkin
2017-07-10 17:47 ` Eduardo Habkost [this message]
2017-07-11 7:48 ` Thomas Huth
2017-07-11 8:01 ` Marcel Apfelbaum
2017-07-11 8:13 ` Gerd Hoffmann
2017-07-11 14:42 ` Kevin Wolf
2017-07-11 14:47 ` Paolo Bonzini
2017-07-12 6:39 ` Marcel Apfelbaum
2017-07-12 15:17 ` Eduardo Habkost
2017-07-12 5:51 ` Gerd Hoffmann
2017-07-12 6:18 ` Marcel Apfelbaum
2017-07-12 8:28 ` Kevin Wolf
2017-07-11 14:47 ` Eduardo Habkost
2017-07-05 11:07 ` Daniel P. Berrange
2017-07-05 11:13 ` Thomas Huth
2017-07-06 10:30 ` Stefan Hajnoczi
2017-07-06 10:41 ` Daniel P. Berrange
2017-07-11 10:13 ` Stefan Hajnoczi
2017-07-05 10:49 ` Laszlo Ersek
2017-07-05 11:04 ` Daniel P. Berrange
2017-07-05 11:44 ` Fam Zheng
2017-07-05 11:58 ` Thomas Huth
2017-07-05 12:22 ` Fam Zheng
2017-07-06 10:49 ` Daniel P. Berrange
2017-07-06 10:57 ` Peter Maydell
2017-07-06 11:00 ` Thomas Huth
2017-07-06 11:06 ` Daniel P. Berrange
2017-07-06 11:12 ` Thomas Huth
2017-07-06 11:13 ` Dr. David Alan Gilbert
2017-07-07 13:49 ` Eduardo Habkost
2017-07-05 12:43 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170710174730.GL12152@localhost.localdomain \
--to=ehabkost@redhat.com \
--cc=chao.p.peng@linux.intel.com \
--cc=kevin.tian@intel.com \
--cc=lersek@redhat.com \
--cc=libvir-list@redhat.com \
--cc=marcel@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.