All of lore.kernel.org
 help / color / mirror / Atom feed
* in:imklog segfault in 4.12+git on most sparc64's
@ 2017-07-10  8:25 Meelis Roos
  2017-07-10  8:38 ` John Paul Adrian Glaubitz
                   ` (9 more replies)
  0 siblings, 10 replies; 24+ messages in thread
From: Meelis Roos @ 2017-07-10  8:25 UTC (permalink / raw)
  To: sparclinux

I tested yesterdays git with 4.13 sparc merge on a big bunch of my test 
machines.

Good news: the timestamps starting from boot seem to work on all the 
machines, starting with Ultra 1 and Ultra 2.

Bad news: all working sun4u machines have the following line in dmesg 
(PID varies):
in:imklog[1036]: segfault at 49 ip 0000000000035bb0 (rpc 00000000f779dfa0) sp 00000002f7a78818 error 30002 in rsyslogd[10000+88000]

This is with Debian unstable 32-bit userland as of 2015 summer. It did 
not happen with 4.12.

More bad news: all my sun4v machines crash on boot with DMA+IOMMU 
problem (will send a separate mail with details).

-- 
Meelis Roos (mroos@linux.ee)

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: in:imklog segfault in 4.12+git on most sparc64's
  2017-07-10  8:25 in:imklog segfault in 4.12+git on most sparc64's Meelis Roos
@ 2017-07-10  8:38 ` John Paul Adrian Glaubitz
  2017-07-10 11:46 ` Meelis Roos
                   ` (8 subsequent siblings)
  9 siblings, 0 replies; 24+ messages in thread
From: John Paul Adrian Glaubitz @ 2017-07-10  8:38 UTC (permalink / raw)
  To: sparclinux

On Mon, Jul 10, 2017 at 11:25:51AM +0300, Meelis Roos wrote:
> This is with Debian unstable 32-bit userland as of 2015 summer. It did 
> not happen with 4.12.

Did you also perform tests with a current 64-bit userland?

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz@debian.org
`. `'   Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: in:imklog segfault in 4.12+git on most sparc64's
  2017-07-10  8:25 in:imklog segfault in 4.12+git on most sparc64's Meelis Roos
  2017-07-10  8:38 ` John Paul Adrian Glaubitz
@ 2017-07-10 11:46 ` Meelis Roos
  2017-07-10 11:48 ` John Paul Adrian Glaubitz
                   ` (7 subsequent siblings)
  9 siblings, 0 replies; 24+ messages in thread
From: Meelis Roos @ 2017-07-10 11:46 UTC (permalink / raw)
  To: sparclinux

> > This is with Debian unstable 32-bit userland as of 2015 summer. It did 
> > not happen with 4.12.
> 
> Did you also perform tests with a current 64-bit userland?

No, for the current test this is not relevant since if the breakage 
happens with some userlan, it is kernel at fault.

I have tested sparc64 debian-port on my T5120 where I expected it to be 
fast. For some test it was faster than 32-bit userland. for some things 
slower, but it worked.

I never tested it on older machines so far. I might have tried 
installing on Blade 150 (I am not sure if it was sparc or sparc64) but 
the install was hanging, and I have not finished with it as I suspected 
the PSU that I had just replaced and I have had no time to to hardware 
bisecting with Blade 100.

-- 
Meelis Roos (mroos@linux.ee)

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: in:imklog segfault in 4.12+git on most sparc64's
  2017-07-10  8:25 in:imklog segfault in 4.12+git on most sparc64's Meelis Roos
  2017-07-10  8:38 ` John Paul Adrian Glaubitz
  2017-07-10 11:46 ` Meelis Roos
@ 2017-07-10 11:48 ` John Paul Adrian Glaubitz
  2017-07-10 18:31 ` David Miller
                   ` (6 subsequent siblings)
  9 siblings, 0 replies; 24+ messages in thread
From: John Paul Adrian Glaubitz @ 2017-07-10 11:48 UTC (permalink / raw)
  To: sparclinux

On Mon, Jul 10, 2017 at 02:46:19PM +0300, Meelis Roos wrote:
> > > This is with Debian unstable 32-bit userland as of 2015 summer. It did 
> > > not happen with 4.12.
> > 
> > Did you also perform tests with a current 64-bit userland?
> 
> No, for the current test this is not relevant since if the breakage 
> happens with some userlan, it is kernel at fault.

Yes, but I think it's more interesting to perform such tests with
current and maintained userland software.

> I never tested it on older machines so far. I might have tried 
> installing on Blade 150 (I am not sure if it was sparc or sparc64) but 
> the install was hanging, and I have not finished with it as I suspected 
> the PSU that I had just replaced and I have had no time to to hardware 
> bisecting with Blade 100.

Debian sparc64 runs fine on my Sun Blade 100.

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz@debian.org
`. `'   Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: in:imklog segfault in 4.12+git on most sparc64's
  2017-07-10  8:25 in:imklog segfault in 4.12+git on most sparc64's Meelis Roos
                   ` (2 preceding siblings ...)
  2017-07-10 11:48 ` John Paul Adrian Glaubitz
@ 2017-07-10 18:31 ` David Miller
  2017-07-10 18:32 ` David Miller
                   ` (5 subsequent siblings)
  9 siblings, 0 replies; 24+ messages in thread
From: David Miller @ 2017-07-10 18:31 UTC (permalink / raw)
  To: sparclinux

From: Meelis Roos <mroos@linux.ee>
Date: Mon, 10 Jul 2017 14:46:19 +0300 (EEST)

>> > This is with Debian unstable 32-bit userland as of 2015 summer. It did 
>> > not happen with 4.12.
>> 
>> Did you also perform tests with a current 64-bit userland?
> 
> No, for the current test this is not relevant since if the breakage 
> happens with some userlan, it is kernel at fault.

+1

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: in:imklog segfault in 4.12+git on most sparc64's
  2017-07-10  8:25 in:imklog segfault in 4.12+git on most sparc64's Meelis Roos
                   ` (3 preceding siblings ...)
  2017-07-10 18:31 ` David Miller
@ 2017-07-10 18:32 ` David Miller
  2017-07-10 18:35 ` John Paul Adrian Glaubitz
                   ` (4 subsequent siblings)
  9 siblings, 0 replies; 24+ messages in thread
From: David Miller @ 2017-07-10 18:32 UTC (permalink / raw)
  To: sparclinux

From: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Date: Mon, 10 Jul 2017 13:48:46 +0200

> On Mon, Jul 10, 2017 at 02:46:19PM +0300, Meelis Roos wrote:
>> > > This is with Debian unstable 32-bit userland as of 2015 summer. It did 
>> > > not happen with 4.12.
>> > 
>> > Did you also perform tests with a current 64-bit userland?
>> 
>> No, for the current test this is not relevant since if the breakage 
>> happens with some userlan, it is kernel at fault.
> 
> Yes, but I think it's more interesting to perform such tests with
> current and maintained userland software.

Yes, let's make sure that 32-bit userland support in the kernel gets
even less testing, and gets even buggier over time.

I think people should test everything, as much as possible.


^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: in:imklog segfault in 4.12+git on most sparc64's
  2017-07-10  8:25 in:imklog segfault in 4.12+git on most sparc64's Meelis Roos
                   ` (4 preceding siblings ...)
  2017-07-10 18:32 ` David Miller
@ 2017-07-10 18:35 ` John Paul Adrian Glaubitz
  2017-07-10 18:42 ` David Miller
                   ` (3 subsequent siblings)
  9 siblings, 0 replies; 24+ messages in thread
From: John Paul Adrian Glaubitz @ 2017-07-10 18:35 UTC (permalink / raw)
  To: sparclinux

On Mon, Jul 10, 2017 at 07:32:27PM +0100, David Miller wrote:
> Yes, let's make sure that 32-bit userland support in the kernel gets
> even less testing, and gets even buggier over time.

My point was not 32-bit vs. 64-bit, my point was using an outdated
userland from 2015.  For 32-bit tests, I'd rather create a Gentoo
a 32-bit sparc chroot or rebootstrap Debian sparc.

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz@debian.org
`. `'   Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: in:imklog segfault in 4.12+git on most sparc64's
  2017-07-10  8:25 in:imklog segfault in 4.12+git on most sparc64's Meelis Roos
                   ` (5 preceding siblings ...)
  2017-07-10 18:35 ` John Paul Adrian Glaubitz
@ 2017-07-10 18:42 ` David Miller
  2017-07-10 18:47 ` John Paul Adrian Glaubitz
                   ` (2 subsequent siblings)
  9 siblings, 0 replies; 24+ messages in thread
From: David Miller @ 2017-07-10 18:42 UTC (permalink / raw)
  To: sparclinux

From: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Date: Mon, 10 Jul 2017 20:35:21 +0200

> On Mon, Jul 10, 2017 at 07:32:27PM +0100, David Miller wrote:
>> Yes, let's make sure that 32-bit userland support in the kernel gets
>> even less testing, and gets even buggier over time.
> 
> My point was not 32-bit vs. 64-bit, my point was using an outdated
> userland from 2015.  For 32-bit tests, I'd rather create a Gentoo
> a 32-bit sparc chroot or rebootstrap Debian sparc.

My userland is from 2013 with random built-from-src pieces of updated
tools and glibc, should I just throw my hands up in the air when the
kernel OOPSes and not look into it at all?

None of this makes any sense at all.

If a bug shows up in the kernel between X and Y, it doesn't matter if
it triggers with an old userland or a new one.  It should be
investigated just the same.


^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: in:imklog segfault in 4.12+git on most sparc64's
  2017-07-10  8:25 in:imklog segfault in 4.12+git on most sparc64's Meelis Roos
                   ` (6 preceding siblings ...)
  2017-07-10 18:42 ` David Miller
@ 2017-07-10 18:47 ` John Paul Adrian Glaubitz
  2017-07-11 11:48   ` Meelis Roos
  2017-07-11 13:56 ` David Miller
  9 siblings, 0 replies; 24+ messages in thread
From: John Paul Adrian Glaubitz @ 2017-07-10 18:47 UTC (permalink / raw)
  To: sparclinux

On 07/10/2017 08:42 PM, David Miller wrote:
> My userland is from 2013 with random built-from-src pieces of updated
> tools and glibc, should I just throw my hands up in the air when the
> kernel OOPSes and not look into it at all?

Well, I know that around 2-3 years ago, lots of userland packages had
issues on sparc which were consequently fixed. Here's a selection [1].

Testing with a current userland just reduces the probability to stumble
into any of these issues.

Adrian

> [1] https://wiki.debian.org/PortsSparc

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz@debian.org
`. `'   Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: in:imklog segfault in 4.12+git on most sparc64's
  2017-07-10  8:25 in:imklog segfault in 4.12+git on most sparc64's Meelis Roos
@ 2017-07-11 11:48   ` Meelis Roos
  2017-07-10 11:46 ` Meelis Roos
                     ` (8 subsequent siblings)
  9 siblings, 0 replies; 24+ messages in thread
From: Meelis Roos @ 2017-07-11 11:48 UTC (permalink / raw)
  To: sparclinux, Linux Kernel list, Al Viro

> I tested yesterdays git with 4.13 sparc merge on a big bunch of my test 
> machines.
> 
> Good news: the timestamps starting from boot seem to work on all the 
> machines, starting with Ultra 1 and Ultra 2.
> 
> Bad news: all working sun4u machines have the following line in dmesg 
> (PID varies):
> in:imklog[1036]: segfault at 49 ip 0000000000035bb0 (rpc 00000000f779dfa0) sp 00000002f7a78818 error 30002 in rsyslogd[10000+88000]
> 
> This is with Debian unstable 32-bit userland as of 2015 summer. It did 
> not happen with 4.12.

I bisected it to the commit below. CC Al Viro.

In following commits around this one (some bisect steps before, and the 
last step) the crashes were slightly different from the original crash 
yersterday, like

in:imuxsock[1606]: segfault at fffffff8 ip 00000000f774e154 (rpc 00000000f774dfe8) sp 00000001f7965a68 error 30002 in libc-2.19.so[f76cc000+16a000]

but this was the first commit introducing the crashes.

d9e968cb9f849770288f5fde3d8d3a5f7e339052 is the first bad commit
commit d9e968cb9f849770288f5fde3d8d3a5f7e339052
Author: Al Viro <viro@zeniv.linux.org.uk>
Date:   Wed May 31 04:33:51 2017 -0400

    getrlimit()/setrlimit(): move compat to native

    Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

:040000 040000 5e1a0c25f4554ccdc824b18dc50078d379cdbf9a 
6d820451a388c5771a2a410578365d14a0194e4e M      kernel

-- 
Meelis Roos (mroos@linux.ee)

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: in:imklog segfault in 4.12+git on most sparc64's
@ 2017-07-11 11:48   ` Meelis Roos
  0 siblings, 0 replies; 24+ messages in thread
From: Meelis Roos @ 2017-07-11 11:48 UTC (permalink / raw)
  To: sparclinux, Linux Kernel list, Al Viro

> I tested yesterdays git with 4.13 sparc merge on a big bunch of my test 
> machines.
> 
> Good news: the timestamps starting from boot seem to work on all the 
> machines, starting with Ultra 1 and Ultra 2.
> 
> Bad news: all working sun4u machines have the following line in dmesg 
> (PID varies):
> in:imklog[1036]: segfault at 49 ip 0000000000035bb0 (rpc 00000000f779dfa0) sp 00000002f7a78818 error 30002 in rsyslogd[10000+88000]
> 
> This is with Debian unstable 32-bit userland as of 2015 summer. It did 
> not happen with 4.12.

I bisected it to the commit below. CC Al Viro.

In following commits around this one (some bisect steps before, and the 
last step) the crashes were slightly different from the original crash 
yersterday, like

in:imuxsock[1606]: segfault at fffffff8 ip 00000000f774e154 (rpc 00000000f774dfe8) sp 00000001f7965a68 error 30002 in libc-2.19.so[f76cc000+16a000]

but this was the first commit introducing the crashes.

d9e968cb9f849770288f5fde3d8d3a5f7e339052 is the first bad commit
commit d9e968cb9f849770288f5fde3d8d3a5f7e339052
Author: Al Viro <viro@zeniv.linux.org.uk>
Date:   Wed May 31 04:33:51 2017 -0400

    getrlimit()/setrlimit(): move compat to native

    Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

:040000 040000 5e1a0c25f4554ccdc824b18dc50078d379cdbf9a 
6d820451a388c5771a2a410578365d14a0194e4e M      kernel

-- 
Meelis Roos (mroos@linux.ee)

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: in:imklog segfault in 4.12+git on most sparc64's
  2017-07-10  8:25 in:imklog segfault in 4.12+git on most sparc64's Meelis Roos
                   ` (8 preceding siblings ...)
  2017-07-11 11:48   ` Meelis Roos
@ 2017-07-11 13:56 ` David Miller
  9 siblings, 0 replies; 24+ messages in thread
From: David Miller @ 2017-07-11 13:56 UTC (permalink / raw)
  To: sparclinux

From: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Date: Mon, 10 Jul 2017 20:47:54 +0200

> Testing with a current userland just reduces the probability to stumble
> into any of these issues.

But things worked %100 properly before he changed the kernel.

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: in:imklog segfault in 4.12+git on most sparc64's
  2017-07-11 11:48   ` Meelis Roos
@ 2017-07-12  3:13     ` David Miller
  -1 siblings, 0 replies; 24+ messages in thread
From: David Miller @ 2017-07-12  3:13 UTC (permalink / raw)
  To: mroos; +Cc: sparclinux, linux-kernel, viro

From: Meelis Roos <mroos@linux.ee>
Date: Tue, 11 Jul 2017 14:48:27 +0300 (EEST)

>> I tested yesterdays git with 4.13 sparc merge on a big bunch of my test 
>> machines.
>> 
>> Good news: the timestamps starting from boot seem to work on all the 
>> machines, starting with Ultra 1 and Ultra 2.
>> 
>> Bad news: all working sun4u machines have the following line in dmesg 
>> (PID varies):
>> in:imklog[1036]: segfault at 49 ip 0000000000035bb0 (rpc 00000000f779dfa0) sp 00000002f7a78818 error 30002 in rsyslogd[10000+88000]
>> 
>> This is with Debian unstable 32-bit userland as of 2015 summer. It did 
>> not happen with 4.12.
> 
> I bisected it to the commit below. CC Al Viro.
> 
> In following commits around this one (some bisect steps before, and the 
> last step) the crashes were slightly different from the original crash 
> yersterday, like
> 
> in:imuxsock[1606]: segfault at fffffff8 ip 00000000f774e154 (rpc 00000000f774dfe8) sp 00000001f7965a68 error 30002 in libc-2.19.so[f76cc000+16a000]
> 
> but this was the first commit introducing the crashes.
> 
> d9e968cb9f849770288f5fde3d8d3a5f7e339052 is the first bad commit
> commit d9e968cb9f849770288f5fde3d8d3a5f7e339052
> Author: Al Viro <viro@zeniv.linux.org.uk>
> Date:   Wed May 31 04:33:51 2017 -0400
> 
>     getrlimit()/setrlimit(): move compat to native
> 
>     Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> 
> :040000 040000 5e1a0c25f4554ccdc824b18dc50078d379cdbf9a 
> 6d820451a388c5771a2a410578365d14a0194e4e M      kernel

I can't figure out what is wrong in this change, except that it does
two things at once.

It moves code, and changes it at the same time.  That should have been
done in two changes.

Because of that, we can't tell which of the two things introduced the
regression.

Al?

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: in:imklog segfault in 4.12+git on most sparc64's
@ 2017-07-12  3:13     ` David Miller
  0 siblings, 0 replies; 24+ messages in thread
From: David Miller @ 2017-07-12  3:13 UTC (permalink / raw)
  To: mroos; +Cc: sparclinux, linux-kernel, viro

From: Meelis Roos <mroos@linux.ee>
Date: Tue, 11 Jul 2017 14:48:27 +0300 (EEST)

>> I tested yesterdays git with 4.13 sparc merge on a big bunch of my test 
>> machines.
>> 
>> Good news: the timestamps starting from boot seem to work on all the 
>> machines, starting with Ultra 1 and Ultra 2.
>> 
>> Bad news: all working sun4u machines have the following line in dmesg 
>> (PID varies):
>> in:imklog[1036]: segfault at 49 ip 0000000000035bb0 (rpc 00000000f779dfa0) sp 00000002f7a78818 error 30002 in rsyslogd[10000+88000]
>> 
>> This is with Debian unstable 32-bit userland as of 2015 summer. It did 
>> not happen with 4.12.
> 
> I bisected it to the commit below. CC Al Viro.
> 
> In following commits around this one (some bisect steps before, and the 
> last step) the crashes were slightly different from the original crash 
> yersterday, like
> 
> in:imuxsock[1606]: segfault at fffffff8 ip 00000000f774e154 (rpc 00000000f774dfe8) sp 00000001f7965a68 error 30002 in libc-2.19.so[f76cc000+16a000]
> 
> but this was the first commit introducing the crashes.
> 
> d9e968cb9f849770288f5fde3d8d3a5f7e339052 is the first bad commit
> commit d9e968cb9f849770288f5fde3d8d3a5f7e339052
> Author: Al Viro <viro@zeniv.linux.org.uk>
> Date:   Wed May 31 04:33:51 2017 -0400
> 
>     getrlimit()/setrlimit(): move compat to native
> 
>     Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> 
> :040000 040000 5e1a0c25f4554ccdc824b18dc50078d379cdbf9a 
> 6d820451a388c5771a2a410578365d14a0194e4e M      kernel

I can't figure out what is wrong in this change, except that it does
two things at once.

It moves code, and changes it at the same time.  That should have been
done in two changes.

Because of that, we can't tell which of the two things introduced the
regression.

Al?

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: in:imklog segfault in 4.12+git on most sparc64's
  2017-07-11 11:48   ` Meelis Roos
@ 2017-07-12  3:59     ` Al Viro
  -1 siblings, 0 replies; 24+ messages in thread
From: Al Viro @ 2017-07-12  3:59 UTC (permalink / raw)
  To: Meelis Roos; +Cc: sparclinux, Linux Kernel list, Linus Torvalds

> In following commits around this one (some bisect steps before, and the 
> last step) the crashes were slightly different from the original crash 
> yersterday, like
> 
> in:imuxsock[1606]: segfault at fffffff8 ip 00000000f774e154 (rpc 00000000f774dfe8) sp 00000001f7965a68 error 30002 in libc-2.19.so[f76cc000+16a000]
> 
> but this was the first commit introducing the crashes.
> 
> d9e968cb9f849770288f5fde3d8d3a5f7e339052 is the first bad commit
> commit d9e968cb9f849770288f5fde3d8d3a5f7e339052
> Author: Al Viro <viro@zeniv.linux.org.uk>
> Date:   Wed May 31 04:33:51 2017 -0400
> 
w     getrlimit()/setrlimit(): move compat to native
> 
>     Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> 
> :040000 040000 5e1a0c25f4554ccdc824b18dc50078d379cdbf9a 
> 6d820451a388c5771a2a410578365d14a0194e4e M      kernel
> 
> -- 
> Meelis Roos (mroos@linux.ee)

With apologies for ed scripts,

ed kernel/sys.c <<'EOF'
/struct rlimit r32/s/rlimit/compat_&/
w
q
EOF

AFAICS, that should fix it.  If it does, commit message would be

fix a braino in compat_sys_getrlimit()

Fixes: commit d9e968cb9f84 "getrlimit()/setrlimit(): move compat to native"
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---

Again, my apologies for format of that all - I'm almost completely
off-net and while typing an ed script is feasible, context diff is
too far over the top.  Usimg mutt in ssh session from android is
not fun, to put it mildly...  

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: in:imklog segfault in 4.12+git on most sparc64's
@ 2017-07-12  3:59     ` Al Viro
  0 siblings, 0 replies; 24+ messages in thread
From: Al Viro @ 2017-07-12  3:59 UTC (permalink / raw)
  To: Meelis Roos; +Cc: sparclinux, Linux Kernel list, Linus Torvalds

> In following commits around this one (some bisect steps before, and the 
> last step) the crashes were slightly different from the original crash 
> yersterday, like
> 
> in:imuxsock[1606]: segfault at fffffff8 ip 00000000f774e154 (rpc 00000000f774dfe8) sp 00000001f7965a68 error 30002 in libc-2.19.so[f76cc000+16a000]
> 
> but this was the first commit introducing the crashes.
> 
> d9e968cb9f849770288f5fde3d8d3a5f7e339052 is the first bad commit
> commit d9e968cb9f849770288f5fde3d8d3a5f7e339052
> Author: Al Viro <viro@zeniv.linux.org.uk>
> Date:   Wed May 31 04:33:51 2017 -0400
> 
w     getrlimit()/setrlimit(): move compat to native
> 
>     Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> 
> :040000 040000 5e1a0c25f4554ccdc824b18dc50078d379cdbf9a 
> 6d820451a388c5771a2a410578365d14a0194e4e M      kernel
> 
> -- 
> Meelis Roos (mroos@linux.ee)

With apologies for ed scripts,

ed kernel/sys.c <<'EOF'
/struct rlimit r32/s/rlimit/compat_&/
w
q
EOF

AFAICS, that should fix it.  If it does, commit message would be

fix a braino in compat_sys_getrlimit()

Fixes: commit d9e968cb9f84 "getrlimit()/setrlimit(): move compat to native"
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---

Again, my apologies for format of that all - I'm almost completely
off-net and while typing an ed script is feasible, context diff is
too far over the top.  Usimg mutt in ssh session from android is
not fun, to put it mildly...  

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: in:imklog segfault in 4.12+git on most sparc64's
  2017-07-12  3:59     ` Al Viro
@ 2017-07-12  4:09       ` David Miller
  -1 siblings, 0 replies; 24+ messages in thread
From: David Miller @ 2017-07-12  4:09 UTC (permalink / raw)
  To: viro; +Cc: mroos, sparclinux, linux-kernel, torvalds

From: Al Viro <viro@ZenIV.linux.org.uk>
Date: Wed, 12 Jul 2017 04:59:45 +0100

> Again, my apologies for format of that all - I'm almost completely
> off-net and while typing an ed script is feasible, context diff is
> too far over the top.  Usimg mutt in ssh session from android is
> not fun, to put it mildly...  

Yes, that might be it.

Meelis, please test this:

==========
fix a braino in compat_sys_getrlimit()

Fixes: commit d9e968cb9f84 "getrlimit()/setrlimit(): move compat to native"
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Acked-by: David S. Miller <davem@davemloft.net>

diff --git a/kernel/sys.c b/kernel/sys.c
index 73fc0af..2855ee7 100644
--- a/kernel/sys.c
+++ b/kernel/sys.c
@@ -1362,7 +1362,7 @@ COMPAT_SYSCALL_DEFINE2(getrlimit, unsigned int, resource,
 
 	ret = do_prlimit(current, resource, NULL, &r);
 	if (!ret) {
-		struct rlimit r32;
+		struct compat_rlimit r32;
 		if (r.rlim_cur > COMPAT_RLIM_INFINITY)
 			r32.rlim_cur = COMPAT_RLIM_INFINITY;
 		else

^ permalink raw reply related	[flat|nested] 24+ messages in thread

* Re: in:imklog segfault in 4.12+git on most sparc64's
@ 2017-07-12  4:09       ` David Miller
  0 siblings, 0 replies; 24+ messages in thread
From: David Miller @ 2017-07-12  4:09 UTC (permalink / raw)
  To: viro; +Cc: mroos, sparclinux, linux-kernel, torvalds

From: Al Viro <viro@ZenIV.linux.org.uk>
Date: Wed, 12 Jul 2017 04:59:45 +0100

> Again, my apologies for format of that all - I'm almost completely
> off-net and while typing an ed script is feasible, context diff is
> too far over the top.  Usimg mutt in ssh session from android is
> not fun, to put it mildly...  

Yes, that might be it.

Meelis, please test this:

====================
fix a braino in compat_sys_getrlimit()

Fixes: commit d9e968cb9f84 "getrlimit()/setrlimit(): move compat to native"
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Acked-by: David S. Miller <davem@davemloft.net>

diff --git a/kernel/sys.c b/kernel/sys.c
index 73fc0af..2855ee7 100644
--- a/kernel/sys.c
+++ b/kernel/sys.c
@@ -1362,7 +1362,7 @@ COMPAT_SYSCALL_DEFINE2(getrlimit, unsigned int, resource,
 
 	ret = do_prlimit(current, resource, NULL, &r);
 	if (!ret) {
-		struct rlimit r32;
+		struct compat_rlimit r32;
 		if (r.rlim_cur > COMPAT_RLIM_INFINITY)
 			r32.rlim_cur = COMPAT_RLIM_INFINITY;
 		else

^ permalink raw reply related	[flat|nested] 24+ messages in thread

* Re: in:imklog segfault in 4.12+git on most sparc64's
  2017-07-12  4:09       ` David Miller
@ 2017-07-12  7:09         ` Meelis Roos
  -1 siblings, 0 replies; 24+ messages in thread
From: Meelis Roos @ 2017-07-12  7:09 UTC (permalink / raw)
  To: David Miller; +Cc: viro, sparclinux, Linux Kernel list, torvalds

> From: Al Viro <viro@ZenIV.linux.org.uk>
> Date: Wed, 12 Jul 2017 04:59:45 +0100
> 
> > Again, my apologies for format of that all - I'm almost completely
> > off-net and while typing an ed script is feasible, context diff is
> > too far over the top.  Usimg mutt in ssh session from android is
> > not fun, to put it mildly...  
> 
> Yes, that might be it.
> 
> Meelis, please test this:
> 
> ==========
> fix a braino in compat_sys_getrlimit()
> 
> Fixes: commit d9e968cb9f84 "getrlimit()/setrlimit(): move compat to native"
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> Acked-by: David S. Miller <davem@davemloft.net>

Yes, it works right on top of 4.12.0-rc1-00007-gd9e968c and on top of 
todays git as well. 

-- 
Meelis Roos (mroos@linux.ee)

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: in:imklog segfault in 4.12+git on most sparc64's
@ 2017-07-12  7:09         ` Meelis Roos
  0 siblings, 0 replies; 24+ messages in thread
From: Meelis Roos @ 2017-07-12  7:09 UTC (permalink / raw)
  To: David Miller; +Cc: viro, sparclinux, Linux Kernel list, torvalds

> From: Al Viro <viro@ZenIV.linux.org.uk>
> Date: Wed, 12 Jul 2017 04:59:45 +0100
> 
> > Again, my apologies for format of that all - I'm almost completely
> > off-net and while typing an ed script is feasible, context diff is
> > too far over the top.  Usimg mutt in ssh session from android is
> > not fun, to put it mildly...  
> 
> Yes, that might be it.
> 
> Meelis, please test this:
> 
> ====================
> fix a braino in compat_sys_getrlimit()
> 
> Fixes: commit d9e968cb9f84 "getrlimit()/setrlimit(): move compat to native"
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> Acked-by: David S. Miller <davem@davemloft.net>

Yes, it works right on top of 4.12.0-rc1-00007-gd9e968c and on top of 
todays git as well. 

-- 
Meelis Roos (mroos@linux.ee)

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: in:imklog segfault in 4.12+git on most sparc64's
  2017-07-12  7:09         ` Meelis Roos
@ 2017-07-12 16:09           ` David Miller
  -1 siblings, 0 replies; 24+ messages in thread
From: David Miller @ 2017-07-12 16:09 UTC (permalink / raw)
  To: mroos; +Cc: viro, sparclinux, linux-kernel, torvalds

From: Meelis Roos <mroos@linux.ee>
Date: Wed, 12 Jul 2017 10:09:50 +0300 (EEST)

>> From: Al Viro <viro@ZenIV.linux.org.uk>
>> Date: Wed, 12 Jul 2017 04:59:45 +0100
>> 
>> > Again, my apologies for format of that all - I'm almost completely
>> > off-net and while typing an ed script is feasible, context diff is
>> > too far over the top.  Usimg mutt in ssh session from android is
>> > not fun, to put it mildly...  
>> 
>> Yes, that might be it.
>> 
>> Meelis, please test this:
>> 
>> ==========
>> fix a braino in compat_sys_getrlimit()
>> 
>> Fixes: commit d9e968cb9f84 "getrlimit()/setrlimit(): move compat to native"
>> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
>> Acked-by: David S. Miller <davem@davemloft.net>
> 
> Yes, it works right on top of 4.12.0-rc1-00007-gd9e968c and on top of 
> todays git as well. 

Al, please push this to Linus soon.

Thanks.


^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: in:imklog segfault in 4.12+git on most sparc64's
@ 2017-07-12 16:09           ` David Miller
  0 siblings, 0 replies; 24+ messages in thread
From: David Miller @ 2017-07-12 16:09 UTC (permalink / raw)
  To: mroos; +Cc: viro, sparclinux, linux-kernel, torvalds

From: Meelis Roos <mroos@linux.ee>
Date: Wed, 12 Jul 2017 10:09:50 +0300 (EEST)

>> From: Al Viro <viro@ZenIV.linux.org.uk>
>> Date: Wed, 12 Jul 2017 04:59:45 +0100
>> 
>> > Again, my apologies for format of that all - I'm almost completely
>> > off-net and while typing an ed script is feasible, context diff is
>> > too far over the top.  Usimg mutt in ssh session from android is
>> > not fun, to put it mildly...  
>> 
>> Yes, that might be it.
>> 
>> Meelis, please test this:
>> 
>> ====================
>> fix a braino in compat_sys_getrlimit()
>> 
>> Fixes: commit d9e968cb9f84 "getrlimit()/setrlimit(): move compat to native"
>> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
>> Acked-by: David S. Miller <davem@davemloft.net>
> 
> Yes, it works right on top of 4.12.0-rc1-00007-gd9e968c and on top of 
> todays git as well. 

Al, please push this to Linus soon.

Thanks.

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: in:imklog segfault in 4.12+git on most sparc64's
  2017-07-12 16:09           ` David Miller
@ 2017-07-12 16:14             ` Linus Torvalds
  -1 siblings, 0 replies; 24+ messages in thread
From: Linus Torvalds @ 2017-07-12 16:14 UTC (permalink / raw)
  To: David Miller; +Cc: Meelis Roos, Al Viro, sparclinux, Linux Kernel Mailing List

On Wed, Jul 12, 2017 at 9:09 AM, David Miller <davem@davemloft.net> wrote:
>
> Al, please push this to Linus soon.

I'll take it directly, Al is currently in Boston without a real
computer methinks.

             Linus

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: in:imklog segfault in 4.12+git on most sparc64's
@ 2017-07-12 16:14             ` Linus Torvalds
  0 siblings, 0 replies; 24+ messages in thread
From: Linus Torvalds @ 2017-07-12 16:14 UTC (permalink / raw)
  To: David Miller; +Cc: Meelis Roos, Al Viro, sparclinux, Linux Kernel Mailing List

On Wed, Jul 12, 2017 at 9:09 AM, David Miller <davem@davemloft.net> wrote:
>
> Al, please push this to Linus soon.

I'll take it directly, Al is currently in Boston without a real
computer methinks.

             Linus

^ permalink raw reply	[flat|nested] 24+ messages in thread

end of thread, other threads:[~2017-07-12 16:14 UTC | newest]

Thread overview: 24+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-10  8:25 in:imklog segfault in 4.12+git on most sparc64's Meelis Roos
2017-07-10  8:38 ` John Paul Adrian Glaubitz
2017-07-10 11:46 ` Meelis Roos
2017-07-10 11:48 ` John Paul Adrian Glaubitz
2017-07-10 18:31 ` David Miller
2017-07-10 18:32 ` David Miller
2017-07-10 18:35 ` John Paul Adrian Glaubitz
2017-07-10 18:42 ` David Miller
2017-07-10 18:47 ` John Paul Adrian Glaubitz
2017-07-11 11:48 ` Meelis Roos
2017-07-11 11:48   ` Meelis Roos
2017-07-12  3:13   ` David Miller
2017-07-12  3:13     ` David Miller
2017-07-12  3:59   ` Al Viro
2017-07-12  3:59     ` Al Viro
2017-07-12  4:09     ` David Miller
2017-07-12  4:09       ` David Miller
2017-07-12  7:09       ` Meelis Roos
2017-07-12  7:09         ` Meelis Roos
2017-07-12 16:09         ` David Miller
2017-07-12 16:09           ` David Miller
2017-07-12 16:14           ` Linus Torvalds
2017-07-12 16:14             ` Linus Torvalds
2017-07-11 13:56 ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.