From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v1 1/1] ARM: dts: imx6: RIoTboard provide gpio-line-names
Date: Wed, 12 Jul 2017 15:06:11 +0800 [thread overview]
Message-ID: <20170712070609.GG3172@dragon> (raw)
In-Reply-To: <20170620142830.5119-1-o.rempel@pengutronix.de>
On Tue, Jun 20, 2017 at 04:28:30PM +0200, Oleksij Rempel wrote:
> for each gpio controller
Please write up a complete sentence. If you can explain a bit why these
names are useful would be better.
>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
> arch/arm/boot/dts/imx6dl-riotboard.dts | 61 ++++++++++++++++++++++++++++++++++
> 1 file changed, 61 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6dl-riotboard.dts b/arch/arm/boot/dts/imx6dl-riotboard.dts
> index 2cb72824e800..b9ecb3b3792a 100644
> --- a/arch/arm/boot/dts/imx6dl-riotboard.dts
> +++ b/arch/arm/boot/dts/imx6dl-riotboard.dts
> @@ -84,6 +84,67 @@
> };
> };
>
> +&gpio1 {
> + gpio-line-names =
> + "", "", "[SD2_WP]", "", "[SD2_CD]", "I2C3_SCL",
> + "I2C3_SDA", "I2C4_SCL",
> + "I2C4_SDA", "", "", "", "", "", "", "",
> + "", "PWM3", "", "", "", "", "", "",
> + "", "", "", "", "", "", "", "";
> +};
> +
> +&gpio2 {
> + gpio-line-names =
> + "", "", "", "", "", "", "", "",
> + "", "", "", "", "", "", "", "",
> + "", "", "", "", "", "", "", "",
> + "", "", "", "", "", "", "", "";
> +};
> +
> +&gpio3 {
> + gpio-line-names =
> + "", "", "", "", "", "", "", "",
> + "", "", "", "", "", "", "", "",
> + "", "", "", "", "", "", "[USB_OTG_VBUS]", "",
> + "UART3_TXD", "UART3_RXD", "", "", "[EIM_D28]", "", "", "";
> +};
> +
> +&gpio4 {
> + gpio-line-names =
> + "", "", "", "", "", "", "UART4_TXD", "UART4_RXD",
> + "UART5_TXD", "UART5_RXD", "", "", "", "", "", "",
> + "GPIO4_16", "GPIO4_17", "GPIO4_18", "GPIO4_19", "",
> + "CSPI3_CLK", "CSPI3_MOSI", "CSPI3_MISO",
> + "CSPI3_CS0", "CSPI3_CS1", "GPIO4_26", "GPIO4_27",
> + "CSPI3_RDY", "PWM1", "PWM2", "GPIO4_31";
> +};
> +
> +&gpio5 {
> + gpio-line-names =
> + "", "", "[EIM_A25]", "", "", "GPIO5_05", "GPIO5_06",
> + "GPIO5_07",
> + "GPIO5_08", "CSPI2_CS1", "CSPI2_MOSI", "CSPI2_MISO",
> + "CSPI2_CS0", "CSPI2_CLK", "", "",
> + "", "", "", "", "", "", "", "",
> + "", "", "", "", "", "", "", "";
> +};
> +
> +&gpio6 {
> + gpio-line-names =
> + "", "", "", "", "", "", "", "",
> + "", "", "", "", "", "", "", "",
> + "", "", "", "", "", "", "", "",
> + "", "", "", "", "", "", "", "";
> +};
> +
> +&gpio7 {
> + gpio-line-names =
> + "[SD3_CD]", "[SD3_WP]", "", "", "", "", "", "",
> + "", "", "", "", "", "", "", "",
> + "", "", "", "", "", "", "", "",
> + "", "", "", "", "", "", "", "";
> +};
> +
> &audmux {
Please keep the new added nodes sorted alphabetically in label name.
Shawn
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_audmux>;
> --
> 2.11.0
>
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Oleksij Rempel <o.rempel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: Sascha Hauer <kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
Fabio Estevam <fabio.estevam-3arQi8VN3Tc@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Russell King <linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v1 1/1] ARM: dts: imx6: RIoTboard provide gpio-line-names
Date: Wed, 12 Jul 2017 15:06:11 +0800 [thread overview]
Message-ID: <20170712070609.GG3172@dragon> (raw)
In-Reply-To: <20170620142830.5119-1-o.rempel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
On Tue, Jun 20, 2017 at 04:28:30PM +0200, Oleksij Rempel wrote:
> for each gpio controller
Please write up a complete sentence. If you can explain a bit why these
names are useful would be better.
>
> Signed-off-by: Oleksij Rempel <o.rempel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> ---
> arch/arm/boot/dts/imx6dl-riotboard.dts | 61 ++++++++++++++++++++++++++++++++++
> 1 file changed, 61 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6dl-riotboard.dts b/arch/arm/boot/dts/imx6dl-riotboard.dts
> index 2cb72824e800..b9ecb3b3792a 100644
> --- a/arch/arm/boot/dts/imx6dl-riotboard.dts
> +++ b/arch/arm/boot/dts/imx6dl-riotboard.dts
> @@ -84,6 +84,67 @@
> };
> };
>
> +&gpio1 {
> + gpio-line-names =
> + "", "", "[SD2_WP]", "", "[SD2_CD]", "I2C3_SCL",
> + "I2C3_SDA", "I2C4_SCL",
> + "I2C4_SDA", "", "", "", "", "", "", "",
> + "", "PWM3", "", "", "", "", "", "",
> + "", "", "", "", "", "", "", "";
> +};
> +
> +&gpio2 {
> + gpio-line-names =
> + "", "", "", "", "", "", "", "",
> + "", "", "", "", "", "", "", "",
> + "", "", "", "", "", "", "", "",
> + "", "", "", "", "", "", "", "";
> +};
> +
> +&gpio3 {
> + gpio-line-names =
> + "", "", "", "", "", "", "", "",
> + "", "", "", "", "", "", "", "",
> + "", "", "", "", "", "", "[USB_OTG_VBUS]", "",
> + "UART3_TXD", "UART3_RXD", "", "", "[EIM_D28]", "", "", "";
> +};
> +
> +&gpio4 {
> + gpio-line-names =
> + "", "", "", "", "", "", "UART4_TXD", "UART4_RXD",
> + "UART5_TXD", "UART5_RXD", "", "", "", "", "", "",
> + "GPIO4_16", "GPIO4_17", "GPIO4_18", "GPIO4_19", "",
> + "CSPI3_CLK", "CSPI3_MOSI", "CSPI3_MISO",
> + "CSPI3_CS0", "CSPI3_CS1", "GPIO4_26", "GPIO4_27",
> + "CSPI3_RDY", "PWM1", "PWM2", "GPIO4_31";
> +};
> +
> +&gpio5 {
> + gpio-line-names =
> + "", "", "[EIM_A25]", "", "", "GPIO5_05", "GPIO5_06",
> + "GPIO5_07",
> + "GPIO5_08", "CSPI2_CS1", "CSPI2_MOSI", "CSPI2_MISO",
> + "CSPI2_CS0", "CSPI2_CLK", "", "",
> + "", "", "", "", "", "", "", "",
> + "", "", "", "", "", "", "", "";
> +};
> +
> +&gpio6 {
> + gpio-line-names =
> + "", "", "", "", "", "", "", "",
> + "", "", "", "", "", "", "", "",
> + "", "", "", "", "", "", "", "",
> + "", "", "", "", "", "", "", "";
> +};
> +
> +&gpio7 {
> + gpio-line-names =
> + "[SD3_CD]", "[SD3_WP]", "", "", "", "", "", "",
> + "", "", "", "", "", "", "", "",
> + "", "", "", "", "", "", "", "",
> + "", "", "", "", "", "", "", "";
> +};
> +
> &audmux {
Please keep the new added nodes sorted alphabetically in label name.
Shawn
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_audmux>;
> --
> 2.11.0
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Sascha Hauer <kernel@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Russell King <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1] ARM: dts: imx6: RIoTboard provide gpio-line-names
Date: Wed, 12 Jul 2017 15:06:11 +0800 [thread overview]
Message-ID: <20170712070609.GG3172@dragon> (raw)
In-Reply-To: <20170620142830.5119-1-o.rempel@pengutronix.de>
On Tue, Jun 20, 2017 at 04:28:30PM +0200, Oleksij Rempel wrote:
> for each gpio controller
Please write up a complete sentence. If you can explain a bit why these
names are useful would be better.
>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
> arch/arm/boot/dts/imx6dl-riotboard.dts | 61 ++++++++++++++++++++++++++++++++++
> 1 file changed, 61 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6dl-riotboard.dts b/arch/arm/boot/dts/imx6dl-riotboard.dts
> index 2cb72824e800..b9ecb3b3792a 100644
> --- a/arch/arm/boot/dts/imx6dl-riotboard.dts
> +++ b/arch/arm/boot/dts/imx6dl-riotboard.dts
> @@ -84,6 +84,67 @@
> };
> };
>
> +&gpio1 {
> + gpio-line-names =
> + "", "", "[SD2_WP]", "", "[SD2_CD]", "I2C3_SCL",
> + "I2C3_SDA", "I2C4_SCL",
> + "I2C4_SDA", "", "", "", "", "", "", "",
> + "", "PWM3", "", "", "", "", "", "",
> + "", "", "", "", "", "", "", "";
> +};
> +
> +&gpio2 {
> + gpio-line-names =
> + "", "", "", "", "", "", "", "",
> + "", "", "", "", "", "", "", "",
> + "", "", "", "", "", "", "", "",
> + "", "", "", "", "", "", "", "";
> +};
> +
> +&gpio3 {
> + gpio-line-names =
> + "", "", "", "", "", "", "", "",
> + "", "", "", "", "", "", "", "",
> + "", "", "", "", "", "", "[USB_OTG_VBUS]", "",
> + "UART3_TXD", "UART3_RXD", "", "", "[EIM_D28]", "", "", "";
> +};
> +
> +&gpio4 {
> + gpio-line-names =
> + "", "", "", "", "", "", "UART4_TXD", "UART4_RXD",
> + "UART5_TXD", "UART5_RXD", "", "", "", "", "", "",
> + "GPIO4_16", "GPIO4_17", "GPIO4_18", "GPIO4_19", "",
> + "CSPI3_CLK", "CSPI3_MOSI", "CSPI3_MISO",
> + "CSPI3_CS0", "CSPI3_CS1", "GPIO4_26", "GPIO4_27",
> + "CSPI3_RDY", "PWM1", "PWM2", "GPIO4_31";
> +};
> +
> +&gpio5 {
> + gpio-line-names =
> + "", "", "[EIM_A25]", "", "", "GPIO5_05", "GPIO5_06",
> + "GPIO5_07",
> + "GPIO5_08", "CSPI2_CS1", "CSPI2_MOSI", "CSPI2_MISO",
> + "CSPI2_CS0", "CSPI2_CLK", "", "",
> + "", "", "", "", "", "", "", "",
> + "", "", "", "", "", "", "", "";
> +};
> +
> +&gpio6 {
> + gpio-line-names =
> + "", "", "", "", "", "", "", "",
> + "", "", "", "", "", "", "", "",
> + "", "", "", "", "", "", "", "",
> + "", "", "", "", "", "", "", "";
> +};
> +
> +&gpio7 {
> + gpio-line-names =
> + "[SD3_CD]", "[SD3_WP]", "", "", "", "", "", "",
> + "", "", "", "", "", "", "", "",
> + "", "", "", "", "", "", "", "",
> + "", "", "", "", "", "", "", "";
> +};
> +
> &audmux {
Please keep the new added nodes sorted alphabetically in label name.
Shawn
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_audmux>;
> --
> 2.11.0
>
next prev parent reply other threads:[~2017-07-12 7:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-20 14:28 [PATCH v1 1/1] ARM: dts: imx6: RIoTboard provide gpio-line-names Oleksij Rempel
2017-06-20 14:28 ` Oleksij Rempel
2017-06-20 14:28 ` Oleksij Rempel
2017-07-12 7:06 ` Shawn Guo [this message]
2017-07-12 7:06 ` Shawn Guo
2017-07-12 7:06 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170712070609.GG3172@dragon \
--to=shawnguo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.